ante: improve diff URL conversion logic

* Gracefully handle diff URLs which are from other wikis
* Show overwritten fields when converting diff URL
* Show error when attempting to automatically get date
  from a supplied (non-)revision ID

Author: ChlodAlejandro

i18n/ante/en.json

@@ -47,6 +47,7 @@
     "deputy.ante.templateOptions": "Template options",
 
     "deputy.ante.dateAuto": "Pull the date from the provided revision ID (`$1` parameter)",
+    "deputy.ante.dateAuto.invalid": "Parameter does not appear to be a valid revision ID.",
     "deputy.ante.dateAuto.failed": "Could not pull date from revision: $1",
     "deputy.ante.dateAuto.missing": "The revision $1 could not be found. Its page may have been deleted.",
 
@@ -93,6 +94,7 @@
     "deputy.ante.copied.diff.placeholder": "https://en.wikipedia.org/w/index.php?diff=123456",
     "deputy.ante.copied.diff.label": "Diff URL",
     "deputy.ante.copied.diff.help": "The URL of the diff. Using <code>to_diff</code> and <code>to_oldid</code> is preferred, although supplying this parameter will override both.",
+
     "deputy.ante.copied.merge.label": "Merged?",
     "deputy.ante.copied.merge.help": "Whether the copying was done as a result of merging two pages.",
     "deputy.ante.copied.afd.placeholder": "AfD page (without Wikipedia:Articles for deletion/)",
@@ -103,6 +105,7 @@
     "deputy.ante.copied.advanced": "Advanced",
     "deputy.ante.copied.dateInvalid": "The previous date value, \"$1\", was not a valid date.",
     "deputy.ante.copied.diffDeprecate": "The <code>to_diff</code> and <code>to_oldid</code> parameters are preferred in favor of the <code>diff</code> parameter.",
+    "deputy.ante.copied.diffDeprecate.warnHost": "The URL in this parameter is not the same as the wiki you're currently editing on. Continue?",
     "deputy.ante.copied.diffDeprecate.replace": "The current value of '$1', \"$2\", will be replaced with \"$3\". Continue?",
     "deputy.ante.copied.diffDeprecate.failed": "Cannot convert `diff` parameter to URL. See your browser console for more details.",
 

src/modules/ante/ui/components/RevisionDateGetButton.tsx

@@ -51,11 +51,22 @@ function initRevisionDateGetButton() {
 		 * `this.revisionInputWidget`.
 		 */
 		async setDateFromRevision(): Promise<void> {
+			const revid = this.revisionInputWidget.getValue();
+
+			if ( isNaN( +revid ) ) {
+				mw.notify(
+					mw.msg( 'deputy.ante.dateAuto.invalid' ),
+					{ type: 'error' }
+				);
+				this.updateButton();
+				return;
+			}
+
 			this
 				.setIcon( 'ellipsis' )
 				.setDisabled( true );
 			this.dateInputWidget.setDisabled( true );
-			const revid = this.revisionInputWidget.getValue();
+
 			await MwApi.action.get( {
 				action: 'query',
 				prop: 'revisions',

src/modules/ante/ui/pages/CopiedTemplateRowPage.tsx

@@ -537,15 +537,19 @@ function initCopiedTemplateRowPage() {
 		 * Converts a raw diff URL on the same wiki as the current to use `to` and `to_oldid`
 		 * (and `to_diff`, if available).
 		 */
-		convertDeprecatedDiff(): void {
+		async convertDeprecatedDiff(): Promise<void> {
 			const value = this.inputs.diff.getValue();
 			try {
 				const url = new URL( value, window.location.href );
 				if ( !value ) {
 					return;
 				}
-				if ( url.host === window.location.host ) {
-					console.warn( 'Attempted to convert a diff URL from another wiki.' );
+				if ( url.host !== window.location.host ) {
+					if ( !( await OO.ui.confirm(
+						mw.msg( 'deputy.ante.copied.diffDeprecate.warnHost' )
+					) ) ) {
+						return;
+					}
 				}
 				// From the same wiki, accept deprecation
 
@@ -556,6 +560,7 @@ function initCopiedTemplateRowPage() {
 
 				// Attempt to get values from Special:Diff short-link
 				const diffSpecialPageCheck =
+					// eslint-disable-next-line security/detect-unsafe-regex
 					/\/wiki\/Special:Diff\/(prev|next|\d+)(?:\/(prev|next|\d+))?/.exec( url.pathname );
 				if ( diffSpecialPageCheck != null ) {
 					if (
@@ -574,7 +579,14 @@ function initCopiedTemplateRowPage() {
 					}
 				}
 
+				// If only an oldid was provided, and no diff
+				if ( oldid && !diff ) {
+					diff = oldid;
+					oldid = undefined;
+				}
+
 				const confirmProcess = new OO.ui.Process();
+				// Looping over the row name and the value that will replace it.
 				for ( const [ _rowName, newValue ] of [
 					[ 'to_oldid', oldid ],
 					[ 'to_diff', diff ],
@@ -601,12 +613,14 @@ function initCopiedTemplateRowPage() {
 							confirmPromise.done( ( confirmed: boolean ) => {
 								if ( confirmed ) {
 									this.inputs[ rowName ].setValue( newValue );
+									this.fieldLayouts[ rowName ].toggle( true );
 								}
 							} );
 							return confirmPromise;
 						} );
 					} else {
 						this.inputs[ rowName ].setValue( newValue );
+						this.fieldLayouts[ rowName ].toggle( true );
 					}
 				}
 				confirmProcess.next( () => {