Skip to content

Commit bfc9469

Browse files
cci: support 'zero' diff sizes
1 parent 618e065 commit bfc9469

3 files changed

Lines changed: 19 additions & 3 deletions

File tree

i18n/shared/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"deputy.close": "Close",
1818
"deputy.positiveDiff": "+{{FORMATNUM:$1}}",
1919
"deputy.negativeDiff": "-{{FORMATNUM:$1}}",
20+
"deputy.zeroDiff": "0",
2021
"deputy.moreInfo": "More information",
2122
"deputy.dismiss": "Dismiss",
2223

src/ui/root/DeputyChangesListElements.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,17 @@ export function ChangesListDiff(
212212
).text()
213213
}>
214214
{
215+
// Messages that can be used here:
216+
// * deputy.negativeDiff
217+
// * deputy.positiveDiff
218+
// * deputy.zeroDiff
215219
mw.message(
216220
`deputy.${
217-
diffsize < 0 ? 'negative' : 'positive'
221+
{
222+
'-1': 'negative',
223+
1: 'positive',
224+
0: 'zero'
225+
}[ Math.sign( diffsize ) ]
218226
}Diff`,
219227
diffsize.toString()
220228
).text()

src/ui/root/DeputyContributionSurveyRow.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -776,10 +776,17 @@ export default class DeputyContributionSurveyRow extends EventTarget implements
776776
);
777777

778778
parts.push(
779-
// eslint-disable-next-line mediawiki/msg-doc
779+
// Messages that can be used here:
780+
// * deputy.negativeDiff
781+
// * deputy.positiveDiff
782+
// * deputy.zeroDiff
780783
mw.message(
781784
`deputy.${
782-
largestDiff.diffsize < 0 ? 'negative' : 'positive'
785+
{
786+
'-1': 'negative',
787+
1: 'positive',
788+
0: 'zero'
789+
}[ Math.sign( largestDiff.diffsize ) ]
783790
}Diff`,
784791
largestDiff.diffsize.toString()
785792
).text()

0 commit comments

Comments
 (0)