From e12dd8b4758b5bee7c63836fae18a9cd6beb627f Mon Sep 17 00:00:00 2001 From: ChlodAlejandro Date: Wed, 10 Aug 2022 11:18:21 +0800 Subject: [PATCH] allow diff numbers in splitArticle.diff --- i18n/ante/en.json | 6 +++--- src/modules/ante/ui/pages/SplitArticleTemplateRowPage.tsx | 7 ++++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/i18n/ante/en.json b/i18n/ante/en.json index bc4276ba..4839c7d0 100644 --- a/i18n/ante/en.json +++ b/i18n/ante/en.json @@ -112,9 +112,9 @@ "deputy.ante.splitArticle.from_oldid.help": "The revision ID of the original page prior to the split. This is the revision that still contains content that will eventually become part of the split, with the following revision (or succeeding revisions) progressively transferring content to the other pages.", "deputy.ante.splitArticle.date.label": "Date of split", "deputy.ante.splitArticle.date.help": "The date that the split occurred.", - "deputy.ante.splitArticle.diff.placeholder": "https://en.wikipedia.org/w/index.php?diff=123456&oldid=123455", - "deputy.ante.splitArticle.diff.label": "Diff URL", - "deputy.ante.splitArticle.diff.help": "The diff URL of the split.", + "deputy.ante.splitArticle.diff.placeholder": "123456789", + "deputy.ante.splitArticle.diff.label": "Diff", + "deputy.ante.splitArticle.diff.help": "The diff URL or revision ID of the split.", "deputy.ante.mergedFrom.label": "Merged from $1", "deputy.ante.mergedFrom.remove": "Remove notice", diff --git a/src/modules/ante/ui/pages/SplitArticleTemplateRowPage.tsx b/src/modules/ante/ui/pages/SplitArticleTemplateRowPage.tsx index d539a0ff..a83568a4 100644 --- a/src/modules/ante/ui/pages/SplitArticleTemplateRowPage.tsx +++ b/src/modules/ante/ui/pages/SplitArticleTemplateRowPage.tsx @@ -174,7 +174,12 @@ function initSplitArticleTemplateRowPage() { value: this.splitArticleTemplateRow.from_oldid || '', placeholder: mw.message( 'deputy.ante.splitArticle.diff.placeholder' ).text(), validate: ( value: string ) => { - if ( value.trim().length === 0 ) { + if ( + // Blank + value.trim().length === 0 || + // Diff number + !isNaN( +value ) + ) { return true; } try {