File tree 3 files changed +16
-18
lines changed
3 files changed +16
-18
lines changed Original file line number Diff line number Diff line change @@ -16,29 +16,24 @@ export function ChangesListLinks(
16
16
{ revid : _revid , parentid : _parentid , missing } :
17
17
{ revid : number , parentid : number , missing ?: boolean }
18
18
) : JSX . Element {
19
- let diff : number | 'prev' = _revid ;
20
- let oldid = _parentid ;
21
- if ( missing ) {
22
- oldid = _revid ;
23
- diff = 'prev' ;
24
- }
19
+ const cur = getRevisionDiffURL ( _revid , 'cur' ) ;
20
+ const prev = missing ?
21
+ getRevisionDiffURL ( _revid , 'prev' ) :
22
+ getRevisionDiffURL ( _parentid , _revid ) ;
25
23
26
24
return < span class = "mw-changeslist-links" >
27
25
< span > < a
28
26
rel = "noopener"
29
- href = { getRevisionDiffURL ( diff , ' cur' ) }
27
+ href = { cur }
30
28
title = { mw . msg ( 'deputy.session.revision.cur.tooltip' ) }
31
29
target = "_blank"
32
30
> { mw . msg ( 'deputy.session.revision.cur' ) } </ a > </ span >
33
31
< span > {
34
- ! oldid ?
32
+ ( ! _parentid && ! missing ) ?
35
33
mw . msg ( 'deputy.session.revision.prev' ) :
36
34
< a
37
35
rel = "noopener"
38
- href = { ! oldid ?
39
- null :
40
- getRevisionDiffURL ( oldid , diff )
41
- }
36
+ href = { prev }
42
37
title = { mw . msg ( 'deputy.session.revision.prev.tooltip' ) }
43
38
target = "_blank"
44
39
> { mw . msg ( 'deputy.session.revision.prev' ) } </ a >
Original file line number Diff line number Diff line change @@ -189,11 +189,11 @@ export default class DeputyContributionSurveyRevision
189
189
return < span >
190
190
{
191
191
! this . revision . parentid && < NewPageIndicator />
192
- } < ChangesListTime
192
+ } < ChangesListTime
193
193
timestamp = { this . revision . timestamp }
194
194
/> < ChangesListDate
195
195
revision = { this . revision }
196
- /> < ChangesListUser
196
+ /> < ChangesListUser
197
197
user = { this . revision . user }
198
198
/> < span
199
199
class = "mw-changeslist-separator"
@@ -216,7 +216,7 @@ export default class DeputyContributionSurveyRevision
216
216
*/
217
217
renderMissingRevisionInfo ( ) : HTMLElement {
218
218
return < span >
219
- < i dangerouslySetInnerHTML = { mw . message (
219
+ { ' ' } < i dangerouslySetInnerHTML = { mw . message (
220
220
'deputy.session.revision.missing' ,
221
221
this . revision . revid
222
222
) . parse ( ) } />
@@ -241,7 +241,7 @@ export default class DeputyContributionSurveyRevision
241
241
revid = { this . revision . revid }
242
242
parentid = { this . revision . parentid }
243
243
missing = { ( this . revision as any ) . missing }
244
- /> { unwrapElement (
244
+ /> { unwrapElement (
245
245
( this . revision as any ) . missing ?
246
246
this . renderMissingRevisionInfo ( ) :
247
247
this . renderRevisionInfo ( )
Original file line number Diff line number Diff line change 5
5
* @param el The element to unwrap.
6
6
* @return The unwrapped element.
7
7
*/
8
- export default function ( el : HTMLElement ) : HTMLElement [ ] {
9
- return Array . from ( el . children ) as HTMLElement [ ] ;
8
+ export default function ( el : HTMLElement ) : ( HTMLElement | string ) [ ] {
9
+ return Array . from ( el . childNodes ) . map ( v =>
10
+ v instanceof HTMLElement ? v :
11
+ ( v instanceof Text ? v . textContent : undefined )
12
+ ) . filter ( v => v !== undefined ) ;
10
13
}
You can’t perform that action at this time.
0 commit comments