remove DeputyPreferences

DeputyPreferences is a forgotten duplicate of what
is now UserConfiguration, and only ever has one
setting inside of it. Removing it in favor of the
more-featured and maintained Configuration system.

Author: ChlodAlejandro

i18n/settings/en.json

@@ -53,6 +53,8 @@
     "deputy.setting.user.cci.showCvLink.description": "Show a \"cv\" link next to \"cur\" and \"prev\" on revision rows. This link will only appear if this wiki is configured to use Earwig's Copyvio Detector.",
     "deputy.setting.user.cci.showUsername.name": "Show username",
     "deputy.setting.user.cci.showUsername.description": "Show the username of the user who made the edit on revision rows. This may be redundant for cases which only have one editor.",
+    "deputy.setting.user.cci.autoCollapseRows.name": "Automatically collapse rows",
+    "deputy.setting.user.cci.autoCollapseRows.description": "Automatically collapse rows when the page is loaded. This is useful for cases where each row has many revisions, but may be annoying for cases where each row has few revisions.",
     "deputy.setting.user.cci.autoShowDiff.name": "Automatically show diffs",
     "deputy.setting.user.cci.autoShowDiff.description": "Enabling automatic loading of diffs. Configurable with two additional options to avoid loading too much content.",
     "deputy.setting.user.cci.maxRevisionsToAutoShowDiff.name": "Maximum revisions to automatically show diff",

src/Deputy.ts

@@ -5,7 +5,6 @@ import DeputySession from './session/DeputySession';
 import DeputyCasePage from './wiki/DeputyCasePage';
 import DeputyDispatch from './api/DeputyDispatch';
 import ContributionSurveyRow from './models/ContributionSurveyRow';
-import { DeputyPreferences } from './DeputyPreferences';
 import performHacks from './wiki/util/performHacks';
 import DeputyCase from './wiki/DeputyCase';
 import unwrapWidget from './util/unwrapWidget';
@@ -43,7 +42,6 @@ class Deputy {
 	readonly DeputyDispatch = DeputyDispatch;
 	readonly DeputyStorage = DeputyStorage;
 	readonly DeputySession = DeputySession;
-	readonly DeputyPreferences = DeputyPreferences;
 	readonly DeputyCommunications = DeputyCommunications;
 	readonly DeputyCase = DeputyCase;
 	readonly DeputyCasePage = DeputyCasePage;
@@ -74,7 +72,6 @@ class Deputy {
 
 	dispatch: DeputyDispatch;
 	storage: DeputyStorage;
-	prefs: DeputyPreferences;
 	comms: DeputyCommunications;
 	session: DeputySession;
 	config: UserConfiguration;
@@ -153,8 +150,6 @@ class Deputy {
 		await this.storage.init();
 		// Initialize the Deputy API interface
 		this.dispatch = new DeputyDispatch();
-		// Initialize the Deputy preferences instance
-		this.prefs = new DeputyPreferences();
 		// Initialize communications
 		this.comms = new DeputyCommunications();
 		this.comms.init();

src/DeputyPreferences.ts

@@ -92,6 +92,12 @@ export default class UserConfiguration extends ConfigurationBase {
 				type: 'checkbox'
 			}
 		} ),
+		autoCollapseRows: new Setting<boolean, boolean>( {
+			defaultValue: false,
+			displayOptions: {
+				type: 'checkbox'
+			}
+		} ),
 		autoShowDiff: new Setting<boolean, boolean>( {
 			defaultValue: false,
 			displayOptions: {

src/config/UserConfiguration.ts

@@ -845,7 +845,7 @@ export default class DeputyContributionSurveyRow extends EventTarget implements
 			framed: false
 		} );
 
-		let contentToggled = window.deputy.prefs.get( 'cci.contentDefault' );
+		let contentToggled = !window.deputy.config.cci.autoCollapseRows.get();
 		/**
 		 * Toggles the content.
 		 *