Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVC Clean Up #43

Open
Chrstjan opened this issue Mar 5, 2024 · 0 comments
Open

MVC Clean Up #43

Chrstjan opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
JavaScript JavaScript Production

Comments

@Chrstjan
Copy link
Owner

Chrstjan commented Mar 5, 2024

Some model code is inside some controller code this should be moved into it's own functions

  • retrieveLocalStorage functions contains controller & model
    The local storage should be moved into a function called getLocalStorage
    The retrieveLocalStorage function should be renamed to retrieveShoppingCart

  • removeFromCart function should call the getLocalStorage function instead of having model code

  • cartCallback function should call the getLocalStorage function instead of having model code
    The model code in the if statement should also be moved into a model function called setLocalStorage

@Chrstjan Chrstjan added the JavaScript JavaScript Production label Mar 5, 2024
@Chrstjan Chrstjan self-assigned this Mar 5, 2024
Chrstjan added a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript JavaScript Production
Projects
None yet
Development

No branches or pull requests

1 participant