Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the toolbox.py as a separate API for python developers #19

Closed
crisjf opened this issue Jun 5, 2020 · 2 comments
Closed

Package the toolbox.py as a separate API for python developers #19

crisjf opened this issue Jun 5, 2020 · 2 comments
Assignees

Comments

@crisjf
Copy link
Collaborator

crisjf commented Jun 5, 2020

We talked about packaging the toolbox we are developing as separate API for python developers to work on CityScope modules. I'm creating this issue to keep track of ideas along these lines.

@crisjf
Copy link
Collaborator Author

crisjf commented Jun 5, 2020

I think we should restructure the classes such that Indicator.assign_geogrid_props is moved to the Handler class. As it is, the Handler is creating multiple copies of Handler.geogrid_props, one for each indicator. This is not an issue right now, but it might be if geogrid_props starts getting more complex.

An alternative behavior is to follow the Indicator.requires_geometry logic and create a property for each indicator that is Indicator.use_geogrid_props, such that the Handler passes geogrid_props to the Indicator.return_indicator function at each call. This might also improve integration with sklearn (#13) as people could just develop a Pipeline that works with the numbers from geogrid_props. In our use case, where each EconomicIndicator uses geogrid_props to convert geogrid_data to the model input, the Handler could just take care of that.

@crisjf
Copy link
Collaborator Author

crisjf commented Sep 17, 2020

@crisjf crisjf closed this as completed Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants