You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We talked about packaging the toolbox we are developing as separate API for python developers to work on CityScope modules. I'm creating this issue to keep track of ideas along these lines.
The text was updated successfully, but these errors were encountered:
I think we should restructure the classes such that Indicator.assign_geogrid_props is moved to the Handler class. As it is, the Handler is creating multiple copies of Handler.geogrid_props, one for each indicator. This is not an issue right now, but it might be if geogrid_props starts getting more complex.
An alternative behavior is to follow the Indicator.requires_geometry logic and create a property for each indicator that is Indicator.use_geogrid_props, such that the Handler passes geogrid_props to the Indicator.return_indicator function at each call. This might also improve integration with sklearn (#13) as people could just develop a Pipeline that works with the numbers from geogrid_props. In our use case, where each EconomicIndicator uses geogrid_props to convert geogrid_data to the model input, the Handler could just take care of that.
We talked about packaging the toolbox we are developing as separate API for python developers to work on CityScope modules. I'm creating this issue to keep track of ideas along these lines.
The text was updated successfully, but these errors were encountered: