Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add i18n to some spliced string #79371

Open
EliadOArias opened this issue Jan 27, 2025 · 0 comments · May be fixed by #79402
Open

Cannot add i18n to some spliced string #79371

EliadOArias opened this issue Jan 27, 2025 · 0 comments · May be fixed by #79402
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@EliadOArias
Copy link
Contributor

Describe the bug

The update of the electronic storage device introduced some hard-coded string concatenations, which is impossible or difficult to add i18n.
Here are some I have found:

  • game_menus::inv::efile_select
    Image
  • game_menus::inv::edevice_select
    Image
    i18n won't work on them, as the final message is a spliced string.
  • efile_activity_actor::efile_action_name
    Image
    This one is much better for any single part support i18n, but there are MANY languages whose word order is completely different from that of English. Hard-coded word order is bad.

Attach save file

N/A

Steps to reproduce

Try to add i18n to these parts for any language.

Expected behavior

Why use spliced string, not %s ?? This is unreasonable.

Screenshots

No response

Versions and configuration

N/A

Additional context

Stop using spliced string please.

@EliadOArias EliadOArias added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 27, 2025
@Procyonae Procyonae linked a pull request Jan 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant