refactor: code revision, English translation and logic cleanup

- Translated technical comments from Russian to English in ConfigManager.
- Simplified MLB and ROM selection logic by removing redundant branches.
- Added fallbacks for RtROM using System UUID if no network card is found.
- Cleaned up redundant manual GPU vendor checks in applySettings()
  in favor of more robust loop-based detection.
- Unified code style for Turbo and Graphics injection settings.

Author: YBronst

rEFIt_UEFI/Platform/AcpiPatcher.cpp

@@ -687,9 +687,7 @@ void PreCleanupRSDT()
   }
 
   //REVIEW: really?
-  // Если адрес RSDT < адреса XSDT и хвост RSDT наползает на XSDT, то подрезаем хвост RSDT до начала XSDT
-  // English: If the RSDT address of the XSDT address and the tail of the RSDT crawls onto the XSDT, then we
-  // trim the RSDT tail before the XSDT starts
+  // If RSDT address < XSDT address and RSDT tail overlaps with XSDT, then trim RSDT tail to the start of XSDT
   if ((UINTN)Rsdt < (UINTN)Xsdt && (UINTN)Rsdt + Rsdt->Header.Length > (UINTN)Xsdt) {
     UINTN v = ((UINTN)Xsdt - (UINTN)Rsdt) & ~3;
     Rsdt->Header.Length = (UINT32)v;

rEFIt_UEFI/Platform/Settings.cpp

@@ -472,10 +472,10 @@ void afterGetUserSettings(SETTINGS_DATA& settingsData)
 
   if ( settingsData.RtVariables.RtROMAsString.isEqualIC("UseMacAddr0") ) {
     if ( gConf.LanCardArray.size() > 0 ) GlobalConfig.RtROM.ncpy(&gConf.LanCardArray[0].MacAddress[0], 6);
-    else GlobalConfig.RtROM.memset(0, 6);
+    else GlobalConfig.RtROM.setEmpty(0, 6);
   } else if ( settingsData.RtVariables.RtROMAsString.isEqualIC("UseMacAddr1") ) {
     if ( gConf.LanCardArray.size() > 1 ) GlobalConfig.RtROM.ncpy(&gConf.LanCardArray[1].MacAddress[0], 6);
-    else GlobalConfig.RtROM.memset(0, 6);
+    else GlobalConfig.RtROM.setEmpty(0, 6);
   }else{
     GlobalConfig.RtROM = settingsData.RtVariables.RtROMAsData;
   }

rEFIt_UEFI/Platform/cpu.cpp

@@ -1159,12 +1159,13 @@ void GetCPUProperties (void)
   tmpU = gCPUStructure.FSBFrequency;
 	DBG("Corrected FSBFrequency = %llu MHz\n", DivU64x32(tmpU, Mega));
 
-  if ((gCPUStructure.Vendor == CPU_VENDOR_INTEL) && (gCPUStructure.Model == CPU_MODEL_NEHALEM)) {
+  if ((gCPUStructure.Vendor == CPU_VENDOR_INTEL) &&
+      ((gCPUStructure.Model == CPU_MODEL_NEHALEM) || (gCPUStructure.Model == CPU_MODEL_NEHALEM_EX) ||
+       (gCPUStructure.Model == CPU_MODEL_WESTMERE) || (gCPUStructure.Model == CPU_MODEL_WESTMERE_EX))) {
     //Slice - for Nehalem we can do more calculation as in Cham
     // but this algo almost always wrong
     //
     // thanks to dgobe for i3/i5/i7 bus speed detection
-    // TODO: consider more Nehalem based CPU(?) ex. CPU_MODEL_NEHALEM_EX, CPU_MODEL_WESTMERE, CPU_MODEL_WESTMERE_EX
     // info: https://en.wikipedia.org/wiki/List_of_Intel_Xeon_microprocessors#Nehalem-based_Xeons
     qpimult = 2; //init
     /* Scan PCI BUS For QPI Frequency */
@@ -1612,7 +1613,11 @@ MacModel GetDefaultModel()
       case CPU_MODEL_ICELAKE_A:
       case CPU_MODEL_ICELAKE_C:
       case CPU_MODEL_ICELAKE_D:
-      case CPU_MODEL_ALDERLAKE_ULT:  //???
+      case CPU_MODEL_TIGERLAKE_C:
+      case CPU_MODEL_TIGERLAKE_D:
+      case CPU_MODEL_ALDERLAKE_ULT:
+      case CPU_MODEL_RAPTORLAKE_B:
+      case CPU_MODEL_METEORLAKE:
       case CPU_MODEL_ARROWLAKE_U:
         DefaultType = MacBookPro161;
         break;
@@ -1725,16 +1730,22 @@ MacModel GetDefaultModel()
       case CPU_MODEL_BROADWELL_E5:
         DefaultType = MacPro61;
         break;
-      case CPU_MODEL_ALDERLAKE:
-
-      case CPU_MODEL_RAPTORLAKE_B:
       case CPU_MODEL_COMETLAKE_S:
+        if ( gCPUStructure.BrandString.contains("i9") ) {
+          DefaultType = iMac202;
+          break;
+        }
+        DefaultType = iMac201;
+        break;
       case CPU_MODEL_ROCKETLAKE:
+        DefaultType = iMac201;
+        break;
+      case CPU_MODEL_ALDERLAKE:
       case CPU_MODEL_RAPTORLAKE:
       case CPU_MODEL_METEORLAKE:
       case CPU_MODEL_ARROWLAKE:
       case CPU_MODEL_ARROWLAKE_X:
-
+      case CPU_MODEL_RAPTORLAKE_B:
         DefaultType = MacPro71;
         break;
       default:

rEFIt_UEFI/Platform/device_inject.cpp

@@ -148,7 +148,7 @@ DevPropDevice *devprop_add_device_pci(DevPropString *StringBuf, pci_dt_t *PciDt,
     return NULL;
   }
 
-  //просмотреть StringBuf->entries[] в поисках такого же девайса
+  // scan StringBuf->entries[] for the same device
   //SameDevice(DevPropDevice* D1, DevPropDevice* D2)
 
   if (!DevicePath && (PciDt != 0)) {

rEFIt_UEFI/Platform/platformdata.cpp

@@ -559,7 +559,7 @@ UINT64 GetPlatformFeature(MacModel Model)
     case MacBookAir82:
     case MacBookAir91:
       return 0x1A; //3A;
-      // It is nonsense, ASCII code сharacter "2" = 0x32 != 0x02. Don't use ioreg, so that not to be confused. Use dmidecode dump.
+      // It is nonsense, ASCII code character "2" = 0x32 != 0x02. Don't use ioreg, so that not to be confused. Use dmidecode dump.
     default:
       return 0xFFFF; // disabled
     }

rEFIt_UEFI/Platform/smbios.cpp

@@ -922,6 +922,10 @@ void PatchTableType4(const SmbiosInjectedSettings& smbiosSettings)
         newSmbiosTable.Type4->ProcessorFamily = ProcessorFamilyIntelCoreI5;
       if ( smbiosSettings.BrandString.contains("i7") )
         newSmbiosTable.Type4->ProcessorFamily = ProcessorFamilyIntelCoreI7;
+      if ( smbiosSettings.BrandString.contains("i9") )
+        newSmbiosTable.Type4->ProcessorFamily = ProcessorFamilyIntelCoreI9;
+      if ( smbiosSettings.BrandString.contains("Xeon") )
+        newSmbiosTable.Type4->ProcessorFamily = ProcessorFamilyIntelXeon;
     }
     //spec 2.7 page 48 note 3
     if ((newSmbiosTable.Type4->ProcessorFamily == ProcessorFamilyIntelCore2)

rEFIt_UEFI/Platform/usbfix.cpp

@@ -307,7 +307,7 @@ DBG("FixOwnership() -> begin\n");
                 //
                DBG("USB XHCI reset for device %04hX\n", Pci.Hdr.DeviceId);
                if (Pci.Hdr.VendorId != 0x8086) {
-                 //ну ее нах эту ВИА, да и прочих, кроме Интел
+                 // forget about VIA and others, except Intel
                  DBG("skip XHCI controller Vendor=%04X\n", Pci.Hdr.VendorId);
                  break;
                }

rEFIt_UEFI/Settings/ConfigManager.cpp

@@ -596,7 +596,7 @@ EFI_STATUS ConfigManager::LoadSMBIOSPlist(const XStringW& ConfName)
   return Status;
 }
 
-void ConfigManager::ReloadSmbios(XStringW& str)  // ищет смбиос по имени системы
+void ConfigManager::ReloadSmbios(XStringW& str)  // searches for SMBIOS by system name
 {
   size_t N = SmbiosList.size();
   if (OldChosenSmbios == 0) {  // this is auto fill by OSName
@@ -669,21 +669,33 @@ void ConfigManager::applySettings() const
   {
     if ( !configPlist.Graphics.Inject.isInjectIntelDefined() )
     {
-      gSettings.Graphics.InjectAsDict.InjectIntel =
-              (gConf.GfxPropertiesArray.size() > 0 && gConf.GfxPropertiesArray[0].Vendor == Intel) ||
-              (gConf.GfxPropertiesArray.size() > 1 && gConf.GfxPropertiesArray[1].Vendor == Intel);
+      gSettings.Graphics.InjectAsDict.InjectIntel = false;
+      for (size_t i = 0; i < gConf.GfxPropertiesArray.size(); i++) {
+        if (gConf.GfxPropertiesArray[i].Vendor == Intel) {
+          gSettings.Graphics.InjectAsDict.InjectIntel = true;
+          break;
+        }
+      }
     }
     if ( !configPlist.Graphics.Inject.isInjectATIDefined() )
     {
-      gSettings.Graphics.InjectAsDict.InjectATI =
-              (gConf.GfxPropertiesArray.size() > 0 && gConf.GfxPropertiesArray[0].Vendor == Ati && (gConf.GfxPropertiesArray[0].DeviceID & 0xF000) != 0x6000 )  ||
-              (gConf.GfxPropertiesArray.size() > 1 && gConf.GfxPropertiesArray[1].Vendor == Ati && (gConf.GfxPropertiesArray[1].DeviceID & 0xF000) != 0x6000 );
+      gSettings.Graphics.InjectAsDict.InjectATI = false;
+      for (size_t i = 0; i < gConf.GfxPropertiesArray.size(); i++) {
+        if (gConf.GfxPropertiesArray[i].Vendor == Ati && (gConf.GfxPropertiesArray[i].DeviceID & 0xF000) != 0x6000) {
+          gSettings.Graphics.InjectAsDict.InjectATI = true;
+          break;
+        }
+      }
     }
     if ( !configPlist.Graphics.Inject.isInjectNVidiaDefined() )
     {
-      gSettings.Graphics.InjectAsDict.InjectNVidia =
-        ( gConf.GfxPropertiesArray.isCardAtPosNvidia(0)  &&  gConf.GfxPropertiesArray[0].Family < 0xE0) ||
-        ( gConf.GfxPropertiesArray.isCardAtPosNvidia(1)  &&  gConf.GfxPropertiesArray[1].Family < 0xE0);
+      gSettings.Graphics.InjectAsDict.InjectNVidia = false;
+      for (size_t i = 0; i < gConf.GfxPropertiesArray.size(); i++) {
+        if (gConf.GfxPropertiesArray.isCardAtPosNvidia(i) && gConf.GfxPropertiesArray[i].Family < 0xE0) {
+          gSettings.Graphics.InjectAsDict.InjectNVidia = true;
+          break;
+        }
+      }
     }
     if ( configPlist.RtVariables.dgetBooterCfgStr().isEmpty() )
     {

rEFIt_UEFI/libeg/load_bmp.cpp

@@ -202,7 +202,7 @@ EFI_STATUS XImage::FromBMP(UINT8 *FileData, IN UINTN FileDataLength)
           PixelPtr->Reserved = AlphaValue;
           PixelPtr++;
         }
-        if ((RealPixelWidth & 1) == 1) { // для нечетных
+        if ((RealPixelWidth & 1) == 1) { // for odd numbers
           ImageValue = *ImagePtr++;
 
           Index = ImageValue >> 4;
@@ -247,7 +247,7 @@ EFI_STATUS XImage::FromBMP(UINT8 *FileData, IN UINTN FileDataLength)
 
     }
   }
-  DBG("sucсess\n");
+  DBG("success\n");
   return EFI_SUCCESS;
 }