Refactor: libcrmcommon: Drop check for unused flag from str_any_of()

nrwahl2 · nrwahl2 · commit 2c94e0565b15 · 2025-03-02T16:53:00.000-08:00
This is a static function and we never pass in pcmk__str_null_matches.

Signed-off-by: Reid Wahl &lt;nrwahl@protonmail.com&gt;
diff --git a/lib/common/strings.c b/lib/common/strings.c
@@ -994,7 +994,7 @@ static bool
 str_any_of(const char *s, va_list args, uint32_t flags)
 {
     if (s == NULL) {
-        return pcmk_is_set(flags, pcmk__str_null_matches);
+        return false;
     }
 
     while (1) {

Original file line number	Diff line number	Diff line change
`@@ -994,7 +994,7 @@ static bool`
`994`	`994`	`str_any_of(const char *s, va_list args, uint32_t flags)`
`995`	`995`	`{`
`996`	`996`	`if (s == NULL) {`
`997`		`- return pcmk_is_set(flags, pcmk__str_null_matches);`
	`997`	`+ return false;`
`998`	`998`	`}`
`999`	`999`
`1000`	`1000`	`while (1) {`