Refactor: tools: Strip trailing whitespace in load_env_vars()

We consider the value invalid if anything besides whitespace or a
comment (beginning with '#') follows it on the line. Further, we ignore
all trailing whitespace after a valid value. So it's fine to strip all
trailing whitespace, including a newline if present, before processing.

Clearly we must now look for '\0' where we previously looked for '\n'.

Signed-off-by: Reid Wahl <[email protected]>

Author: nrwahl2

daemons/execd/remoted_pidone.c

@@ -112,8 +112,8 @@ load_env_vars(void)
         char *value_end = NULL;
         char *quote = NULL;
 
-        // Strip leading whitespace
-        g_strchug(line);
+        // Strip leading and trailing whitespace
+        g_strstrip(line);
 
         // Look for valid name immediately followed by equals sign
         if (!find_env_var_name(line, &name, &end) || (*++end != '=')) {
@@ -157,15 +157,17 @@ load_env_vars(void)
 
         /* We have a valid name and value, and end is now the character after
          * the closing quote or the first whitespace after the unquoted value.
-         * Make sure the rest of the line is just whitespace or a comment.
+         * Make sure the rest of the line, if any, is just optional whitespace
+         * followed by a comment.
          */
         value_end = end;
 
-        while (isspace(*end) && (*end != '\n')) {
+        while (isspace(*end)) {
             end++;
         }
 
-        if ((*end != '\n') && (*end != '#')) {
+        if ((*end != '\0') && (*end != '#')) {
+            // Found garbage after value
             goto cleanup_loop;
         }