Refactor: various: Drop pcmk__rsc_methods_t:parameter()

Nothing calls it

Signed-off-by: Reid Wahl <[email protected]>

Author: nrwahl2

include/crm/common/resources_internal.h

@@ -203,22 +203,6 @@ typedef struct {
     pcmk_resource_t *(*find_rsc)(pcmk_resource_t *rsc, const char *search,
                                  const pcmk_node_t *node, uint32_t flags);
 
-    /*!
-     * \internal
-     * \brief Get value of a resource instance attribute
-     *
-     * \param[in,out] rsc        Resource to check
-     * \param[in]     node       Node to use to evaluate rules
-     * \param[in]     create     Ignored
-     * \param[in]     name       Name of instance attribute to check
-     * \param[in,out] scheduler  Scheduler data
-     *
-     * \return Value of requested attribute if available, otherwise NULL
-     * \note The caller is responsible for freeing the result using free().
-     */
-    char *(*parameter)(pcmk_resource_t *rsc, pcmk_node_t *node, gboolean create,
-                       const char *name, pcmk_scheduler_t *scheduler);
-
     /*!
      * \internal
      * \brief Check whether a resource is active

include/crm/pengine/internal.h

@@ -58,8 +58,6 @@ void pe__create_promotable_pseudo_ops(pcmk_resource_t *clone,
 
 bool pe_can_fence(const pcmk_scheduler_t *scheduler, const pcmk_node_t *node);
 
-char *native_parameter(pcmk_resource_t *rsc, pcmk_node_t *node, gboolean create,
-                       const char *name, pcmk_scheduler_t *scheduler);
 pcmk_node_t *native_location(const pcmk_resource_t *rsc, GList **list,
                              uint32_t target);
 void native_add_running(pcmk_resource_t *rsc, pcmk_node_t *node,

lib/pengine/complex.c

@@ -26,7 +26,6 @@ static pcmk__rsc_methods_t resource_class_functions[] = {
     {
          native_unpack,
          native_find_rsc,
-         native_parameter,
          native_active,
          native_resource_state,
          native_location,
@@ -39,7 +38,6 @@ static pcmk__rsc_methods_t resource_class_functions[] = {
     {
          group_unpack,
          native_find_rsc,
-         native_parameter,
          group_active,
          group_resource_state,
          native_location,
@@ -52,7 +50,6 @@ static pcmk__rsc_methods_t resource_class_functions[] = {
     {
          clone_unpack,
          native_find_rsc,
-         native_parameter,
          clone_active,
          clone_resource_state,
          native_location,
@@ -65,7 +62,6 @@ static pcmk__rsc_methods_t resource_class_functions[] = {
     {
          pe__unpack_bundle,
          native_find_rsc,
-         native_parameter,
          pe__bundle_active,
          pe__bundle_resource_state,
          native_location,

lib/pengine/native.c

@@ -321,27 +321,6 @@ native_find_rsc(pcmk_resource_t *rsc, const char *id,
     return NULL;
 }
 
-// create is ignored
-char *
-native_parameter(pcmk_resource_t *rsc, pcmk_node_t *node, gboolean create,
-                 const char *name, pcmk_scheduler_t *scheduler)
-{
-    const char *value = NULL;
-    GHashTable *params = NULL;
-
-    CRM_CHECK(rsc != NULL, return NULL);
-    CRM_CHECK(name != NULL && strlen(name) != 0, return NULL);
-
-    pcmk__rsc_trace(rsc, "Looking up %s in %s", name, rsc->id);
-    params = pe_rsc_params(rsc, node, scheduler);
-    value = g_hash_table_lookup(params, name);
-    if (value == NULL) {
-        /* try meta attributes instead */
-        value = g_hash_table_lookup(rsc->priv->meta, name);
-    }
-    return pcmk__str_copy(value);
-}
-
 gboolean
 native_active(pcmk_resource_t * rsc, gboolean all)
 {