Low: fencer: Fix ISO 8601 interval parsing in pcmk_delay_base

An ISO 8601 interval can include a colon character. I can't think of any
valid reason why a user would specify an interval this way for a fencing
delay, but there doesn't seem to be any reason to exclude mapping values
that have a colon. The "make sure there's no colon" check seemed to be
an artifact of the way the parsing code worked before we started using
g_strsplit(), etc.

Signed-off-by: Reid Wahl <[email protected]>

Author: nrwahl2

daemons/fenced/fenced_commands.c

@@ -261,6 +261,10 @@ get_value_for_target(const char *target, const char *values)
     return value;
 }
 
+/* @TODO Consolidate some of this with build_port_aliases(). But keep in mind
+ * that build_port_aliases()/pcmk__host_map supports either '=' or ':' as a
+ * mapping separator, while pcmk_delay_base supports only ':'.
+ */
 static int
 get_action_delay_base(const fenced_device_t *device, const char *action,
                       const char *target)
@@ -293,10 +297,11 @@ get_action_delay_base(const fenced_device_t *device, const char *action,
         stripped = NULL;
     }
 
-    if (strchr(delay_base_s, ':') == NULL) {
-        pcmk_parse_interval_spec(delay_base_s, &delay_base);
-        delay_base /= 1000;
-    }
+    /* @TODO Should we accept only a simple time+units string, rather than an
+     * ISO 8601 interval?
+     */
+    pcmk_parse_interval_spec(delay_base_s, &delay_base);
+    delay_base /= 1000;
 
     g_free(stripped);
     g_free(delay_base_s);