Low: fencer: Drop support for escaped characters in pcmk_host_map

This reverts e95198f.

Backslash escapes are useful in C and on the command line, but it's not
clear how they would be useful in a pcmk_host_map value. Backslash
escapes are not used in XML, where the configuration is stored.

The removed code did the following upon finding a backslash:
* If we're not inside the value part of a host-to-port mapping, skip
  both a backslash and the character after it.
* Otherwise, skip the backslash and keep the character after it (unless
  that character is also a backslash).

This doesn't seem to make sense. Any characters that are special in XML
attribute values would need to be escaped using XML entities. Other
characters, including backslashes, are allowed as literals.
* https://www.w3.org/TR/REC-xml/#NT-AttValue

Signed-off-by: Reid Wahl <[email protected]>

Author: nrwahl2

daemons/fenced/fenced_commands.c

@@ -915,11 +915,6 @@ build_port_aliases(const char *hostmap, GList ** targets)
     len = strlen(hostmap);
     for (int i = 0; i <= len; i++) {
         switch (hostmap[i]) {
-                /* Skip escaped chars */
-            case '\\':
-                i++;
-                break;
-
                 /* Assignment chars */
             case '=':
             case ':':
@@ -938,19 +933,11 @@ build_port_aliases(const char *hostmap, GList ** targets)
             case ' ':
             case '\t':
                 if (name) {
-                    int k = 0;
                     char *value = pcmk__assert_alloc(1 + i - last,
                                                      sizeof(char));
 
                     memcpy(value, hostmap + last, i - last);
 
-                    for (int i = 0; value[i] != '\0'; i++) {
-                        if (value[i] != '\\') {
-                            value[k++] = value[i];
-                        }
-                    }
-                    value[k] = '\0';
-
                     crm_debug("Adding alias '%s'='%s'", name, value);
                     g_hash_table_replace(aliases, name, value);
                     *targets = g_list_append(*targets, pcmk__str_copy(value));