Low: cts: Fix the BadNews messages that the SplitBrain test ignores.

This has been broken since the message changed in 07a19bc, but we
didn't notice because the SplitBrain test has been disabled for a long
time.

Additionally, I've removed the "stonith " part from the beginning of the
string.  Other resources can cause the same message to be printed in the
SplitBrain test.  We could have a whole separate message for this case,
but I'm not sure it's worth it.

Author: clumens

python/pacemaker/_cts/patterns.py

@@ -76,7 +76,7 @@ def __init__(self):
             "Pat:Fencing_start": r"Requesting peer fencing .* targeting %s",
             "Pat:Fencing_ok": r"pacemaker-fenced.*:\s*Operation .* targeting %s by .* for .*@.*: OK",
             "Pat:Fencing_recover": r"pacemaker-schedulerd.*: Recover\s+%s",
-            "Pat:Fencing_active": r"stonith resource .* is active on 2 nodes (attempting recovery)",
+            "Pat:Resource_active": r"resource .* might be active on \d+ nodes \(attempting recovery\)",
             "Pat:Fencing_probe": r"pacemaker-controld.* Result of probe operation for %s on .*: Error",
 
             "Pat:RscOpOK": r"pacemaker-controld.*:\s+Result of %s operation for %s.*: (0 \()?OK",

python/pacemaker/_cts/tests/componentfail.py

@@ -79,7 +79,7 @@ def __call__(self, node):
             # Ignore actions for fence devices if fencer will respawn
             # (their registration will be lost, and probes will fail)
             self._okerrpatterns = [
-                self._cm.templates["Pat:Fencing_active"],
+                self._cm.templates["Pat:Resource_active"],
             ]
             (_, lines) = self._rsh(node, "crm_resource -c", verbose=1)
 

python/pacemaker/_cts/tests/splitbraintest.py

@@ -200,7 +200,8 @@ def errors_to_ignore(self):
             r"Another DC detected:",
             r"(ERROR|error).*: .*Application of an update diff failed",
             r"pacemaker-controld.*:.*not in our membership list",
-            r"CRIT:.*node.*returning after partition"
+            r"CRIT:.*node.*returning after partition",
+            self._cm.templates["Pat:Resource_active"],
         ]
 
     def is_applicable(self):

python/pacemaker/_cts/tests/stonithdtest.py

@@ -125,7 +125,7 @@ def errors_to_ignore(self):
         return [
             self._cm.templates["Pat:Fencing_start"] % ".*",
             self._cm.templates["Pat:Fencing_ok"] % ".*",
-            self._cm.templates["Pat:Fencing_active"],
+            self._cm.templates["Pat:Resource_active"],
             r"error.*: Operation 'reboot' targeting .* by .* for stonith_admin.*: Timer expired"
         ]