Moved magic string delimeters to separate files.

Author: JoshVarty

src/SourceBrowser.Generator/DocumentWalkers/CSWalker.cs

@@ -168,16 +168,23 @@ public Token ProcessSymbolUsage(SyntaxToken token, ISymbol symbol, bool isDeclar
 
         private string GetSymbolName(ISymbol symbol)
         {
-            if (symbol.Kind == SymbolKind.Parameter || symbol.Kind == SymbolKind.Local)
+            string fullyQualifiedName;
+            if (symbol.Kind == SymbolKind.Parameter) 
             {
                 var containingName = symbol.ContainingSymbol.ToString();
-                var name = containingName + "::" + symbol.Name;
-                return name;
+                fullyQualifiedName = containingName + CSharpDelimiters.PARAMETER + symbol.Name;
+            }
+            else if (symbol.Kind == SymbolKind.Local) 
+            {
+                var containingName = symbol.ContainingSymbol.ToString();
+                fullyQualifiedName = containingName + CSharpDelimiters.LOCAL_VARIABLE + symbol.Name;
             }
             else
             {
-                return symbol.ToString();
+                fullyQualifiedName = symbol.ToString();
             }
+
+            return fullyQualifiedName;
         }
 
         public Token ProcessIdentifier(SyntaxToken token)

src/SourceBrowser.Generator/DocumentWalkers/VBWalker.cs

@@ -168,16 +168,23 @@ public Token ProcessSymbolUsage(SyntaxToken token, ISymbol symbol, bool isDeclar
 
         private string GetSymbolName(ISymbol symbol)
         {
-            if (symbol.Kind == SymbolKind.Parameter || symbol.Kind == SymbolKind.Local)
+            string fullyQualifiedName;
+            if (symbol.Kind == SymbolKind.Parameter)
             {
                 var containingName = symbol.ContainingSymbol.ToString();
-                var name = containingName + "::" + symbol.Name;
-                return name;
+                fullyQualifiedName = containingName + VBDelimiters.PARAMETER + symbol.Name;
+            }
+            else if (symbol.Kind == SymbolKind.Local)
+            {
+                var containingName = symbol.ContainingSymbol.ToString();
+                fullyQualifiedName = containingName + VBDelimiters.LOCAL_VARIABLE + symbol.Name;
             }
             else
             {
-                return symbol.ToString();
+                fullyQualifiedName = symbol.ToString();
             }
+
+            return fullyQualifiedName;
         }
 
         public Token ProcessIdentifier(SyntaxToken token)

src/SourceBrowser.Generator/Model/CSharp/CSharpDelimiters.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace SourceBrowser.Generator.Model.CSharp
+{
+    /// <summary>
+    /// Fully qualified names do not contain enough information to differentiate
+    /// between some symbols. Occasionally we must extend C#'s fully qualified names
+    /// to refer to certain symbols.
+    /// 
+    /// Examples: Local variables, parameters, static constructors etc.
+    /// </summary>
+    public static class CSharpDelimiters
+    {
+        public const string LOCAL_VARIABLE = "::";
+        public const string PARAMETER = "::";
+    }
+}

src/SourceBrowser.Generator/Model/VisualBasic/VBDelimiters.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace SourceBrowser.Generator.Model.VisualBasic
+{
+    /// <summary>
+    /// Fully qualified names do not contain enough information to differentiate
+    /// between some symbols. Occasionally we must extend VB's fully qualified names
+    /// to refer to certain symbols.
+    /// 
+    /// Examples: Local variables, parameters, static constructors etc.
+    /// </summary>
+    public static class VBDelimiters
+    {
+        public const string LOCAL_VARIABLE = "::";
+        public const string PARAMETER = "::";
+    }
+    
+}

src/SourceBrowser.Generator/SourceBrowser.Generator.csproj

@@ -92,6 +92,8 @@
     <Compile Include="DocumentWalkers\CSWalker.cs" />
     <Compile Include="Extensions\SymbolExtensions.cs" />
     <Compile Include="Hacks\DependencyHacks.cs" />
+    <Compile Include="Model\CSharp\CSharpDelimiters.cs" />
+    <Compile Include="Model\VisualBasic\VBDelimiters.cs" />
     <Compile Include="Model\VisualBasic\VisualBasicTokenTypes.cs" />
     <Compile Include="Model\CSharp\CSharpTokenTypes.cs" />
     <Compile Include="Model\DocumentModel.cs" />