diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa7..8d7bc9f 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,18 @@ - + - - + Book Library + + + - + > + @@ -31,20 +29,20 @@

Library

+ > + > Library id="pages" name="pages" required - /> + > + >
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1..18a8ef9 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -6,7 +6,7 @@ window.addEventListener("load", function (e) { }); function populateStorage() { - if (myLibrary.length == 0) { + if (myLibrary.length === 0) { let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); let book2 = new Book( "The Old Man and the Sea", @@ -28,76 +28,68 @@ const check = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + // Trim the title and check if it's empty + const trimmedTitle = title.value.trim(); + const trimmedAuthor = author.value.trim(); + + if (trimmedTitle === "" || trimmedAuthor === "" || pages.value.trim() === "") { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); } + + // Validate the "pages" field so that it is always a positive integer + const pagesValue = parseInt(pages.value, 10); + if (isNaN(pagesValue) || pagesValue <= 0) { + alert("Please enter a valid number of pages!"); + return false; + } + + // If all fields are valid, create and add the book to the library + let book = new Book(trimmedTitle, trimmedAuthor, pages.value, check.checked); + myLibrary.push(book); + render(); } + function Book(title, author, pages, check) { this.title = title; this.author = author; - this.pages = pages; + this.pages = pages; this.check = check; } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const table = document.getElementById("display"); + const tbody = table.getElementsByTagName("tbody")[0]; // Access the directly - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; + // Clear all rows in tbody + tbody.innerHTML = ''; - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + myLibrary.forEach((book, index) => { + const row = tbody.insertRow(); + row.insertCell(0).innerText = book.title; + row.insertCell(1).innerText = book.author; + row.insertCell(2).innerText = book.pages; + + // Toggle Read Button + const toggleBtn = document.createElement("button"); + toggleBtn.className = "btn btn-success"; + toggleBtn.innerText = book.check ? "Yes" : "No"; + toggleBtn.addEventListener("click", function () { + book.check = !book.check; render(); }); + row.insertCell(3).appendChild(toggleBtn); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + // Delete Button + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.innerText = "Delete"; + deleteBtn.addEventListener("click", function () { + alert(`You've deleted title: ${book.title}`); + myLibrary.splice(index, 1); render(); }); - } + row.insertCell(4).appendChild(deleteBtn); + }); }