From 019d4b2e29532ebec6e2a9e88f445a356281bc0d Mon Sep 17 00:00:00 2001 From: khalil-ali1 Date: Mon, 31 Mar 2025 14:57:16 +0100 Subject: [PATCH 1/3] fix all bugs --- debugging/book-library/script.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..098c74ec 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -37,8 +37,8 @@ function submit() { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } @@ -54,7 +54,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -77,9 +77,9 @@ function render() { wasReadCell.appendChild(changeBut); let readStatus = ""; if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { readStatus = "No"; + } else { + readStatus = "Yes"; } changeBut.innerText = readStatus; @@ -89,12 +89,12 @@ function render() { }); //add delete button to every row and render again - let delButton = document.createElement("button"); + let delBut = document.createElement("button"); delBut.id = i + 5; deleteCell.appendChild(delBut); delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delBut.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From 859ec809acc6b07cbebd67e2066e902c050dd6a4 Mon Sep 17 00:00:00 2001 From: khalil-ali1 Date: Fri, 18 Apr 2025 19:08:31 +0100 Subject: [PATCH 2/3] HTML refine based on validator.w3.org --- debugging/book-library/index.html | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..7e7411da 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,17 @@ - + - - + Library + + - + > + @@ -31,20 +28,20 @@

Library

+ > + > Library id="pages" name="pages" required - /> + > + >
From bd71d07543e7a764cece12eff42083bcf12b8673 Mon Sep 17 00:00:00 2001 From: khalil-ali1 Date: Mon, 21 Apr 2025 11:58:52 +0100 Subject: [PATCH 3/3] Update input validation --- debugging/book-library/index.html | 10 +++++----- debugging/book-library/script.js | 31 ++++++++++++++----------------- 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 7e7411da..50ab3cd3 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,7 +1,7 @@ - Library + Book Library @@ -28,7 +28,7 @@

Library

Library > Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="submit();" >
@@ -77,7 +77,7 @@

Library

- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 098c74ec..9d7aa8e2 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -6,7 +6,7 @@ window.addEventListener("load", function (e) { }); function populateStorage() { - if (myLibrary.length == 0) { + if (myLibrary.length === 0) { let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); let book2 = new Book( "The Old Man and the Sea", @@ -29,12 +29,13 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" + title.value.trim() === "" || + author.value.trim() === "" || + pages.value.trim() === "" || + pages.value < 1 || + Number.isInteger(pages.value) ) { - alert("Please fill all fields!"); + alert("Please use proper inputs and fill all fields!"); return false; } else { let book = new Book(title.value, author.value, pages.value, check.checked); @@ -51,28 +52,25 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } + + document.getElementById("table-body").innerHTML = ` ` + //insert updated row and cells let length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); + let row = document.getElementById("table-body").insertRow(); let titleCell = row.insertCell(0); let authorCell = row.insertCell(1); let pagesCell = row.insertCell(2); let wasReadCell = row.insertCell(3); let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button let changeBut = document.createElement("button"); - changeBut.id = i; changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); let readStatus = ""; @@ -90,7 +88,6 @@ function render() { //add delete button to every row and render again let delBut = document.createElement("button"); - delBut.id = i + 5; deleteCell.appendChild(delBut); delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete";