From c85236689cc1bd8dc0ab0f943434c1c095b4e1c4 Mon Sep 17 00:00:00 2001 From: Mohamed Ibrahim Mohamed Date: Tue, 22 Jul 2025 17:59:32 +0100 Subject: [PATCH 1/6] Fix: [brief message about what you changed] --- debugging/book-library/script.js | 1 + 1 file changed, 1 insertion(+) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..db4a60af 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -101,3 +101,4 @@ function render() { }); } } +// we have to fix debugging here \ No newline at end of file From eed69ad05ad5a897ce936a004e9f7114d6202e0b Mon Sep 17 00:00:00 2001 From: cyf Date: Wed, 23 Jul 2025 16:37:35 +0100 Subject: [PATCH 2/6] Refactor index.html for improved layout and functionality --- debugging/book-library/index.html | 53 ++++++++++++++++--------------- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..50b05fff 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,16 @@ - + Chi's Book Library + @@ -14,7 +18,7 @@ rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" /> - + @@ -22,16 +26,17 @@

Library

Add books to your virtual library

- + +
-
-
+
+
Library /> Library name="pages" required /> -
-
- +
- + - - - - - - - +
Title Author Number of Pages ReadActions
From 62314e6ae95ec68af15b0c411ab30b0a5aea3c3d Mon Sep 17 00:00:00 2001 From: cyf Date: Wed, 23 Jul 2025 18:48:52 +0100 Subject: [PATCH 3/6] Style: Add custom layout and spacing for form and table elements --- debugging/book-library/style.css | 40 +++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/debugging/book-library/style.css b/debugging/book-library/style.css index 302950cb..91c1a349 100644 --- a/debugging/book-library/style.css +++ b/debugging/book-library/style.css @@ -1,19 +1,43 @@ .form-group { - width: 400px; - height: 300px; - align-self: left; - padding-left: 20px; + max-width: 400px; + padding: 20px; + margin: 0 auto; + background-color: #f8f9fa; + border-radius: 8px; + box-shadow: 0 0 10px rgba(0, 0, 0, 0.1); } + .btn { display: block; + width: 100%; + margin-top: 10px; +} + +button.btn-info { + margin: 20px auto; + width: auto; + display: inline-block; } .form-check-label { - padding-left: 20px; - margin: 5px 0px 5px 0px; + padding-left: 8px; + margin: 8px 0; } -button.btn-info { - margin: 20px; +table { + margin-top: 30px; } + +.btn-success { + width: 70px; +} + +.btn-warning { + width: 100px; +} + +.container { + max-width: 800px; + margin: auto; +} \ No newline at end of file From 990a81e4e9e85d48fff9381523b609c3bc60d298 Mon Sep 17 00:00:00 2001 From: cyf Date: Wed, 23 Jul 2025 19:57:58 +0100 Subject: [PATCH 4/6] Implemented table rendering with dynamic update --- debugging/book-library/script.js | 155 ++++++++++++++----------------- 1 file changed, 70 insertions(+), 85 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index db4a60af..a15f5405 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,104 +1,89 @@ let myLibrary = []; -window.addEventListener("load", function (e) { - populateStorage(); +window.addEventListener("load", function () { + populateLibrary(); render(); + // Hook up the form submission + document.getElementById("bookForm").addEventListener("submit", function (e) { + e.preventDefault(); // Prevent page refresh + submitBook (); + }); }); -function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); +function Book(title, author, pages, read) { + this.title = title; + this.author = author; + this.pages = pages; + this.read = read; +} + +function populateLibrary() { + if (myLibrary.length === 0) { + const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); + const book2 = new Book("The Old Man and the Sea","Ernest Hemingway", + "127",true); + myLibrary.push(book1, book2); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +function submitBook() { + const titleInput = document.getElementById("title").value; + const authorInput = document.getElementById("author").value; + const pagesInput = document.getElementById("pages").value; + const readInput = document.getElementById("check").checked; -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function -function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + if (!titleInput || !authorInput || !pagesInput) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; } -} -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; + const newBook = new Book(titleInput, authorInput, parseInt(pagesInput), readInput); + myLibrary.push(newBook); + render(); + // Optionally reset the form + document.getElementById("bookForm").reset(); } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const table = document.getElementById("display"); + const oldTbody = table.querySelector("tbody"); + if (oldTbody) { + table.removeChild(oldTbody); - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; + const newTbody = document.createElement("tbody"); + myLibrary.forEach((book, index) => { + const row = document.createElement("tr"); + const titleCell = document.createElement("td"); + const authorCell = document.createElement("td"); + const pagesCell = document.createElement("td"); + const readCell = document.createElement("td"); + const toggleBtn = document.createElement("button"); + toggleBtn.className = "btn btn-success"; + toggleBtn.innerText = book.read ? "Yes" : "No"; + toggleBtn.addEventListener("click", () => { + book.read = !book.read; + render(); + }); + readCell.appendChild(toggleBtn); - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; - render(); - }); + const actionCell = document.createElement("td"); + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.innerText = "Delete"; + deleteBtn.addEventListener("click", () => { + alert(`Deleted: ${book.title}`); + myLibrary.splice(index, 1); + render(); + }); + actionCell.appendChild(deleteBtn); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); - render(); + row.appendChild(actionCell); + row.appendChild(titleCell); + row.appendChild(authorCell); + row.appendChild(pagesCell); + row.appendChild(readCell); + + newTbody.appendChild(row); }); - } -} -// we have to fix debugging here \ No newline at end of file + table.appendChild(newTbody); + } \ No newline at end of file From fcf6dfcca3bccb8f6f1bb1b45f88f45756d3955b Mon Sep 17 00:00:00 2001 From: Mohamed Ibrahim Mohamed Date: Wed, 23 Jul 2025 23:16:13 +0100 Subject: [PATCH 5/6] Fix initial render issue in table display --- debugging/book-library/script.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index a15f5405..7a4fb43a 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -49,13 +49,21 @@ function render() { const oldTbody = table.querySelector("tbody"); if (oldTbody) { table.removeChild(oldTbody); + } const newTbody = document.createElement("tbody"); myLibrary.forEach((book, index) => { const row = document.createElement("tr"); + const titleCell = document.createElement("td"); + titleCell.textContent = book.title; + const authorCell = document.createElement("td"); + authorCell.textContent = book.author; + const pagesCell = document.createElement("td"); + pagesCell.textContent = book.pages; + const readCell = document.createElement("td"); const toggleBtn = document.createElement("button"); toggleBtn.className = "btn btn-success"; @@ -77,13 +85,13 @@ function render() { }); actionCell.appendChild(deleteBtn); - row.appendChild(actionCell); row.appendChild(titleCell); row.appendChild(authorCell); row.appendChild(pagesCell); row.appendChild(readCell); + row.appendChild(actionCell); newTbody.appendChild(row); }); table.appendChild(newTbody); - } \ No newline at end of file + } From f8ec87b3fb951d444fceee5a20a431ae3a151675 Mon Sep 17 00:00:00 2001 From: Mohamed Ibrahim Mohamed Date: Fri, 1 Aug 2025 18:52:40 +0100 Subject: [PATCH 6/6] Fix form toggle, correct stylesheet link, and enable form submission --- debugging/book-library/index.html | 110 ++++++++++++------------------ debugging/book-library/script.js | 84 +++++++++++------------ 2 files changed, 83 insertions(+), 111 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 50b05fff..90f700a5 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -9,15 +9,11 @@ Chi's Book Library - @@ -26,72 +22,50 @@

Library

Add books to your virtual library

- -
- -
-
- - - - - - -
- - -
- -
+
+ + +
+
+ + + + + + + + + +
+ + +
+ + +
- - - - - - - - - - - - - -
TitleAuthorNumber of PagesReadActions
+ + + + + + + + + + + + + +
TitleAuthorNumber of PagesReadActions
- + +
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 7a4fb43a..8e8c628f 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -5,8 +5,8 @@ window.addEventListener("load", function () { render(); // Hook up the form submission document.getElementById("bookForm").addEventListener("submit", function (e) { - e.preventDefault(); // Prevent page refresh - submitBook (); + e.preventDefault(); // Prevent page refresh + submitBook(); }); }); @@ -20,8 +20,7 @@ function Book(title, author, pages, read) { function populateLibrary() { if (myLibrary.length === 0) { const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - const book2 = new Book("The Old Man and the Sea","Ernest Hemingway", - "127",true); + const book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", "127", true); myLibrary.push(book1, book2); } } @@ -40,8 +39,7 @@ function submitBook() { const newBook = new Book(titleInput, authorInput, parseInt(pagesInput), readInput); myLibrary.push(newBook); render(); - // Optionally reset the form - document.getElementById("bookForm").reset(); + document.getElementById("bookForm").reset(); // Clear form after submission } function render() { @@ -51,47 +49,47 @@ function render() { table.removeChild(oldTbody); } - const newTbody = document.createElement("tbody"); - myLibrary.forEach((book, index) => { - const row = document.createElement("tr"); + const newTbody = document.createElement("tbody"); + myLibrary.forEach((book, index) => { + const row = document.createElement("tr"); - const titleCell = document.createElement("td"); - titleCell.textContent = book.title; + const titleCell = document.createElement("td"); + titleCell.textContent = book.title; - const authorCell = document.createElement("td"); - authorCell.textContent = book.author; + const authorCell = document.createElement("td"); + authorCell.textContent = book.author; - const pagesCell = document.createElement("td"); - pagesCell.textContent = book.pages; + const pagesCell = document.createElement("td"); + pagesCell.textContent = book.pages; - const readCell = document.createElement("td"); - const toggleBtn = document.createElement("button"); - toggleBtn.className = "btn btn-success"; - toggleBtn.innerText = book.read ? "Yes" : "No"; - toggleBtn.addEventListener("click", () => { - book.read = !book.read; - render(); - }); - readCell.appendChild(toggleBtn); + const readCell = document.createElement("td"); + const toggleBtn = document.createElement("button"); + toggleBtn.className = "btn btn-success"; + toggleBtn.innerText = book.read ? "Yes" : "No"; + toggleBtn.addEventListener("click", () => { + book.read = !book.read; + render(); + }); + readCell.appendChild(toggleBtn); - const actionCell = document.createElement("td"); - const deleteBtn = document.createElement("button"); - deleteBtn.className = "btn btn-warning"; - deleteBtn.innerText = "Delete"; - deleteBtn.addEventListener("click", () => { - alert(`Deleted: ${book.title}`); - myLibrary.splice(index, 1); - render(); - }); - actionCell.appendChild(deleteBtn); + const actionCell = document.createElement("td"); + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.innerText = "Delete"; + deleteBtn.addEventListener("click", () => { + alert(`Deleted: ${book.title}`); + myLibrary.splice(index, 1); + render(); + }); + actionCell.appendChild(deleteBtn); - row.appendChild(titleCell); - row.appendChild(authorCell); - row.appendChild(pagesCell); - row.appendChild(readCell); - row.appendChild(actionCell); + row.appendChild(titleCell); + row.appendChild(authorCell); + row.appendChild(pagesCell); + row.appendChild(readCell); + row.appendChild(actionCell); - newTbody.appendChild(row); - }); - table.appendChild(newTbody); - } + newTbody.appendChild(row); + }); + table.appendChild(newTbody); +}