pr changes made

Author: Alex Jamshidi

Sprint-1/implement/dedupe.test.js

@@ -17,38 +17,43 @@ E.g. dedupe([1, 2, 1]) returns [1, 2]
 // When passed to the dedupe function
 // Then it should return an empty array
 describe("dedupe", () => {
-  [
-    { input: [], expected: [] },
-  ].forEach(({ input, expected }) =>
-    it(`returns empty array for [${input}]`, () => expect(dedupe(input)).toEqual(expected))
+  [{ input: [], expected: [] }].forEach(({ input, expected }) =>
+    it(`returns empty array for [${input}]`, () =>
+      expect(dedupe(input)).toEqual(expected))
   );
 
-
-// Given an array with no duplicates
-// When passed to the dedupe function
-// Then it should return a copy of the original array
+  // Given an array with no duplicates
+  // When passed to the dedupe function
+  // Then it should return a copy of the original array
 
   [
     { input: [1, 2, 3], expected: [1, 2, 3] },
     { input: [3, 2, 1, 4, 5], expected: [3, 2, 1, 4, 5] },
     { input: ["hello", "a", "b", "c"], expected: ["hello", "a", "b", "c"] },
     { input: [1, 2, "hello", 4, "a", 6], expected: [1, 2, "hello", 4, "a", 6] },
-  ].forEach(({ input, expected }) =>
-    it(`returns the median for [${input}]`, () => expect(dedupe(input)).toEqual(expected))
-  );
-
-// Given an array of strings or numbers
-// When passed to the dedupe function
-// Then it should return a new array with duplicates removed while preserving the 
-// first occurrence of each element from the original array.
+  ].forEach(({ input, expected }) => {
+    it(`returns array with same contents for [${input}]`, () =>
+      expect(dedupe(input)).toEqual(expected));
+    it(`returns a non-identical array (copy) for [${input}]`, () =>
+      expect(dedupe(input)).not.toBe(input));
+  });
+
+  // Given an array of strings or numbers
+  // When passed to the dedupe function
+  // Then it should return a new array with duplicates removed while preserving the
+  // first occurrence of each element from the original array.
 
   [
-    { input: [1, 1, 2, 2, 3, 3,], expected: [1, 2, 3] },
+    { input: [1, 1, 2, 2, 3, 3], expected: [1, 2, 3] },
     { input: ["a", "a", "b", "b", "c", "c"], expected: ["a", "b", "c"] },
-    { input: ["qwe", "qwe", 3, 3, "hello", "hello" , "hello"], expected: ["qwe", 3, "hello"] },
+    {
+      input: ["qwe", "qwe", 3, 3, "hello", "hello", "hello"],
+      expected: ["qwe", 3, "hello"],
+    },
     { input: ["a", "a", "a", "a"], expected: ["a"] },
     { input: [1, 2, 2, 2, 2, 2], expected: [1, 2] },
   ].forEach(({ input, expected }) =>
-    it(`returns the median for [${input}]`, () => expect(dedupe(input)).toEqual(expected))
+    it(`returns no duplicates for [${input}]`, () =>
+      expect(dedupe(input)).toEqual(expected))
   );
-});
+});

Sprint-1/implement/max.js

@@ -1,7 +1,7 @@
 function findMax(list) {
   const numbers = list.filter((n) => Number.isFinite(n));
   if (numbers.length == 0) {
-    return "-Infinity";
+    return -Infinity;
   } else {
     return Math.max(...numbers);
   }

Sprint-1/implement/max.test.js

@@ -20,7 +20,7 @@ describe("calculateMedian", () => {
 
   it("empty array returns -Infinity", () => {
     const list = [];
-    expect(findMax(list)).toEqual("-Infinity");
+    expect(findMax(list)).toEqual(-Infinity);
   });
 
   // Given an array with one number
@@ -74,6 +74,6 @@ describe("calculateMedian", () => {
 
   it("array with only non-number values, return the least surprising value given how it behaves for all other inputs", () => {
     const list = ["a", "b", "c"];
-    expect(findMax(list)).toEqual("-Infinity");
+    expect(findMax(list)).toEqual(-Infinity);
   });
 });