Skip to content

Commit 8b4f165

Browse files
committed
Fixes for comments
1 parent 801288b commit 8b4f165

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ function getCardValue(card) {
5454
}
5555

5656
// Check numeric ranks 2–10
57-
const num = Number(rank);
58-
if (num >= 2 && num <= 10) {
59-
return num;
60-
}
57+
const validNumericRanks = ["2", "3", "4", "5", "6", "7", "8", "9", "10"];
58+
if (validNumericRanks.includes(rank)) {
59+
return Number(rank);
60+
} cd
6161

6262
throw new Error("Invalid card: unknown rank");
6363
}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,12 @@ describe("getAngleType", () => {
3838
});
3939

4040
// Case 6: Invalid angles
41-
test('should return "Invalid angle" for values out of range', () => {
41+
test('should return "Invalid angle" for values ≤ 0 or > 360', () => {
4242
expect(getAngleType(0)).toBe("Invalid angle");
4343
expect(getAngleType(-10)).toBe("Invalid angle");
44+
expect(getAngleType(-1)).toBe("Invalid angle");
45+
46+
expect(getAngleType(360)).toBe("Invalid angle");
4447
expect(getAngleType(361)).toBe("Invalid angle");
4548
});
4649
});

0 commit comments

Comments
 (0)