London | 26-ITP-Jan | Alexandru Pocovnicu | Sprint 3 | implement-and-rewrite#981
Closed
alexandru-pocovnicu wants to merge 14 commits intoCodeYourFuture:mainfrom
Closed
Conversation
…pe function to pass them
… getAngleType function
…ual numerator and denominator cases in isProperFraction function
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
…tion in getAngleType function
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Feb 24, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work - only one minor issue in a test for you to look at
| @@ -8,3 +8,18 @@ const isProperFraction = require("../implement/2-is-proper-fraction"); | |||
| test(`should return false when denominator is zero`, () => { | |||
| expect(isProperFraction(1, 0)).toEqual(false); | |||
| }); | |||
There was a problem hiding this comment.
Did you try running this with npm test. See if you can figure out the issue in the logic you are using to find invalid fractions.
LonMcGregor
added
Reviewed
Author
|
thank you |
alexandru-pocovnicu
added
Needs Review
|
I am still seeing some errors when I run the npm tests. Are you also seeing these errors? |
LonMcGregor
added
Reviewed
Author
|
|
Author
|
aaa, ok , in a different suite, i'll sort it |
Author
|
done |
alexandru-pocovnicu
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
5ad4155 to
ffc428f
Compare
alexandru-pocovnicu
added
the
Needs Review
Author
|
using npm test runs a test which is part of another branch, if i delete that test from here the metadata doesn't match |
LonMcGregor
reviewed
Mar 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
OK, yes, I see, it's failing a test from another part of the branch. The tests for this specific task are passing now. This task is complete now
LonMcGregor
added
Complete
Author
|
thank you |
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all the exercises in implement-and-rewrite