Skip to content

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 5 | Allocation Laptop #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nataliia74 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 5 | Allocation Laptop #311

Nataliia74 wants to merge 2 commits into from

Conversation

@Nataliia74
Copy link

@Nataliia74 Nataliia74 commented Dec 20, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

02 Implement laptop allocation issue 179

@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 20, 2025
@OracPrime OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 6, 2026
OracPrime
OracPrime reviewed Jan 6, 2026
View reviewed changes
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code will work, but it is way too complicated. Please follow-up on the suggestion for a much simpler approach. It's often slightly harder to right simpler code, but it's worth it for everyone else that has to work with the code afterwards.

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 6, 2026
@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 14, 2026
OracPrime
OracPrime approved these changes Jan 14, 2026
View reviewed changes
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is much easier to read, well done.

@OracPrime OracPrime added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OracPrime OracPrime OracPrime approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nataliia74 @OracPrime