Azure Linux host detection code added

stesee · web-flow · commit ec0e033da98e · 2022-06-15T10:58:11.000+02:00
Added optional chromium start argument to ctor
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,201 @@
+# Remove the line below if you want to inherit .editorconfig settings from higher directories
+root = true
+
+[*.sh]
+end_of_line = lf
+
+# C# files
+[*.cs]
+
+#### Core EditorConfig Options ####
+
+# Indentation and spacing
+indent_size = 4
+indent_style = space
+tab_width = 4
+
+# New line preferences
+end_of_line = crlf
+insert_final_newline = false
+
+#### .NET Coding Conventions ####
+
+# Organize usings
+dotnet_separate_import_directive_groups = false
+dotnet_sort_system_directives_first = false
+
+# this. and Me. preferences
+dotnet_style_qualification_for_event = false:silent
+dotnet_style_qualification_for_field = false:silent
+dotnet_style_qualification_for_method = false:silent
+dotnet_style_qualification_for_property = false:silent
+
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true:silent
+dotnet_style_predefined_type_for_member_access = true:silent
+
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent
+
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+
+# Expression-level preferences
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_prefer_compound_assignment = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_simplified_interpolation = true:suggestion
+
+# Field preferences
+dotnet_style_readonly_field = true:suggestion
+
+# Parameter preferences
+dotnet_code_quality_unused_parameters = all:suggestion
+
+#### C# Coding Conventions ####
+
+# var preferences
+csharp_style_var_elsewhere = true:silent
+csharp_style_var_for_built_in_types = true:silent
+csharp_style_var_when_type_is_apparent = true:silent
+
+# Expression-bodied members
+csharp_style_expression_bodied_accessors = true:silent
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_indexers = true:silent
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = false:silent
+csharp_style_expression_bodied_methods = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:silent
+
+# Pattern matching preferences
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_prefer_switch_expression = true:suggestion
+
+# Null-checking preferences
+csharp_style_conditional_delegate_call = true:suggestion
+
+# Modifier preferences
+csharp_prefer_static_local_function = true:suggestion
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:silent
+
+# Code-block preferences
+csharp_prefer_braces = true:silent
+csharp_prefer_simple_using_statement = true:suggestion
+
+# Expression-level preferences
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_pattern_local_over_anonymous_function = true:suggestion
+csharp_style_prefer_index_operator = true:suggestion
+csharp_style_prefer_range_operator = true:suggestion
+csharp_style_throw_expression = true:suggestion
+csharp_style_unused_value_assignment_preference = discard_variable:suggestion
+csharp_style_unused_value_expression_statement_preference = discard_variable:silent
+
+# 'using' directive preferences
+csharp_using_directive_placement = outside_namespace:silent
+
+#### C# Formatting Rules ####
+
+# New line preferences
+csharp_new_line_before_catch = true
+csharp_new_line_before_else = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_between_query_expression_clauses = true
+
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_case_contents_when_block = true
+csharp_indent_labels = one_less_than_current
+csharp_indent_switch_labels = true
+
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_after_comma = true
+csharp_space_after_dot = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_after_semicolon_in_for_statement = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_around_declaration_statements = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_before_comma = false
+csharp_space_before_dot = false
+csharp_space_before_open_square_brackets = false
+csharp_space_before_semicolon_in_for_statement = false
+csharp_space_between_empty_square_brackets = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_declaration_name_and_open_parenthesis = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_between_square_brackets = false
+
+# Wrapping preferences
+csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_statements = true
+
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -19,7 +19,7 @@ jobs:
         uses: actions/setup-dotnet@v2
         with:
           dotnet-version: 6.0.x
-      - uses: actions/setup-node@v2
+      - uses: actions/setup-node@v3.2.0
         with:
           node-version: 14
       - name: Restore dependencies
diff --git a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj
@@ -39,7 +39,7 @@
 	<ItemGroup>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
 		<PackageReference Include="PuppeteerSharp" Version="7.0.0" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.37.0.45539">
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>
diff --git a/Codeuctivity.HtmlRenderer/Renderer.cs b/Codeuctivity.HtmlRenderer/Renderer.cs
@@ -12,6 +12,15 @@ namespace Codeuctivity.HtmlRenderer
     /// </summary>
     public class Renderer : IAsyncDisposable, IDisposable
     {
+        /// <summary>
+        /// Ctor
+        /// </summary>
+        /// <param name="launchOptions"></param>
+        public Renderer(string? launchOptions = null)
+        {
+            LaunchOptions = launchOptions;
+        }
+
         private Browser Browser { get; set; } = default!;
         private int LastProgressValue { get; set; }
 
@@ -20,6 +29,8 @@ public class Renderer : IAsyncDisposable, IDisposable
         /// </summary>
         public BrowserFetcher BrowserFetcher { get; private set; } = default!;
 
+        private string? LaunchOptions { get; }
+
         /// <summary>
         /// Call CreateAsync before using ConvertHtmlTo*
         /// </summary>
@@ -31,35 +42,42 @@ public static Task<Renderer> CreateAsync()
         }
 
         /// <summary>
-        /// Call CreateAsync before using ConvertHtmlTo*, accepts custom BrowserFetcher
+        /// Call CreateAsync before using ConvertHtmlTo*, accepts custom BrowserFetcher and custom chromium launch options
         /// </summary>
-        /// <returns>Initialized renderer</returns>
-        public static Task<Renderer> CreateAsync(BrowserFetcher browserFetcher)
+        /// <param name="browserFetcher"></param>
+        /// <param name="launchOptions">Adds launch options to chromium</param>
+        /// <returns></returns>
+        public static Task<Renderer> CreateAsync(BrowserFetcher browserFetcher, string? launchOptions = null)
         {
-            var html2Pdf = new Renderer();
+            var html2Pdf = new Renderer(launchOptions);
             return html2Pdf.InitializeAsync(browserFetcher);
         }
 
         private async Task<Renderer> InitializeAsync(BrowserFetcher browserFetcher)
         {
-            BrowserFetcher = browserFetcher ?? throw new ArgumentNullException(nameof(browserFetcher));
+            BrowserFetcher = browserFetcher;
             BrowserFetcher.DownloadProgressChanged += DownloadProgressChanged;
 
-            await BrowserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision);
-            Browser = await Puppeteer.LaunchAsync(SystemSpecificConfig());
+            _ = await BrowserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision ?? string.Empty).ConfigureAwait(false);
+            Browser = await Puppeteer.LaunchAsync(SystemSpecificConfig()).ConfigureAwait(false);
             return this;
         }
 
-        private static LaunchOptions SystemSpecificConfig()
+        private LaunchOptions SystemSpecificConfig()
         {
-            if (IsRunningOnWsl())
+            if (!string.IsNullOrEmpty(LaunchOptions) && (IsRunningOnWsl() || IsRunningOnAzureLinux()))
             {
                 return new LaunchOptions { Headless = true, Args = new string[] { "--no-sandbox" } };
             }
 
             return new LaunchOptions { Headless = true };
         }
 
+        private static bool IsRunningOnAzureLinux()
+        {
+            return RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && Environment.GetEnvironmentVariable("WEBSITE_SKU").Contains("Linux");
+        }
+
         private static bool IsRunningOnWsl()
         {
             return RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && File.ReadAllText("/proc/version").Contains("Microsoft");
@@ -78,7 +96,7 @@ public async Task ConvertHtmlToPdf(string sourceHtmlFilePath, string destination
             }
 
             var absolutePath = Path.GetFullPath(sourceHtmlFilePath);
-            await using var page = await Browser.NewPageAsync().ConfigureAwait(false);
+            await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));
             await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);
             await page.PdfAsync(destinationPdfFilePath).ConfigureAwait(false);
         }
@@ -96,7 +114,7 @@ public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destination
             }
 
             var absolutePath = Path.GetFullPath(sourceHtmlFilePath);
-            await using var page = await Browser.NewPageAsync().ConfigureAwait(false);
+            await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));
             await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);
             await page.ScreenshotAsync(destinationPngFilePath, new ScreenshotOptions { FullPage = true }).ConfigureAwait(false);
         }
@@ -123,7 +141,7 @@ public void Dispose()
         /// </summary>
         public async ValueTask DisposeAsync()
         {
-            await DisposeAsyncCore();
+            await DisposeAsyncCore().ConfigureAwait(false);
 
             Dispose(disposing: false);
 #pragma warning disable CA1816 // Dispose methods should call SuppressFinalize
@@ -150,8 +168,8 @@ protected virtual async ValueTask DisposeAsyncCore()
         {
             if (Browser is not null)
             {
-                await Browser.CloseAsync();
-                await Browser.DisposeAsync();
+                await Browser.CloseAsync().ConfigureAwait(false);
+                await Browser.DisposeAsync().ConfigureAwait(false);
             }
         }
     }
diff --git a/Codeuctivity.HtmlRendererCli/Program.cs b/Codeuctivity.HtmlRendererCli/Program.cs
@@ -40,7 +40,7 @@ public static async Task<int> Main(string[] args)
             var browserFetcher = new BrowserFetcher();
             Console.WriteLine($"Fetching chromium from web, to {browserFetcher.DownloadsFolder} .... ");
             browserFetcher.DownloadProgressChanged += BrowserFetcher_DownloadProgressChanged;
-            await using var chromiumRenderer = await Renderer.CreateAsync(browserFetcher);
+            await using var chromiumRenderer = await Renderer.CreateAsync(browserFetcher, string.Empty);
             await chromiumRenderer.ConvertHtmlToPdf(inputPathDocx, outputPathHtml);
             return 0;
         }
diff --git a/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj b/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj
@@ -7,13 +7,13 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.37.0.45539">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
diff --git a/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj b/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj
@@ -16,15 +16,15 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Codeuctivity.ImageSharpCompare" Version="2.0.25" />
-    <PackageReference Include="Codeuctivity.PdfjsSharp" Version="1.2.27" />
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.37.0.45539">
+    <PackageReference Include="Codeuctivity.ImageSharpCompare" Version="2.0.61" />
+    <PackageReference Include="Codeuctivity.PdfjsSharp" Version="1.2.47" />
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="8.40.0.48530">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,15 @@ namespace Codeuctivity.HtmlRenderer`
`12`	`12`	`/// </summary>`
`13`	`13`	`public class Renderer : IAsyncDisposable, IDisposable`
`14`	`14`	`{`
	`15`	`+ /// <summary>`
	`16`	`+ /// Ctor`
	`17`	`+ /// </summary>`
	`18`	`+ /// <param name="launchOptions"></param>`
	`19`	`+ public Renderer(string? launchOptions = null)`
	`20`	`+ {`
	`21`	`+ LaunchOptions = launchOptions;`
	`22`	`+ }`
	`23`	`+`
`15`	`24`	`private Browser Browser { get; set; } = default!;`
`16`	`25`	`private int LastProgressValue { get; set; }`
`17`	`26`
`@@ -20,6 +29,8 @@ public class Renderer : IAsyncDisposable, IDisposable`
`20`	`29`	`/// </summary>`
`21`	`30`	`public BrowserFetcher BrowserFetcher { get; private set; } = default!;`
`22`	`31`
	`32`	`+ private string? LaunchOptions { get; }`
	`33`	`+`
`23`	`34`	`/// <summary>`
`24`	`35`	`/// Call CreateAsync before using ConvertHtmlTo*`
`25`	`36`	`/// </summary>`
`@@ -31,35 +42,42 @@ public static Task<Renderer> CreateAsync()`
`31`	`42`	`}`
`32`	`43`
`33`	`44`	`/// <summary>`
`34`		`- /// Call CreateAsync before using ConvertHtmlTo*, accepts custom BrowserFetcher`
	`45`	`+ /// Call CreateAsync before using ConvertHtmlTo*, accepts custom BrowserFetcher and custom chromium launch options`
`35`	`46`	`/// </summary>`
`36`		`- /// <returns>Initialized renderer</returns>`
`37`		`- public static Task<Renderer> CreateAsync(BrowserFetcher browserFetcher)`
	`47`	`+ /// <param name="browserFetcher"></param>`
	`48`	`+ /// <param name="launchOptions">Adds launch options to chromium</param>`
	`49`	`+ /// <returns></returns>`
	`50`	`+ public static Task<Renderer> CreateAsync(BrowserFetcher browserFetcher, string? launchOptions = null)`
`38`	`51`	`{`
`39`		`- var html2Pdf = new Renderer();`
	`52`	`+ var html2Pdf = new Renderer(launchOptions);`
`40`	`53`	`return html2Pdf.InitializeAsync(browserFetcher);`
`41`	`54`	`}`
`42`	`55`
`43`	`56`	`private async Task<Renderer> InitializeAsync(BrowserFetcher browserFetcher)`
`44`	`57`	`{`
`45`		`- BrowserFetcher = browserFetcher ?? throw new ArgumentNullException(nameof(browserFetcher));`
	`58`	`+ BrowserFetcher = browserFetcher;`
`46`	`59`	`BrowserFetcher.DownloadProgressChanged += DownloadProgressChanged;`
`47`	`60`
`48`		`- await BrowserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision);`
`49`		`- Browser = await Puppeteer.LaunchAsync(SystemSpecificConfig());`
	`61`	`+ _ = await BrowserFetcher.DownloadAsync(BrowserFetcher.DefaultChromiumRevision ?? string.Empty).ConfigureAwait(false);`
	`62`	`+ Browser = await Puppeteer.LaunchAsync(SystemSpecificConfig()).ConfigureAwait(false);`
`50`	`63`	`return this;`
`51`	`64`	`}`
`52`	`65`
`53`		`- private static LaunchOptions SystemSpecificConfig()`
	`66`	`+ private LaunchOptions SystemSpecificConfig()`
`54`	`67`	`{`
`55`		`- if (IsRunningOnWsl())`
	`68`	`+ if (!string.IsNullOrEmpty(LaunchOptions) && (IsRunningOnWsl() \|\| IsRunningOnAzureLinux()))`
`56`	`69`	`{`
`57`	`70`	`return new LaunchOptions { Headless = true, Args = new string[] { "--no-sandbox" } };`
`58`	`71`	`}`
`59`	`72`
`60`	`73`	`return new LaunchOptions { Headless = true };`
`61`	`74`	`}`
`62`	`75`
	`76`	`+ private static bool IsRunningOnAzureLinux()`
	`77`	`+ {`
	`78`	`+ return RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && Environment.GetEnvironmentVariable("WEBSITE_SKU").Contains("Linux");`
	`79`	`+ }`
	`80`	`+`
`63`	`81`	`private static bool IsRunningOnWsl()`
`64`	`82`	`{`
`65`	`83`	`return RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && File.ReadAllText("/proc/version").Contains("Microsoft");`
`@@ -78,7 +96,7 @@ public async Task ConvertHtmlToPdf(string sourceHtmlFilePath, string destination`
`78`	`96`	`}`
`79`	`97`
`80`	`98`	`var absolutePath = Path.GetFullPath(sourceHtmlFilePath);`
`81`		`- await using var page = await Browser.NewPageAsync().ConfigureAwait(false);`
	`99`	`+ await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));`
`82`	`100`	`await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);`
`83`	`101`	`await page.PdfAsync(destinationPdfFilePath).ConfigureAwait(false);`
`84`	`102`	`}`
`@@ -96,7 +114,7 @@ public async Task ConvertHtmlToPng(string sourceHtmlFilePath, string destination`
`96`	`114`	`}`
`97`	`115`
`98`	`116`	`var absolutePath = Path.GetFullPath(sourceHtmlFilePath);`
`99`		`- await using var page = await Browser.NewPageAsync().ConfigureAwait(false);`
	`117`	`+ await using var page = (await Browser.NewPageAsync().ConfigureAwait(false));`
`100`	`118`	`await page.GoToAsync($"file://{absolutePath}").ConfigureAwait(false);`
`101`	`119`	`await page.ScreenshotAsync(destinationPngFilePath, new ScreenshotOptions { FullPage = true }).ConfigureAwait(false);`
`102`	`120`	`}`
`@@ -123,7 +141,7 @@ public void Dispose()`
`123`	`141`	`/// </summary>`
`124`	`142`	`public async ValueTask DisposeAsync()`
`125`	`143`	`{`
`126`		`- await DisposeAsyncCore();`
	`144`	`+ await DisposeAsyncCore().ConfigureAwait(false);`
`127`	`145`
`128`	`146`	`Dispose(disposing: false);`
`129`	`147`	`#pragma warning disable CA1816 // Dispose methods should call SuppressFinalize`
`@@ -150,8 +168,8 @@ protected virtual async ValueTask DisposeAsyncCore()`
`150`	`168`	`{`
`151`	`169`	`if (Browser is not null)`
`152`	`170`	`{`
`153`		`- await Browser.CloseAsync();`
`154`		`- await Browser.DisposeAsync();`
	`171`	`+ await Browser.CloseAsync().ConfigureAwait(false);`
	`172`	`+ await Browser.DisposeAsync().ConfigureAwait(false);`
`155`	`173`	`}`
`156`	`174`	`}`
`157`	`175`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public static async Task<int> Main(string[] args)`
`40`	`40`	`var browserFetcher = new BrowserFetcher();`
`41`	`41`	`Console.WriteLine($"Fetching chromium from web, to {browserFetcher.DownloadsFolder} .... ");`
`42`	`42`	`browserFetcher.DownloadProgressChanged += BrowserFetcher_DownloadProgressChanged;`
`43`		`- await using var chromiumRenderer = await Renderer.CreateAsync(browserFetcher);`
	`43`	`+ await using var chromiumRenderer = await Renderer.CreateAsync(browserFetcher, string.Empty);`
`44`	`44`	`await chromiumRenderer.ConvertHtmlToPdf(inputPathDocx, outputPathHtml);`
`45`	`45`	`return 0;`
`46`	`46`	`}`