Skip to content

Commit ed81d5b

Browse files
steseestesee
authored
Migrated to net8.0, dropped older targets
2 parents 4d51fef + bc0601d commit ed81d5b

File tree

10 files changed

+115
-137
lines changed

10 files changed

+115
-137
lines changed

‎.github/workflows/dotnet.yml‎

Lines changed: 29 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: .NET build and test
22
env:
3-
CURRENT_VERSION: 2.2.${{ github.run_number }}
3+
CURRENT_VERSION: 3.0.${{ github.run_number }}
44
LAST_COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
55

66
on:
@@ -18,22 +18,18 @@ jobs:
1818
- name: Setup .NET
1919
uses: actions/setup-dotnet@v3
2020
with:
21-
dotnet-version: 7.0.x
22-
- name: Setup .NET
23-
uses: actions/setup-dotnet@v3
24-
with:
25-
dotnet-version: 6.0.x
21+
dotnet-version: 8.0.x
2622
- uses: actions/[email protected]
2723
with:
28-
node-version: 18
24+
node-version: 20
2925
- name: Restore dependencies
3026
run: dotnet restore
3127
- name: Build
3228
run: dotnet build --configuration Release --no-restore
3329
- name: Publish FolderProfilePortable
34-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable
30+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfilePortable
3531
- name: Publish FolderProfileWindows
36-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows
32+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfileWindows
3733
- name: Test
3834
run: dotnet test --no-build --verbosity normal --configuration Release
3935
- name: Publish Unit Test Results
@@ -52,43 +48,35 @@ jobs:
5248
- name: Setup .NET
5349
uses: actions/setup-dotnet@v3
5450
with:
55-
dotnet-version: 7.0.x
56-
- name: Setup .NET
57-
uses: actions/setup-dotnet@v3
58-
with:
59-
dotnet-version: 6.0.x
51+
dotnet-version: 8.0.x
6052
- name: Restore dependencies
6153
run: dotnet restore
6254
- name: Build
6355
run: dotnet build --configuration Release --no-restore
6456
- name: Publish FolderProfilePortable
65-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable
57+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfilePortable
6658
- name: Publish FolderProfileWindows
67-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows
59+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfileWindows
6860
- name: Zip FolderProfilePortable
6961
uses: thedoctor0/zip-release@main
7062
with:
7163
type: 'zip'
72-
directory: ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable
64+
directory: ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfilePortable
7365
filename: 'Codeuctivity.HtmlRendererCli.Portable.zip'
7466
- name: NugetPush
7567
env:
7668
NUGET_TOKEN_EXISTS: ${{ secrets.NUGET_TOKEN }}
7769
if: env.NUGET_TOKEN_EXISTS != ''
7870
run: |
7971
dotnet nuget push ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TOKEN}} --source https://api.nuget.org/v3/index.json
80-
- uses: "marvinpinto/action-automatic-releases@latest"
81-
with:
82-
repo_token: "${{ secrets.GITHUB_TOKEN }}"
83-
automatic_release_tag: ${{ env.CURRENT_VERSION }}
84-
prerelease: false
85-
title: "Release Build"
86-
files: |
87-
./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg
88-
./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg
89-
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip
90-
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe
91-
72+
- name: Github Release
73+
shell: bash
74+
env:
75+
GITHUB_TOKEN: ${{ github.TOKEN }}
76+
if: env.GITHUB_TOKEN != ''
77+
run: |
78+
gh release create ${{env.CURRENT_VERSION}} ./Codeuctivity.HtmlRenderer/bin/Release/*.*nupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe --generate-notes
79+
9280
deployTest:
9381
if: github.ref == 'refs/heads/main'
9482
runs-on: ubuntu-latest
@@ -98,24 +86,20 @@ jobs:
9886
- name: Setup .NET
9987
uses: actions/setup-dotnet@v3
10088
with:
101-
dotnet-version: 7.0.x
102-
- name: Setup .NET
103-
uses: actions/setup-dotnet@v3
104-
with:
105-
dotnet-version: 6.0.x
89+
dotnet-version: 8.0.x
10690
- name: Restore dependencies
10791
run: dotnet restore
10892
- name: Build
10993
run: dotnet build --configuration Release --no-restore
11094
- name: Publish FolderProfilePortable
111-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable
95+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfilePortable
11296
- name: Publish FolderProfileWindows
113-
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows
97+
run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net8.0 -p:PublishProfile=FolderProfileWindows
11498
- name: Zip FolderProfilePortable
11599
uses: thedoctor0/zip-release@main
116100
with:
117101
type: 'zip'
118-
directory: ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable
102+
directory: ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfilePortable
119103
filename: 'Codeuctivity.HtmlRendererCli.Portable.zip'
120104
- name: NugetPush
121105
env:
@@ -124,14 +108,11 @@ jobs:
124108
run: |
125109
ls ./Codeuctivity.HtmlRenderer/bin/Release
126110
dotnet nuget push ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TEST_TOKEN}} --source https://apiint.nugettest.org/v3/index.json
127-
- uses: "marvinpinto/action-automatic-releases@latest"
128-
with:
129-
repo_token: "${{ secrets.GITHUB_TOKEN }}"
130-
automatic_release_tag: "latest-prerelease"
131-
prerelease: true
132-
title: "Prerelease Build"
133-
files: |
134-
./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg
135-
./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg
136-
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip
137-
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe
111+
112+
- name: Github Prerelease
113+
shell: bash
114+
env:
115+
GITHUB_TOKEN: ${{ github.TOKEN }}
116+
if: env.GITHUB_TOKEN != ''
117+
run: |
118+
gh release create ${{env.CURRENT_VERSION}} ./Codeuctivity.HtmlRenderer/bin/Release/*.*nupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip ./Codeuctivity.HtmlRendererCli/bin/Release/net8.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe --prerelease --generate-notes

‎Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj‎

Lines changed: 47 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,51 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<PropertyGroup>
4-
<TargetFrameworks>netstandard2.0;net7.0;net6.0</TargetFrameworks>
5-
<GenerateDocumentationFile>true</GenerateDocumentationFile>
6-
<RepositoryUrl>https://github.com/Codeuctivity/PuppeteerSharp.Renderer</RepositoryUrl>
7-
<PackageTags>HtmlToPdf HtmlToPng HTML render convert PDF PNG PuppeteerSharp HTML2PDF HTML2PNG linux windows</PackageTags>
8-
<Authors>Stefan Seeland</Authors>
9-
<Company>Codeuctivity</Company>
10-
<Version Condition="'$(CURRENT_VERSION)' != ''">$(CURRENT_VERSION)</Version>
11-
<Version Condition="'$(CURRENT_VERSION)' == ''">0.0.1</Version>
12-
<AssemblyVersion>$(Version)</AssemblyVersion>
13-
<FileVersion>$(Version)</FileVersion>
14-
<PackageVersion>$(Version)</PackageVersion>
15-
<PackageReleaseNotes>$(LAST_COMMIT_MESSAGE)</PackageReleaseNotes>
16-
<PackageIcon>NugetIcon.png</PackageIcon>
17-
<PackageProjectUrl>https://github.com/Codeuctivity/PuppeteerSharp.Renderer</PackageProjectUrl>
18-
<Description>Renders HTML to PNG or PDF, supports windows and linux</Description>
19-
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
20-
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
21-
<SignAssembly>True</SignAssembly>
22-
<Optimize Condition="'$(GITHUB_ACTIONS)' == 'true'">true</Optimize>
23-
<IncludeSymbols>true</IncludeSymbols>
24-
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
25-
<PublishRepositoryUrl>true</PublishRepositoryUrl>
26-
<EmbedUntrackedSources>true</EmbedUntrackedSources>
27-
<LangVersion>9.0</LangVersion>
28-
<Nullable>enable</Nullable>
29-
<PackageId>Codeuctivity.HtmlRenderer</PackageId>
30-
<Product>Codeuctivity.HtmlRenderer</Product>
31-
<AssemblyName>Codeuctivity.HtmlRenderer</AssemblyName>
32-
<RootNamespace>Codeuctivity.HtmlRenderer</RootNamespace>
33-
<EnableNETAnalyzers>true</EnableNETAnalyzers>
34-
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
35-
<AnalysisLevel>latest</AnalysisLevel>
36-
<ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
37-
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
38-
<AssemblyOriginatorKeyFile>Codeuctivity.HtmlRenderer.snk</AssemblyOriginatorKeyFile>
39-
<IsTrimmable>true</IsTrimmable>
40-
</PropertyGroup>
3+
<PropertyGroup>
4+
<TargetFrameworks>net8.0</TargetFrameworks>
5+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
6+
<RepositoryUrl>https://github.com/Codeuctivity/PuppeteerSharp.Renderer</RepositoryUrl>
7+
<PackageTags>HtmlToPdf HtmlToPng HTML render convert PDF PNG PuppeteerSharp HTML2PDF HTML2PNG linux windows</PackageTags>
8+
<Authors>Stefan Seeland</Authors>
9+
<Company>Codeuctivity</Company>
10+
<Version Condition="'$(CURRENT_VERSION)' != ''">$(CURRENT_VERSION)</Version>
11+
<Version Condition="'$(CURRENT_VERSION)' == ''">0.0.1</Version>
12+
<AssemblyVersion>$(Version)</AssemblyVersion>
13+
<FileVersion>$(Version)</FileVersion>
14+
<PackageVersion>$(Version)</PackageVersion>
15+
<PackageReleaseNotes>$(LAST_COMMIT_MESSAGE)</PackageReleaseNotes>
16+
<PackageIcon>NugetIcon.png</PackageIcon>
17+
<PackageProjectUrl>https://github.com/Codeuctivity/PuppeteerSharp.Renderer</PackageProjectUrl>
18+
<Description>Renders HTML to PNG or PDF, supports windows and linux</Description>
19+
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
20+
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
21+
<SignAssembly>True</SignAssembly>
22+
<Optimize Condition="'$(GITHUB_ACTIONS)' == 'true'">true</Optimize>
23+
<IncludeSymbols>true</IncludeSymbols>
24+
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
25+
<PublishRepositoryUrl>true</PublishRepositoryUrl>
26+
<EmbedUntrackedSources>true</EmbedUntrackedSources>
27+
<Nullable>enable</Nullable>
28+
<PackageId>Codeuctivity.HtmlRenderer</PackageId>
29+
<Product>Codeuctivity.HtmlRenderer</Product>
30+
<AssemblyName>Codeuctivity.HtmlRenderer</AssemblyName>
31+
<RootNamespace>Codeuctivity.HtmlRenderer</RootNamespace>
32+
<EnableNETAnalyzers>true</EnableNETAnalyzers>
33+
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
34+
<AnalysisLevel>latest</AnalysisLevel>
35+
<ContinuousIntegrationBuild Condition="'$(GITHUB_ACTIONS)' == 'true'">true</ContinuousIntegrationBuild>
36+
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
37+
<AssemblyOriginatorKeyFile>Codeuctivity.HtmlRenderer.snk</AssemblyOriginatorKeyFile>
38+
</PropertyGroup>
4139

42-
<ItemGroup>
43-
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
44-
<PackageReference Include="PuppeteerSharp" Version="12.0.0" />
45-
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.8.0.76515">
46-
<PrivateAssets>all</PrivateAssets>
47-
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
48-
</PackageReference>
49-
</ItemGroup>
50-
<ItemGroup>
51-
<None Include="NugetIcon.png" Pack="true" PackagePath="\" />
52-
</ItemGroup>
40+
<ItemGroup>
41+
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
42+
<PackageReference Include="PuppeteerSharp" Version="12.0.0" />
43+
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.12.0.78982">
44+
<PrivateAssets>all</PrivateAssets>
45+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
46+
</PackageReference>
47+
</ItemGroup>
48+
<ItemGroup>
49+
<None Include="NugetIcon.png" Pack="true" PackagePath="\" />
50+
</ItemGroup>
5351
</Project>

‎Codeuctivity.HtmlRenderer/Renderer.cs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using PuppeteerSharp;
22
using System;
3+
using System.Diagnostics.CodeAnalysis;
34
using System.IO;
45
using System.Net;
56
using System.Runtime.InteropServices;
@@ -10,6 +11,7 @@ namespace Codeuctivity.HtmlRenderer
1011
/// <summary>
1112
/// Renders HTML files
1213
/// </summary>
14+
[RequiresUnreferencedCode("This functionality is not compatible with trimming. Use 'MethodFriendlyToTrimming' instead")]
1315
public class Renderer : IAsyncDisposable, IDisposable
1416
{
1517
/// <summary>

‎Codeuctivity.HtmlRendererCli/Codeuctivity.HtmlRendererCli.csproj‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFrameworks>net6.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0</TargetFrameworks>
66
<EnableNETAnalyzers>true</EnableNETAnalyzers>
77
<AnalysisMode>AllEnabledByDefault</AnalysisMode>
88
<AnalysisLevel>latest</AnalysisLevel>
99
<RootNamespace>Codeuctivity.HtmlRendererCli</RootNamespace>
1010
<DebugSymbols>true</DebugSymbols>
1111
<DebugType>embedded</DebugType>
12+
<TrimMode>partial</TrimMode>
1213
</PropertyGroup>
1314

14-
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
15-
<GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies>
16-
</PropertyGroup>
1715

1816
<ItemGroup>
1917
<ProjectReference Include="..\Codeuctivity.HtmlRenderer\Codeuctivity.HtmlRenderer.csproj" />

‎Codeuctivity.HtmlRendererCli/Program.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ public static async Task<int> Main(string[] args)
4040
using var browserFetcher = new BrowserFetcher();
4141
Console.WriteLine($"Fetching chromium from web, to {browserFetcher.CacheDir} .... ");
4242
browserFetcher.DownloadProgressChanged += BrowserFetcher_DownloadProgressChanged;
43-
await using var chromiumRenderer = await Renderer.CreateAsync(browserFetcher);
44-
await chromiumRenderer.ConvertHtmlToPdf(inputPathDocX, outputPathHtml);
43+
using var renderer = await Renderer.CreateAsync(browserFetcher).ConfigureAwait(false);
44+
await renderer.ConvertHtmlToPdf(inputPathDocX, outputPathHtml).ConfigureAwait(false);
4545
return 0;
4646
}
4747

‎Codeuctivity.HtmlRendererCli/Properties/PublishProfiles/FolderProfilePortable.pubxml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
https://go.microsoft.com/fwlink/?LinkID=208121.
44
-->
55
<Project>
6-
<PropertyGroup>
7-
<Configuration>Release</Configuration>
8-
<Platform>Any CPU</Platform>
9-
<PublishDir>bin\Release\net6.0\publish\FolderProfilePortable</PublishDir>
10-
<PublishProtocol>FileSystem</PublishProtocol>
11-
<_TargetId>Folder</_TargetId>
12-
<TargetFramework>net6.0</TargetFramework>
13-
<SelfContained>false</SelfContained>
14-
</PropertyGroup>
6+
<PropertyGroup>
7+
<Configuration>Release</Configuration>
8+
<Platform>Any CPU</Platform>
9+
<PublishDir>bin\Release\net8.0\publish\FolderProfilePortable</PublishDir>
10+
<PublishProtocol>FileSystem</PublishProtocol>
11+
<_TargetId>Folder</_TargetId>
12+
<TargetFramework>net8.0</TargetFramework>
13+
<SelfContained>false</SelfContained>
14+
</PropertyGroup>
1515
</Project>

‎Codeuctivity.HtmlRendererCli/Properties/PublishProfiles/FolderProfileWindows.pubxml‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<!--
3-
https://go.microsoft.com/fwlink/?LinkID=208121.
3+
https://go.microsoft.com/fwlink/?LinkID=208121.
44
-->
55
<Project>
66
<PropertyGroup>
7-
<Configuration>Release</Configuration>
8-
<Platform>Any CPU</Platform>
9-
<PublishDir>bin\Release\net6.0\publish\FolderProfileWindows\</PublishDir>
10-
<PublishProtocol>FileSystem</PublishProtocol>
11-
<TargetFramework>net6.0</TargetFramework>
12-
<SelfContained>true</SelfContained>
13-
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
14-
<PublishSingleFile>true</PublishSingleFile>
15-
<PublishReadyToRun>false</PublishReadyToRun>
16-
<PublishTrimmed>true</PublishTrimmed>
7+
<Configuration>Release</Configuration>
8+
<Platform>Any CPU</Platform>
9+
<PublishDir>bin\Release\net8.0\publish\FolderProfileWindows\</PublishDir>
10+
<PublishProtocol>FileSystem</PublishProtocol>
11+
<TargetFramework>net8.0</TargetFramework>
12+
<SelfContained>true</SelfContained>
13+
<RuntimeIdentifier>win-x86</RuntimeIdentifier>
14+
<PublishSingleFile>true</PublishSingleFile>
15+
<PublishReadyToRun>false</PublishReadyToRun>
16+
<PublishTrimmed>true</PublishTrimmed>
1717
</PropertyGroup>
1818
</Project>

‎Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>net7.0;net6.0</TargetFrameworks>
4+
<TargetFrameworks>net8.0</TargetFrameworks>
55
<IsPackable>false</IsPackable>
66
<EnableNETAnalyzers>true</EnableNETAnalyzers>
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
11-
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.8.0.76515">
10+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
11+
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.12.0.78982">
1212
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1313
<PrivateAssets>all</PrivateAssets>
1414
</PackageReference>
15-
<PackageReference Include="xunit" Version="2.5.0" />
16-
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.0">
15+
<PackageReference Include="xunit" Version="2.6.1" />
16+
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
1717
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1818
<PrivateAssets>all</PrivateAssets>
1919
</PackageReference>

‎Codeuctivity.HtmlRendererCliTests/RendererCliTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void PublishedSelfContainedBinaryShouldWork()
7474
private static string DotnetPublishFolderProfileWindows(string projectName)
7575
{
7676
var absolutePath = Path.GetFullPath("../../../../" + projectName);
77-
var expectedBinaryPath = Path.Combine(absolutePath, $"bin/Release/net6.0/publish/FolderProfileWindows/{projectName}.exe");
77+
var expectedBinaryPath = Path.Combine(absolutePath, $"bin/Release/net8.0/publish/FolderProfileWindows/{projectName}.exe");
7878

7979
if (File.Exists(expectedBinaryPath))
8080
{
@@ -86,7 +86,7 @@ private static string DotnetPublishFolderProfileWindows(string projectName)
8686
StartInfo = new ProcessStartInfo
8787
{
8888
FileName = "dotnet",
89-
Arguments = $"publish {absolutePath} --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows",
89+
Arguments = $"publish {absolutePath} --configuration Release -f net8.0 -p:PublishProfile=FolderProfileWindows",
9090
RedirectStandardOutput = true,
9191
RedirectStandardError = true,
9292
UseShellExecute = false,

0 commit comments

Comments
 (0)