initialize audios setting cache at cog startup to reduce config calls

Author: Drapersniper

redbot/cogs/audio/core/commands/audioset.py

@@ -600,9 +600,7 @@ async def command_audioset_historical_queue(self, ctx: commands.Context):
 
         Daily queues creates a playlist for all tracks played today.
         """
-        daily_playlists = self._daily_playlist_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).daily_playlists()
-        )
+        daily_playlists = self._daily_playlist_cache.get(ctx.guild.id)
         await self.config.guild(ctx.guild).daily_playlists.set(not daily_playlists)
         self._daily_playlist_cache[ctx.guild.id] = not daily_playlists
         await self.send_embed_msg(
@@ -644,9 +642,7 @@ async def command_audioset_dj(self, ctx: commands.Context):
 
         DJ mode allows users with the DJ role to use audio commands.
         """
-        dj_role = self._dj_role_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_role()
-        )
+        dj_role = self._dj_role_cache.get(ctx.guild.id)
         dj_role = ctx.guild.get_role(dj_role)
         if dj_role is None:
             await self.send_embed_msg(
@@ -665,9 +661,7 @@ async def command_audioset_dj(self, ctx: commands.Context):
                 return await self.send_embed_msg(
                     ctx, title=_("Response timed out, try again later.")
                 )
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         await self.config.guild(ctx.guild).dj_enabled.set(not dj_enabled)
         self._dj_status_cache[ctx.guild.id] = not dj_enabled
         await self.send_embed_msg(
@@ -943,9 +937,7 @@ async def command_audioset_role(self, ctx: commands.Context, *, role_name: disco
         """Set the role to use for DJ mode."""
         await self.config.guild(ctx.guild).dj_role.set(role_name.id)
         self._dj_role_cache[ctx.guild.id] = role_name.id
-        dj_role = self._dj_role_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_role()
-        )
+        dj_role = self._dj_role_cache.get(ctx.guild.id)
         dj_role_obj = ctx.guild.get_role(dj_role)
         await self.send_embed_msg(
             ctx,
@@ -1440,9 +1432,7 @@ async def command_audioset_persist_queue(self, ctx: commands.Context):
 
         Persistent queues allows the current queue to be restored when the queue closes.
         """
-        persist_cache = self._persist_queue_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).persist_queue()
-        )
+        persist_cache = self._persist_queue_cache.get(ctx.guild.id)
         await self.config.guild(ctx.guild).persist_queue.set(not persist_cache)
         self._persist_queue_cache[ctx.guild.id] = not persist_cache
         await self.send_embed_msg(

redbot/cogs/audio/core/commands/controller.py

@@ -33,9 +33,7 @@ async def command_disconnect(self, ctx: commands.Context):
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
         else:
-            dj_enabled = self._dj_status_cache.setdefault(
-                ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-            )
+            dj_enabled = self._dj_status_cache.get(ctx.guild.id)
             vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
             player = lavalink.get_player(ctx.guild.id)
             can_skip = await self._can_instaskip(ctx, ctx.author)
@@ -146,9 +144,7 @@ async def command_now(self, ctx: commands.Context):
 
         player.store("np_message", message)
 
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         if (
             (dj_enabled or vote_enabled)
@@ -198,9 +194,7 @@ async def command_now(self, ctx: commands.Context):
     @commands.bot_has_permissions(embed_links=True)
     async def command_pause(self, ctx: commands.Context):
         """Pause or resume a playing track."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
         player = lavalink.get_player(ctx.guild.id)
@@ -242,9 +236,7 @@ async def command_prev(self, ctx: commands.Context):
         """Skip to the start of the previously played track."""
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         is_alone = await self.is_requester_alone(ctx)
         is_requester = await self.is_requester(ctx, ctx.author)
@@ -306,9 +298,7 @@ async def command_seek(self, ctx: commands.Context, seconds: Union[int, str]):
 
         Accepts seconds or a value formatted like 00:00:00 (`hh:mm:ss`) or 00:00 (`mm:ss`).
         """
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         is_alone = await self.is_requester_alone(ctx)
         is_requester = await self.is_requester(ctx, ctx.author)
@@ -389,9 +379,7 @@ async def command_seek(self, ctx: commands.Context, seconds: Union[int, str]):
     async def command_shuffle(self, ctx: commands.Context):
         """Toggle shuffle."""
         if ctx.invoked_subcommand is None:
-            dj_enabled = self._dj_status_cache.setdefault(
-                ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-            )
+            dj_enabled = self._dj_status_cache.get(ctx.guild.id)
             can_skip = await self._can_instaskip(ctx, ctx.author)
             if dj_enabled and not can_skip:
                 return await self.send_embed_msg(
@@ -433,9 +421,7 @@ async def command_shuffle_bumpped(self, ctx: commands.Context):
         Set this to disabled if you wish to avoid bumped songs being shuffled. This takes priority
         over `[p]shuffle`.
         """
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         can_skip = await self._can_instaskip(ctx, ctx.author)
         if dj_enabled and not can_skip:
             return await self.send_embed_msg(
@@ -485,9 +471,7 @@ async def command_skip(self, ctx: commands.Context, skip_to_track: int = None):
             )
         if not player.current:
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         is_alone = await self.is_requester_alone(ctx)
         is_requester = await self.is_requester(ctx, ctx.author)
@@ -563,9 +547,7 @@ async def command_skip(self, ctx: commands.Context, skip_to_track: int = None):
     @commands.bot_has_permissions(embed_links=True)
     async def command_stop(self, ctx: commands.Context):
         """Stop playback and clear the queue."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
@@ -619,9 +601,7 @@ async def command_stop(self, ctx: commands.Context):
     @commands.bot_has_permissions(embed_links=True)
     async def command_summon(self, ctx: commands.Context):
         """Summon the bot to a voice channel."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         vote_enabled = await self.config.guild(ctx.guild).vote_enabled()
         is_alone = await self.is_requester_alone(ctx)
         is_requester = await self.is_requester(ctx, ctx.author)
@@ -697,9 +677,7 @@ async def command_summon(self, ctx: commands.Context):
     @commands.bot_has_permissions(embed_links=True)
     async def command_volume(self, ctx: commands.Context, vol: int = None):
         """Set the volume, 1% - 150%."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         can_skip = await self._can_instaskip(ctx, ctx.author)
         max_volume = await self.config.guild(ctx.guild).max_volume()
 
@@ -744,9 +722,7 @@ async def command_volume(self, ctx: commands.Context, vol: int = None):
     @commands.bot_has_permissions(embed_links=True)
     async def command_repeat(self, ctx: commands.Context):
         """Toggle repeat."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         can_skip = await self._can_instaskip(ctx, ctx.author)
         if dj_enabled and not can_skip and not await self._has_dj_role(ctx, ctx.author):
             return await self.send_embed_msg(
@@ -788,9 +764,7 @@ async def command_repeat(self, ctx: commands.Context):
     @commands.bot_has_permissions(embed_links=True)
     async def command_remove(self, ctx: commands.Context, index_or_url: Union[int, str]):
         """Remove a specific track number from the queue."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
         player = lavalink.get_player(ctx.guild.id)
@@ -865,9 +839,7 @@ async def command_remove(self, ctx: commands.Context, index_or_url: Union[int, s
     @commands.bot_has_permissions(embed_links=True)
     async def command_bump(self, ctx: commands.Context, index: int):
         """Bump a track number to the top of the queue."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
         player = lavalink.get_player(ctx.guild.id)

redbot/cogs/audio/core/commands/equalizer.py

@@ -37,9 +37,7 @@ async def command_equalizer(self, ctx: commands.Context):
         if not self._player_check(ctx):
             ctx.command.reset_cooldown(ctx)
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         player = lavalink.get_player(ctx.guild.id)
         eq = player.fetch("eq", Equalizer())
         reactions = [
@@ -163,9 +161,7 @@ async def command_equalizer_load(self, ctx: commands.Context, eq_preset: str):
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
 
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         player = lavalink.get_player(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             return await self.send_embed_msg(
@@ -192,9 +188,7 @@ async def command_equalizer_reset(self, ctx: commands.Context):
         """Reset the eq to 0 across all bands."""
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             return await self.send_embed_msg(
                 ctx,
@@ -226,9 +220,7 @@ async def command_equalizer_save(self, ctx: commands.Context, eq_preset: str = N
         """Save the current eq settings to a preset."""
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             ctx.command.reset_cooldown(ctx)
             return await self.send_embed_msg(
@@ -316,9 +308,7 @@ async def command_equalizer_set(
         if not self._player_check(ctx):
             return await self.send_embed_msg(ctx, title=_("Nothing playing."))
 
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             return await self.send_embed_msg(
                 ctx,

redbot/cogs/audio/core/commands/localtracks.py

@@ -110,7 +110,7 @@ async def _local_folder_menu(
             "\N{BLACK RIGHTWARDS ARROW}\N{VARIATION SELECTOR-16}": next_page,
         }
 
-        dj_enabled = await self.config.guild(ctx.guild).dj_enabled()
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             return await menu(ctx, folder_page_list, DEFAULT_CONTROLS)
         else:

redbot/cogs/audio/core/commands/player.py

@@ -919,9 +919,7 @@ async def _search_menu(
         else:
             tracks = query
 
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
 
         len_search_pages = math.ceil(len(tracks) / 5)
         search_page_list = []

redbot/cogs/audio/core/commands/playlists.py

@@ -1468,9 +1468,7 @@ async def command_playlist_start(
         if scope_data is None:
             scope_data = [None, ctx.author, ctx.guild, False]
         scope, author, guild, specified_user = scope_data
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if dj_enabled and not await self._can_instaskip(ctx, ctx.author):
             ctx.command.reset_cooldown(ctx)
             await self.send_embed_msg(

redbot/cogs/audio/core/commands/queue.py

@@ -181,9 +181,7 @@ async def command_queue_clear(self, ctx: commands.Context):
             player = lavalink.get_player(ctx.guild.id)
         except (NodeNotFound, PlayerNotFound):
             return await self.send_embed_msg(ctx, title=_("There's nothing in the queue."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if not self._player_check(ctx) or not player.queue:
             return await self.send_embed_msg(ctx, title=_("There's nothing in the queue."))
         if (
@@ -212,9 +210,7 @@ async def command_queue_clean(self, ctx: commands.Context):
             player = lavalink.get_player(ctx.guild.id)
         except (NodeNotFound, PlayerNotFound):
             return await self.send_embed_msg(ctx, title=_("There's nothing in the queue."))
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if not self._player_check(ctx) or not player.queue:
             return await self.send_embed_msg(ctx, title=_("There's nothing in the queue."))
         if (
@@ -309,9 +305,7 @@ async def command_queue_search(self, ctx: commands.Context, *, search_words: str
     @commands.cooldown(1, 30, commands.BucketType.guild)
     async def command_queue_shuffle(self, ctx: commands.Context):
         """Shuffles the queue."""
-        dj_enabled = self._dj_status_cache.setdefault(
-            ctx.guild.id, await self.config.guild(ctx.guild).dj_enabled()
-        )
+        dj_enabled = self._dj_status_cache.get(ctx.guild.id)
         if (
             dj_enabled
             and not await self._can_instaskip(ctx, ctx.author)

redbot/cogs/audio/core/events/cog.py

@@ -39,9 +39,7 @@ async def on_red_audio_track_start(
 
         track_identifier = track.track_identifier
         if self.playlist_api is not None:
-            daily_cache = self._daily_playlist_cache.setdefault(
-                guild.id, await self.config.guild(guild).daily_playlists()
-            )
+            daily_cache = self._daily_playlist_cache.get(guild.id)
             global_daily_playlists = self._daily_global_playlist_cache.setdefault(
                 self.bot.user.id, await self.config.daily_playlists()
             )
@@ -137,9 +135,7 @@ async def on_red_audio_track_start(
                 log.verbose(
                     "Failed to delete global daily playlist ID: %s", too_old_id, exc_info=exc
                 )
-        persist_cache = self._persist_queue_cache.setdefault(
-            guild.id, await self.config.guild(guild).persist_queue()
-        )
+        persist_cache = self._persist_queue_cache.get(guild.id)
         if persist_cache:
             await self.api_interface.persistent_queue_api.played(
                 guild_id=guild.id, track_id=track_identifier
@@ -165,9 +161,7 @@ async def on_red_audio_track_enqueue(
     ):
         if not (track and guild):
             return
-        persist_cache = self._persist_queue_cache.setdefault(
-            guild.id, await self.config.guild(guild).persist_queue()
-        )
+        persist_cache = self._persist_queue_cache.get(guild.id)
         if persist_cache:
             await self.api_interface.persistent_queue_api.enqueued(
                 guild_id=guild.id, room_id=track.extras["vc"], track=track