Skip to content

Commit 322a827

Browse files
build(medcat): Pin stuptools_scm to avoid wider sdist discovery. (#559)
It looks like setuptools_scm==10.1.2 (as opposed to 10.1.1) does a much wider discovery for sdist during project build. This reults in the build process attempting to use all sub-projects in the repo, which causes the build to fail. I don't fully understand what caused this change or why it was made here (in a patch version). But for now, the simplest solution would be to pin setuptools_scm to where it still worked. PS: I do intend to try and find another workaround for this. We don't want to be stuck using an old version of our build system. But I didn't see an obious way to do that without loosing other existing functionality (i.e setting root='.' in setuptools_scm config in pyproject.toml would probably cause that issue). PPS: The changelog for 10.1.1..10.1.2 for setuptools_scm is here: pypa/setuptools-scm@setuptools-scm-v10.1.1...setuptools-scm-v10.1.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent bd69eab commit 322a827

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

medcat-v2/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ test = [] # TODO - list
133133
[build-system]
134134
# These are the assumed default build requirements from pip:
135135
# https://pip.pypa.io/en/stable/reference/pip/#pep-517-and-518-support
136-
requires = ["setuptools>=43.0.0", "setuptools_scm>=8", "wheel"]
136+
requires = ["setuptools>=43.0.0", "setuptools_scm>=8,<10.1.2", "wheel"]
137137
build-backend = "setuptools.build_meta"
138138

139139
[tool.setuptools]

0 commit comments

Comments
 (0)