fixed: bulk update widget access in groups now show correct access opts

Author: jdalsem

classes/ColdTrick/WidgetManager/Access.php

@@ -17,31 +17,33 @@ class Access {
 	public static function setWriteAccess(\Elgg\Hook $hook) {
 
 		$input_params = $hook->getParam('input_params', []);
-		
-		$widget = elgg_extract('entity', $input_params);
-		if (!$widget instanceof \ElggWidget) {
+		if (elgg_extract('entity_type', $input_params) !== 'object' || elgg_extract('entity_subtype', $input_params) !== 'widget') {
 			return;
 		}
 
-		$result = $hook->getValue();
-		
-		$widget_context = $widget->context;
+		$container = get_entity(elgg_extract('container_guid', $input_params));
+		if (!$container instanceof \ElggEntity) {
+			return;
+		}
 
-		if ($widget_context === 'groups') {
-			$group = $widget->getContainerEntity();
-			if ($group instanceof \ElggGroup) {
-				$acl = $group->getOwnedAccessCollection('group_acl');
-				if ($acl) {
-					return [
-						$acl->id => elgg_echo('groups:access:group'),
-						ACCESS_LOGGED_IN => elgg_echo('access:label:logged_in'),
-						ACCESS_PUBLIC => elgg_echo('access:label:public')
-					];
-				}
+		if ($container instanceof \ElggGroup) {
+			$acl = $container->getOwnedAccessCollection('group_acl');
+			if ($acl) {
+				return [
+					$acl->id => elgg_echo('groups:access:group'),
+					ACCESS_LOGGED_IN => elgg_echo('access:label:logged_in'),
+					ACCESS_PUBLIC => elgg_echo('access:label:public')
+				];
 			}
-		} elseif ($widget->container_guid === elgg_get_site_entity()->guid) {
+		} elseif ($container instanceof \ElggSite) {
 			// sepcial options for index widgets
-			if (elgg_can_edit_widget_layout($widget_context)) {
+			
+			$widget = elgg_extract('entity', $input_params);
+			if (!$widget instanceof \ElggWidget) {
+				return;
+			}
+			
+			if (elgg_can_edit_widget_layout($widget->context)) {
 				return [
 					ACCESS_PRIVATE => elgg_echo('access:admin_only'),
 					ACCESS_LOGGED_IN => elgg_echo('access:label:logged_in'),

views/default/widget_manager/forms/groups_widget_access.php

@@ -25,7 +25,13 @@
 
 $form_body = '<div>' . elgg_echo('widget_manager:forms:groups_widget_access:description') . '</div>';
 
-$form_body .= '<div>' . elgg_view('input/access', ['name' => 'widget_access_level']) . '</div>';
+$form_body .= '<div>' . elgg_view('input/access', [
+	'name' => 'widget_access_level',
+	'entity_type' => 'object',
+	'entity_subtype' => 'widget',
+	'container_guid' => $group->guid,
+	'purpose' => 'groups_widget_access',
+]) . '</div>';
 
 $form_body .= '<div class="elgg-footer">';
 $form_body .= elgg_view('input/hidden', ['name' => 'group_guid', 'value' => $group->getGUID()]);