Previews on website

[idleberg]

Hi guys

I've recently submitted several themes to your wonderful site. Once published I noticed the previews look different from what I'm used to.

Example using HTML file, same happens with other file types

Right, I'm using Sublime Text 3, but when I created those color schemes, I tested them in ST2 as well.

As of Tuesday, I'll have access to my ST2 installation at work, if that helps testing. Let me know!

[GianlucaGuarini]

We use the ace tools to generate all the themes. I think some elements get colored with the fallback ( settings.foreground ) color of the theme wrongly because their scope is neither picked by our nodejs script.

Check on here the supported scopes: https://github.com/ajaxorg/ace/blob/master/tool/tmtheme.js#L16

I think this is an important feature we could add on our website. Thanks for discovering it

[sindresorhus]

Seeing this with my theme too:

Which looks like this in Sublime:

[GianlucaGuarini]

Hey guys hold on.. I am working on this but it's going to be a quite big update for our project, I want to be sure everything will work fine.

[GianlucaGuarini]

@idleberg Now your color scheme is displayed properly in the preview mode on our site http://colorsublime.com/?q=kimbie check yourself

@sindresorhus the focus theme seems to be not compatible with the ace themes import tool I think the issue is here the "string" property overrides the "string.quoted" screwing up the output

• here there is the list of the supported properties
• here the our css template rules used to import all the themes

[idleberg]

Great, thanks

[sindresorhus]

It's a valid tmTheme. I'm not really interested in changing anything just because some tools doesn't fully support tmTheme's. Feel free to remove my theme.

[GianlucaGuarini]

@sindresorhus I hope they could help us on this issue. In the meantime I would like to keep your theme on the site if it's not a problem for you

[sindresorhus]

Sure

[kenwheeler]

Same here

[GianlucaGuarini]

@kenwheeler The error was inside the Brogrammer.tmTheme file https://github.com/Colorsublime/Colorsublime-Themes/blob/master/themes/Brogrammer.tmTheme#L176 Our importer failed importing empty color properties. Now it's fixed.. thanks for the bug report

[kenwheeler]

Thanks @GianlucaGuarini