Skip to content

Commit 9cf61a4

Browse files
author
Robin Kluth
committed
fix(performance): Get groups via memberof intead of all users single DN...
1 parent c58a53b commit 9cf61a4

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

src/LdapAuth.php

+1-11
Original file line numberDiff line numberDiff line change
@@ -642,17 +642,7 @@ public function searchGroup(?string $searchFor, ?array $attributes = ['dn', 'mem
642642
if (!isset($group['member'])) {
643643
continue;
644644
}
645-
if (is_string($group['member'])) {
646-
$group['member'] = [$group['member']];
647-
}
648-
$groups[$gkey]['users'] = [];
649-
foreach ($group['member'] as $key => $member) {
650-
if ($key == 'count') {
651-
continue;
652-
}
653-
$groups[$gkey]['users'] = array_merge($groups[$gkey]['users'], $this->searchUser(null, ['dn'], '(&(objectCategory=person))', $group['domainKey'], false, false, $member));
654-
}
655-
645+
$groups[$gkey]['users'] = $this->searchUser(null, ['dn'], '(&(objectCategory=person)(memberof=' . $group['dn'] . '))', $group['domainKey']);
656646
}
657647

658648
return $groups;

0 commit comments

Comments
 (0)