Fix code style issues with clang_format

Author: lint-action

src/data/achievementsystem.h

@@ -21,16 +21,16 @@ enum class AchievementError {
 class Achievement {
  public:
   Achievement(std::string name, std::string description, bool hidden,
-              const Sprite &icon)
+              const Sprite& icon)
       : name(std::move(name)),
         description(std::move(description)),
         hidden(hidden),
         icon(icon) {}
 
-  std::string const &Name() const { return name; }
-  std::string const &Description() const { return description; }
+  std::string const& Name() const { return name; }
+  std::string const& Description() const { return description; }
   bool Hidden() const { return hidden; }
-  Sprite const &Icon() const { return icon; }
+  Sprite const& Icon() const { return icon; }
 
  protected:
   std::string name;
@@ -42,19 +42,19 @@ class Achievement {
 class AchievementSystemBase {
  public:
   virtual AchievementError MountAchievementFile(
-      std::function<void(void)> &mainThreadCallback) = 0;
+      std::function<void(void)>& mainThreadCallback) = 0;
   //  virtual bool UnlockAchievement(int id) = 0;
-  virtual const Achievement *GetAchievement(int id) = 0;
+  virtual const Achievement* GetAchievement(int id) = 0;
   virtual size_t GetAchievementCount() const = 0;
 };
 
-inline AchievementSystemBase *Implementation = nullptr;
+inline AchievementSystemBase* Implementation = nullptr;
 
 void Init();
 
 LoadStatus GetLoadStatus();
 void MountAchievementFile();
-const Achievement *GetAchievement(int id);
+const Achievement* GetAchievement(int id);
 size_t GetAchievementCount();
 
 }  // namespace AchievementSystem

src/games/cclcc/tipssystem.cpp

@@ -49,7 +49,7 @@ void TipsSystem::DataInit(uint32_t scriptBufferId, uint32_t tipsDataAdr,
 void TipsSystem::UpdateTipRecords() {
   if (TipEntryCount != 0) {
     for (size_t i = 0; i < TipEntryCount; i++) {
-      auto &record = Records[i];
+      auto& record = Records[i];
       auto tipStatus = SaveSystem::GetTipStatus(record.Id);
       record.IsLocked = (tipStatus & 1) == 0;
       record.IsUnread = (tipStatus & 2) == 0;

src/games/chlcc/albummenu.h

@@ -21,17 +21,17 @@ class AlbumMenu : public Menu, public CommonMenu {
   void Render() override;
 
  private:
-  std::vector<Widgets::Group *> Pages;
+  std::vector<Widgets::Group*> Pages;
 
   void DrawPage();
 
   void UpdatePages();
 
-  void CgOnClick(Widgets::Button *target);
-  void OnCgVariationEnd(Widgets::CgViewer *target);
+  void CgOnClick(Widgets::Button* target);
+  void OnCgVariationEnd(Widgets::CgViewer* target);
 
-  Widgets::Group *CgViewerGroup;
-  Widgets::CgViewer *CgViewerWidget;
+  Widgets::Group* CgViewerGroup;
+  Widgets::CgViewer* CgViewerWidget;
 
   int PrevPage = 0;
   int CurrentPage;

src/games/mo6tw/tipsmenu.cpp

@@ -26,8 +26,8 @@ using namespace Impacto::Vm::Interface;
 using namespace Impacto::UI::Widgets;
 using namespace Impacto::UI::Widgets::MO6TW;
 
-void TipsMenu::TipOnClick(Button *target) {
-  auto tipEntry = static_cast<TipsEntryButton *>(target);
+void TipsMenu::TipOnClick(Button* target) {
+  auto tipEntry = static_cast<TipsEntryButton*>(target);
   if (!tipEntry->TipEntryRecord->IsLocked) SwitchToTipId(target->Id);
 }
 
@@ -142,21 +142,21 @@ void TipsMenu::Render() {
 }
 
 void TipsMenu::Init() {
-  auto onClick = [this](auto *btn) { return TipOnClick(btn); };
+  auto onClick = [this](auto* btn) { return TipOnClick(btn); };
   int currentPage = 0, currentCategoryId = -1;
 
   // String of characters by which tips are sorted, taken from _system script
   auto [scriptBufId, sortStrAddr] =
       Vm::ScriptGetTextTableStrAddress(SortStringTable, SortStringIndex);
-  uint8_t *sortString = &Vm::ScriptBuffers[scriptBufId][sortStrAddr];
+  uint8_t* sortString = &Vm::ScriptBuffers[scriptBufId][sortStrAddr];
   auto recordCount = TipsSystem::GetTipCount();
 
   float currentY = TipListInitialY;
 
   ItemsList.Clear();
   TipViewItems.Clear();
 
-  Group *pageItems = new Group(this);
+  Group* pageItems = new Group(this);
   for (size_t i = 0; i < recordCount; i++) {
     auto record = TipsSystem::GetTipRecord(i);
 
@@ -181,11 +181,11 @@ void TipsMenu::Init() {
       CategoryString[1] = UnalignedRead<uint16_t>(
           &sortString[currentCategoryId * sizeof(uint16_t)]);
 
-      Label *categoryLabel = new Label();
+      Label* categoryLabel = new Label();
       categoryLabel->Bounds.X = TipListEntryBounds.X;
       categoryLabel->Bounds.Y = currentY;
       Vm::Sc3Stream categoryStrStream(
-          reinterpret_cast<uint8_t *>(CategoryString));
+          reinterpret_cast<uint8_t*>(CategoryString));
       categoryLabel->SetText(categoryStrStream, TipListEntryFontSize,
                              RendererOutlineMode::Full, 0);
       pageItems->Add(categoryLabel);
@@ -194,7 +194,7 @@ void TipsMenu::Init() {
 
     // Actual tip entry button
     TipListEntryBounds.Y = currentY;
-    TipsEntryButton *button =
+    TipsEntryButton* button =
         new TipsEntryButton(record->Id, record, TipListEntryBounds,
                             Profile::BacklogMenu::EntryHighlight);
     button->OnClickHandler = onClick;

src/games/mo6tw/tipssystem.cpp

@@ -23,7 +23,7 @@ void TipsSystem::DataInit(uint32_t scriptBufferId, uint32_t tipsDataAdr,
   int idx = 0;
 
   // Read tips data from the script and create UI elements for each tip
-  MemoryStream *stream =
+  MemoryStream* stream =
       new MemoryStream(&scriptBuffer[tipsDataAdr], tipsDataSize);
   auto unk01 = ReadLE<uint16_t>(stream);
   while (unk01 != 255) {

src/io/lzxstream.cpp

@@ -8,10 +8,10 @@ namespace Io {
 
 LzxStream::~LzxStream() { free(CompressedBuffer); }
 
-IoError LzxStream::Create(Stream *baseStream, int64_t offset, int64_t size,
-                          Stream **out) {
+IoError LzxStream::Create(Stream* baseStream, int64_t offset, int64_t size,
+                          Stream** out) {
   if (offset + size > baseStream->Meta.Size) return IoError_Fail;
-  Stream *dup;
+  Stream* dup;
   int64_t err = baseStream->Duplicate(&dup);
   if (err != IoError_OK) return (IoError)err;
   err = dup->Seek(offset, RW_SEEK_SET);
@@ -50,7 +50,7 @@ IoError LzxStream::Create(Stream *baseStream, int64_t offset, int64_t size,
     return IoError_Fail;
   }
 
-  LzxStream *result = new LzxStream(uncompressedBlockSize);
+  LzxStream* result = new LzxStream(uncompressedBlockSize);
   result->BaseStream = dup;
   result->CompressedOffset = compressedOffset;
   result->CompressedPosition = 0;
@@ -61,13 +61,13 @@ IoError LzxStream::Create(Stream *baseStream, int64_t offset, int64_t size,
 
   result->WindowSize = windowSize;
   result->CompressionPartitionSize = compressionPartitionSize;
-  result->CompressedBuffer = (uint8_t *)malloc(compressedBlockSize);
+  result->CompressedBuffer = (uint8_t*)malloc(compressedBlockSize);
   result->CompressedBufferSize = compressedBlockSize;
-  *out = (Stream *)result;
+  *out = (Stream*)result;
   return IoError_OK;
 }
 
-int64_t LzxStream::Read(void *buffer, int64_t sz) {
+int64_t LzxStream::Read(void* buffer, int64_t sz) {
   return ReadBuffered(buffer, sz);
 }
 
@@ -105,14 +105,14 @@ int64_t LzxStream::Seek(int64_t offset, int origin) {
   return Position;
 }
 
-IoError LzxStream::Duplicate(Stream **outStream) {
-  Stream *dup;
+IoError LzxStream::Duplicate(Stream** outStream) {
+  Stream* dup;
   int64_t err = BaseStream->Duplicate(&dup);
   if (err != IoError_OK) return (IoError)err;
-  LzxStream *result = new LzxStream(*this);
-  result->CompressedBuffer = (uint8_t *)malloc(CompressedBufferSize);
+  LzxStream* result = new LzxStream(*this);
+  result->CompressedBuffer = (uint8_t*)malloc(CompressedBufferSize);
   result->BaseStream = dup;
-  *outStream = (Stream *)result;
+  *outStream = (Stream*)result;
   return IoError_OK;
 }
 
@@ -149,7 +149,7 @@ IoError LzxStream::FillBuffer() {
 }
 
 struct LZXFile {
-  uint8_t *buf;
+  uint8_t* buf;
   int bufSize;
   int pos;
   int rest;
@@ -158,7 +158,7 @@ struct LZXFile {
 // Based on
 // https://github.com/gildor2/UEViewer/blob/master/Unreal/UnCoreCompression.cpp
 
-static int LZXread(struct LZXFile *file, void *buffer, int bytes) {
+static int LZXread(struct LZXFile* file, void* buffer, int bytes) {
   if (!file->rest) {
     // read block header
     if (file->buf[file->pos] == 0xFF) {
@@ -186,27 +186,27 @@ static int LZXread(struct LZXFile *file, void *buffer, int bytes) {
   return bytes;
 }
 
-static int LZXwrite(struct LZXFile *file, void *buffer, int bytes) {
+static int LZXwrite(struct LZXFile* file, void* buffer, int bytes) {
   memcpy(file->buf + file->pos, buffer, bytes);
   file->pos += bytes;
   return bytes;
 }
 
-static void *LZXalloc(struct mspack_system *self, size_t bytes) {
+static void* LZXalloc(struct mspack_system* self, size_t bytes) {
   return malloc(bytes);
 }
 
-static void LZXfree(void *ptr) { free(ptr); }
+static void LZXfree(void* ptr) { free(ptr); }
 
-static void LZXCopy(void *src, void *dst, size_t bytes) {
+static void LZXCopy(void* src, void* dst, size_t bytes) {
   memcpy(dst, src, bytes);
 }
 
 static struct mspack_system LZXSys = {
     NULL,  // open
     NULL,  // close
-    (auto (*)(mspack_file *, void *, int)->int)&LZXread,
-    (auto (*)(mspack_file *, void *, int)->int)&LZXwrite,
+    (auto (*)(mspack_file*, void*, int)->int)&LZXread,
+    (auto (*)(mspack_file*, void*, int)->int)&LZXwrite,
     NULL,  // seek
     NULL,  // tell
     NULL,  // message
@@ -215,8 +215,8 @@ static struct mspack_system LZXSys = {
     &LZXCopy,
     NULL};
 
-int32_t LZXDecompress(uint8_t *CompressedBuffer, int CompressedSize,
-                      uint8_t *UncompressedBuffer, int UncompressedSize,
+int32_t LZXDecompress(uint8_t* CompressedBuffer, int CompressedSize,
+                      uint8_t* UncompressedBuffer, int UncompressedSize,
                       int WindowSize, int CompressionPartitionSize) {
   // setup streams
   struct LZXFile src, dst;
@@ -234,9 +234,9 @@ int32_t LZXDecompress(uint8_t *CompressedBuffer, int CompressedSize,
   }
   if (WindowSize <= 0) WindowSize = 17;
   if (CompressionPartitionSize <= 0) CompressionPartitionSize = 256 * 1024;
-  struct lzxd_stream *lzxd =
-      lzxd_init(&LZXSys, (mspack_file *)&src, (mspack_file *)&dst, WindowSize,
-                0, CompressionPartitionSize, UncompressedSize, 0);
+  struct lzxd_stream* lzxd =
+      lzxd_init(&LZXSys, (mspack_file*)&src, (mspack_file*)&dst, WindowSize, 0,
+                CompressionPartitionSize, UncompressedSize, 0);
   // decompress
   int r = lzxd_decompress(lzxd, UncompressedSize);
   if (r != MSPACK_ERR_OK) return -1;

src/io/mpkarchive.h

@@ -10,12 +10,12 @@ struct MpkMetaEntry;
 class MpkArchive : public VfsArchive {
  public:
   ~MpkArchive();
-  IoError Open(FileMeta *file, Stream **outStream) override;
+  IoError Open(FileMeta* file, Stream** outStream) override;
 
-  static IoError Create(Stream *stream, VfsArchive **outArchive);
+  static IoError Create(Stream* stream, VfsArchive** outArchive);
 
  private:
-  MpkMetaEntry *TOC = 0;
+  MpkMetaEntry* TOC = 0;
 };
 
 }  // namespace Io

src/renderer/3d/scene.h

@@ -16,7 +16,7 @@ class IScene3D {
 
   Camera MainCamera;
 
-  IRenderable3D **Renderables;
+  IRenderable3D** Renderables;
 
   glm::vec3 LightPosition;
   glm::vec4 Tint;