Glovebox and Trunk saving issue

[tony-stark-17]

Describe the bug
There occurs a bug where when you place your items in the glovebox or the trunk and when the vehicle gets deleted and then when you check the inventory the items are lost. i.e. the previous items will be there but the new one's will be gone. The thing is it doesn't happen always

Framework
Should happen on All (Tested on QBOX )

Resource version
2.44.0

To Reproduce
Steps to reproduce the behavior:

1. Save items in glovebox
2. Delete vehicle
3. Take the vehicle
4. Items lost

Expected behavior
The items should be saved in the inventory.

Additional context

Upon debugging I found that on deleting the vehicle when the saveInventories functions (modules/inventory/server.lua) is called the Inventory.Remove() is being called as the vehicle netId doesn't match with 0. Since the entity got deleted. As a workaround I added a check whether ~=0 and not matching then remove. But not 100% confident about this workaround which is why didn't create a PR

[tony-stark-17]

Also there occur another issue where if your vehicle is despawned and then you take it again the entity id mismatch occurs and the inventory is removed.

[Maximus7474]

Is this issue still current ?

If yes please provide more details regarding the environment being that it seems like either an edge case or an issue with vehicle management.

• How are vehicle spawned (spawned via client or server natives) ?
• Is Orphan mode set on the vehicles ?
• Are the vehicles in question owned by a player (and hence listed in player_vehicles DB table) ?

[tony-stark-17]

The issue still exists. No matter how the vehicle is spawned as long as the entity id check exists the issue is there as the entity id is not persistent.

[Maximus7474]

I'm not sure why this would be the case on your end, I'd need to look deeper into it.
But at first glance it shouldn't occur, unless you have a ridiculously large interval for saving inventories, because it would cleanup vehicle inventories if the entityId changes, which has been in place for 2 years 9229068

[tony-stark-17]

Once the glovebox/trunk is loaded in the memory the saveInventories will consider it but before the save occurs if the vehicle is deleted then the netid doesn't exist which will trigger a mismatch

[Maximus7474]

I'm unable to reproduce or comprehend the root of the issue, the clean up of inventories wipes every 5 minutes vehicles who no longer exist or had the entityId updated, and in the case where you rapidly do the actions between the script will remove the inventory (saving it) before recreating it (handled in server.lua#L180-L187 ).

I can only think of something funky is happening with the vehicle plates on your server leading to these issues, making it extremely hard to debug with the provided information.

[Kxiox]

I'm unable to reproduce or comprehend the root of the issue, the clean up of inventories wipes every 5 minutes vehicles who no longer exist or had the entityId updated, and in the case where you rapidly do the actions between the script will remove the inventory (saving it) before recreating it (handled in server.lua#L180-L187 ).

I can only think of something funky is happening with the vehicle plates on your server leading to these issues, making it extremely hard to debug with the provided information.

Hey! I just wanted to let you know that we're having the same problem on our server. It's not just an issue with vehicles; it's also affecting stashes and all kinds of add-on inventory. Currently we use the version 2.44.6.

[Maximus7474]

Hey! I just wanted to let you know that we're having the same problem on our server. It's not just an issue with vehicles; it's also affecting stashes and all kinds of add-on inventory. Currently we use the version 2.44.6.

This doesn't help resolving the issue discussed by OP, there's no correlation established that your issue is tied to the same reason as his and there are no details provided to investigate it.

[Kxiox]

Hey! I just wanted to let you know that we're having the same problem on our server. It's not just an issue with vehicles; it's also affecting stashes and all kinds of add-on inventory. Currently we use the version 2.44.6.

This doesn't help resolving the issue discussed by OP, there's no correlation established that your issue is tied to the same reason as his and there are no details provided to investigate it.

Maybe you can tell me if there was bug changes in the react source code. We had make our own version of design and on each update we used the old web source code. All looks good and there is nothing that give any hint that this make any problems.

[Maximus7474]

Maybe you can tell me if there was bug changes in the react source code. We had make our own version of design and on each update we used the old web source code. All looks good and there is nothing that give any hint that this make any problems.

There haven't been any changes to the UI files in years, you can see that by the commit log. Please use a separate issue, because as I mentioned previously: "there's no correlation established that your issue is tied to the same reason as [the issue discussed in this issue]"