Skip to content

Commit c474035

Browse files
ComputerEliteComputerElite
authored andcommitted
Show errors on mod installation and disabling
1 parent 6f7858d commit c474035

File tree

5 files changed

+19
-10
lines changed

5 files changed

+19
-10
lines changed

QuestAppVersionSwitcher/Assets/html/script.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ function UpdateModsAndLibs() {
207207
var operations = ""
208208
for(const operation of res.operations){
209209
operations += `
210-
<div class="mod" style="padding: 10px">
210+
<div class="mod" style="padding: 10px; ${operation.type == 6 ? "color: #FF0000;" : ""}">
211211
${operation.name}
212212
</div>
213213
`

QuestAppVersionSwitcher/Mods/QAVSModManager.cs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ public static void InstallMod(string path, string fileName)
8989
{
9090
IMod mod = modManager.TryParseMod(path).Result;
9191
mod.Install().Wait();
92+
runningOperations.Remove(operationId);
9293
} catch (Exception e)
9394
{
9495
runningOperations.Remove(operationId);
9596
operationId = operations;
9697
operations++;
97-
runningOperations.Add(operationId, new QAVSOperation { type = QAVSOperationType.Error, name = "Error installing mod: " + e.Message + "\nTo remove this message restart QuestAppVersionSwitcher" });
98+
runningOperations.Add(operationId, new QAVSOperation { type = QAVSOperationType.Error, name = "Error installing mod: " + e.Message + "\n\nTo remove this message restart QuestAppVersionSwitcher" });
9899
}
99-
runningOperations.Remove(operationId);
100100
modManager.ForceSave();
101101
}
102102

@@ -146,12 +146,21 @@ public static void EnableMod(string id)
146146
{
147147
if (m.Id == id)
148148
{
149-
m.Install().Wait();
150-
modManager.ForceSave();
149+
try
150+
{
151+
m.Install().Wait();
152+
modManager.ForceSave();
153+
runningOperations.Remove(operationId);
154+
} catch(Exception e)
155+
{
156+
runningOperations.Remove(operationId);
157+
operationId = operations;
158+
operations++;
159+
runningOperations.Add(operationId, new QAVSOperation { type = QAVSOperationType.Error, name = "Error enabling mod: " + e.Message + "\n\nTo remove this message restart QuestAppVersionSwitcher" });
160+
}
151161
break;
152162
}
153163
}
154-
runningOperations.Remove(operationId);
155164
}
156165

157166
public static string GetMods()

QuestAppVersionSwitcher/Mods/QModProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public override async Task<IMod> LoadFromFile(string modPath)
6363
}
6464
if (existingInstall.Version > qmod.Version)
6565
{
66-
throw new InstallationException($"Version of existing {existingInstall.Id} ({existingInstall.Version}) is greater than installing version ({mod.Version}). Direct version downgrades are not permitted");
66+
throw new InstallationException($"Version of existing {existingInstall.Id} ({existingInstall.Version}) is greater than installing version ({mod.Version}). Direct version downgrades are not permitted. This may be fixed by deleting all mods and libraries.");
6767
}
6868
// Uninstall the existing mod. May throw an exception if other mods depend on the older version
6969
needImmediateInstall = await PrepareVersionChange(existingInstall, mod);

QuestAppVersionSwitcher/Properties/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionName="1.9.3" package="com.ComputerElite.questappversionswitcher" android:installLocation="preferExternal" android:versionCode="41">
2+
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionName="1.9.4" package="com.ComputerElite.questappversionswitcher" android:installLocation="preferExternal" android:versionCode="42">
33
<uses-sdk android:minSdkVersion="28" android:targetSdkVersion="29" />
44
<uses-permission android:name="oculus.permission.handtracking" />
55
<uses-permission android:name="com.oculus.permission.HAND_TRACKING" />

QuestAppVersionSwitcher/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@
2222
// Minor Version
2323
// Build Number
2424
// Revision
25-
[assembly: AssemblyVersion("1.9.3.0")]
26-
[assembly: AssemblyFileVersion("1.9.3.0")]
25+
[assembly: AssemblyVersion("1.9.4.0")]
26+
[assembly: AssemblyFileVersion("1.9.4.0")]

0 commit comments

Comments
 (0)