.github: Bump golangci/golangci-lint-action from 6 to 7 (#273)

* .github: Bump golangci/golangci-lint-action from 6 to 7

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6...v7)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Introduce tools module

- introduce tools module and remove tools.go
- update golangci-lint to v2.0.2
- update Makefile install-tools target
- fix any linter errors that cropped up
- update CI action to work with golangci-lint v2
- add dependabot rule for updating Go tools
- migrate .golangci.yml to v2

* go mod tidy

* upgrade Go to 1.24.2

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lovro Mažgon <[email protected]>

Author: dependabot[bot]

.github/dependabot.yml

@@ -17,3 +17,11 @@ updates:
       interval: "daily"
     commit-message:
       prefix: "go.mod:"
+
+  # Maintain dependencies for Go tools
+  - package-ecosystem: "gomod"
+    directory: "/tools"
+    schedule:
+      interval: "weekly"
+    commit-message:
+      prefix: "Go tools:"

.github/workflows/lint.yml

@@ -20,11 +20,10 @@ jobs:
       - name: Golangci-lint version
         id: golangci-lint-version
         run: |
-          GOLANGCI_LINT_VERSION=$( go list -m -f '{{.Version}}' github.com/golangci/golangci-lint )
+          GOLANGCI_LINT_VERSION=$( go list -modfile=tools/go.mod -m -f '{{.Version}}' github.com/golangci/golangci-lint/v2 )
           echo "v=$GOLANGCI_LINT_VERSION" >> "$GITHUB_OUTPUT"
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
           version: ${{ steps.golangci-lint-version.outputs.v }}
-          args: --timeout=2m

.golangci.yml

@@ -1,108 +1,83 @@
-linters-settings:
-  gofmt:
-    simplify: false
-  nolintlint:
-    allow-unused: false # report any unused nolint directives
-    require-explanation: true # require an explanation for nolint directives
-    require-specific: true # require nolint directives to mention the specific linter being suppressed
-  gocyclo:
-    min-complexity: 20
-  goconst:
-    ignore-tests: true
-  goheader:
-    template-path: '.golangci.goheader.template'
-    values:
-      regexp:
-        copyright-year: 20[2-9]\d
-  forbidigo:
-    forbid:
-      - p: ^pgxpool\.New.*$
-        msg: "Use github.com/conduitio/conduit-connector-postgres/source/cpool.New instead."
-issues:
-  exclude-rules:
-    - path: test/helper\.go
-      linters:
-        - gosec
-    - path: source/cpool/cpool\.go
-      linters:
-      - forbidigo
-
+version: "2"
 linters:
-  # please, do not use `enable-all`: it's deprecated and will be removed soon.
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
-  disable-all: true
+  default: none
   enable:
     - bodyclose
     - copyloopvar
-    # - depguard
     - dogsled
     - durationcheck
     - errcheck
     - errname
-    # - errorlint
-    # - exhaustive
-    # - exhaustivestruct
     - forbidigo
-    # - forcetypeassert
-    # - funlen
-    # - gochecknoinits
     - goconst
     - gocritic
     - gocyclo
-    # - cyclop # not interested in package complexities at the moment
-    # - godot
-    - gofmt
-    # - gofumpt
     - goheader
-    - goimports
-    - revive
-    # - gomnd
     - gomoddirectives
     - gomodguard
     - goprintffuncname
     - gosec
-    - gosimple
     - govet
-    # - ifshort
     - ineffassign
-    # - importas
-    # - lll
-    # - misspell
     - makezero
-    # - nakedret
-    # - nilerr
-    # - nilnil
-    # - nlreturn
     - noctx
     - nolintlint
-    # - paralleltest
     - predeclared
+    - revive
     - rowserrcheck
-    - staticcheck
-    - stylecheck
     - sqlclosecheck
-    # - tagliatelle
-    # - tenv
-    # - thelper
-    # - tparallel
-    - typecheck
+    - staticcheck
     - unconvert
-    # - unparam
     - unused
     - wastedassign
     - whitespace
-  # - wrapcheck
-  # - wsl
-
-  # don't enable:
-  # - asciicheck
-  # - dupl
-  # - gochecknoglobals
-  # - gocognit
-  # - godox
-  # - goerr113
-  # - maligned
-  # - nestif
-  # - prealloc
-  # - testpackage
-  # - wsl
+  settings:
+    forbidigo:
+      forbid:
+        - pattern: ^pgxpool\.New.*$
+          msg: Use github.com/conduitio/conduit-connector-postgres/source/cpool.New instead.
+    gocyclo:
+      min-complexity: 20
+    goheader:
+      values:
+        regexp:
+          copyright-year: 20[2-9]\d
+      template-path: .golangci.goheader.template
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+      allow-unused: false
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - gosec
+        path: test/helper\.go
+      - linters:
+          - forbidigo
+        path: source/cpool/cpool\.go
+      - linters:
+          - goconst
+        path: (.+)_test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: false
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -14,7 +14,7 @@ test:
 
 .PHONY: lint
 lint:
-	golangci-lint run -v
+	golangci-lint run
 
 .PHONY: generate
 generate:
@@ -28,6 +28,6 @@ fmt:
 
 .PHONY: install-tools
 install-tools:
-	@echo Installing tools from tools.go
-	@go list -e -f '{{ join .Imports "\n" }}' tools.go | xargs -tI % go install %
+	@echo Installing tools from tools/go.mod
+	@go list -modfile=tools/go.mod tool | xargs -I % go list -modfile=tools/go.mod -f "%@{{.Module.Version}}" % | xargs -tI % go install %
 	@go mod tidy

go.mod

@@ -1,14 +1,12 @@
 module github.com/conduitio/conduit-connector-postgres
 
-go 1.23.2
+go 1.24.2
 
 require (
 	github.com/Masterminds/sprig/v3 v3.3.0
 	github.com/Masterminds/squirrel v1.5.4
 	github.com/conduitio/conduit-commons v0.5.2
 	github.com/conduitio/conduit-connector-sdk v0.13.3
-	github.com/daixiang0/gci v0.13.6
-	github.com/golangci/golangci-lint v1.64.8
 	github.com/google/go-cmp v0.7.0
 	github.com/google/uuid v1.6.0
 	github.com/hamba/avro/v2 v2.28.0
@@ -17,9 +15,7 @@ require (
 	github.com/jackc/pgx/v5 v5.7.4
 	github.com/matryer/is v1.4.1
 	github.com/rs/zerolog v1.34.0
-	golang.org/x/tools v0.31.0
 	gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637
-	mvdan.cc/gofumpt v0.7.0
 )
 
 require (
@@ -64,6 +60,7 @@ require (
 	github.com/conduitio/evolviconf/evolviyaml v0.1.0 // indirect
 	github.com/conduitio/yaml/v3 v3.3.0 // indirect
 	github.com/curioswitch/go-reassign v0.3.0 // indirect
+	github.com/daixiang0/gci v0.13.6 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/denis-tingaikin/go-header v0.5.0 // indirect
 	github.com/ettle/strcase v0.2.0 // indirect
@@ -90,6 +87,7 @@ require (
 	github.com/golangci/dupl v0.0.0-20250308024227-f665c8d69b32 // indirect
 	github.com/golangci/go-printf-func-name v0.1.0 // indirect
 	github.com/golangci/gofmt v0.0.0-20250106114630-d62b90e6713d // indirect
+	github.com/golangci/golangci-lint v1.64.8 // indirect
 	github.com/golangci/misspell v0.6.0 // indirect
 	github.com/golangci/plugin-module-register v0.1.1 // indirect
 	github.com/golangci/revgrep v0.8.0 // indirect
@@ -232,12 +230,14 @@ require (
 	golang.org/x/sys v0.31.0 // indirect
 	golang.org/x/text v0.23.0 // indirect
 	golang.org/x/time v0.11.0 // indirect
+	golang.org/x/tools v0.31.0 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250219182151-9fdb1cabc7b2 // indirect
 	google.golang.org/grpc v1.71.0 // indirect
 	google.golang.org/protobuf v1.36.5 // indirect
 	gopkg.in/ini.v1 v1.67.0 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	honnef.co/go/tools v0.6.1 // indirect
+	mvdan.cc/gofumpt v0.7.0 // indirect
 	mvdan.cc/unparam v0.0.0-20240528143540-8a5130ca722f // indirect
 )