feat: sample test and merge with add, uncomment mul_u8

Author: amkCha

pkg/test/assembly_test.go

@@ -107,21 +107,17 @@ func Test_Asm_Trim(t *testing.T) {
 	test_util.CheckWithFields(t, false, "asm/trim", sc.BLS12_377, sc.KOALABEAR_16)
 }
 
-func Test_Asm_Gf251_Add(t *testing.T) {
-	test_util.Check(t, false, "asm/gf251_add")
-}
-
-func Test_Asm_Gf251_Mul(t *testing.T) {
+func Test_Asm_Gf251(t *testing.T) {
 	// Testing reduce_u8 for now
 	// Test mul once fn call in fn has been fixed
-	test_util.Check(t, false, "asm/gf251_mul")
+	test_util.Check(t, false, "asm/gf251")
 }
 
 // Recusion
 //
-// func Test_Asm_RecPow(t *testing.T) {
-// 	test_util.Check(t, false, "asm/rec_pow")
-// }
+//	func Test_Asm_RecPow(t *testing.T) {
+//		test_util.Check(t, false, "asm/rec_pow")
+//	}
 func Test_Asm_RecPow(t *testing.T) {
 	test_util.Check(t, false, "asm/rec_pow")
 }

testdata/asm/gf251.accepts

@@ -0,0 +1,39 @@
+;; add function testing
+{ "add": { "x": [0], "y": [0], "RESULT": [0] } }
+{ "add": { "x": [249], "y": [1], "RESULT": [250] }}
+{ "add": { "x": [250], "y": [1], "RESULT": [0] }}
+;; Sample reduction_u8 testing
+{ "reduction_u8": { "z": [35762], "RESULT": [24] }}
+{ "reduction_u8": { "z": [4500], "RESULT": [147] }}
+{ "reduction_u8": { "z": [789], "RESULT": [208] }}
+{ "reduction_u8": { "z": [6813], "RESULT": [208] }}
+{ "reduction_u8": { "z": [38185], "RESULT": [107] }}
+{ "reduction_u8": { "z": [48523], "RESULT": [16] }}
+{ "reduction_u8": { "z": [59879], "RESULT": [229] }}
+{ "reduction_u8": { "z": [21014], "RESULT": [237] }}
+{ "reduction_u8": { "z": [2086], "RESULT": [116] }}
+{ "reduction_u8": { "z": [39580], "RESULT": [135] }}
+{ "reduction_u8": { "z": [27408], "RESULT": [60] }}
+{ "reduction_u8": { "z": [47161], "RESULT": [95] }}
+{ "reduction_u8": { "z": [34804], "RESULT": [234] }}
+{ "reduction_u8": { "z": [34429], "RESULT": [159] }}
+{ "reduction_u8": { "z": [64506], "RESULT": [50] }}
+{ "reduction_u8": { "z": [15154], "RESULT": [69] }}
+{ "reduction_u8": { "z": [61300], "RESULT": [212] }}
+{ "reduction_u8": { "z": [30339], "RESULT": [94] }}
+{ "reduction_u8": { "z": [46744], "RESULT": [112] }}
+{ "reduction_u8": { "z": [35608], "RESULT": [194] }}
+{ "reduction_u8": { "z": [49715], "RESULT": [154] }}
+{ "reduction_u8": { "z": [44827], "RESULT": [80] }}
+{ "reduction_u8": { "z": [4979], "RESULT": [42] }}
+{ "reduction_u8": { "z": [56211], "RESULT": [148] }}
+{ "reduction_u8": { "z": [50776], "RESULT": [65] }}
+{ "reduction_u8": { "z": [47703], "RESULT": [103] }}
+{ "reduction_u8": { "z": [17809], "RESULT": [98] }}
+{ "reduction_u8": { "z": [43469], "RESULT": [210] }}
+{ "reduction_u8": { "z": [33652], "RESULT": [104] }}
+{ "reduction_u8": { "z": [52797], "RESULT": [168] }}
+;; add function testing
+{ "mul_u8": { "x": [0], "y": [0], "RESULT": [0] } }
+{ "mul_u8": { "x": [1], "y": [1], "RESULT": [201] }}
+{ "mul_u8": { "x": [232], "y": [232], "RESULT": [22] }}

testdata/asm/gf251_mul.zkasm renamed to testdata/asm/gf251.zkasm

@@ -1,6 +1,26 @@
 ;; GF251 curve
+;; Add on u256
 ;; Mul on u8, to be able to test all cases
 
+fn add(x u256, y u256) -> (RESULT u256) {
+
+   var c0, c1  u1
+   var res u256
+   var red u256
+
+   c0, res = x + y
+   c1, red = res - 251
+   ;; if c1 is 0, it means the diff is positive and res is >= 251
+   ;; if c1 is 1, diff is negative, res < 251
+   if c1==0 goto exit0
+   RESULT = res
+   return
+exit0:
+   RESULT = red
+   return
+
+}
+
 ;; u8 version of mul and reduction to be able to test all cases
 
 fn reduction_u8(z u16) -> (RESULT u8) {
@@ -48,10 +68,9 @@ exit_1:
    return
 }
 
-;; TODO: uncomment once fn call in fn is fixed
-;;fn mul_u8(x u8, y u8) -> (RESULT u8) {
-;;    var z u16
-;;    z = x * y
-;;    RESULT = reduction_u8(z)
-;;    return
-;;}
+fn mul_u8(x u8, y u8) -> (RESULT u8) {
+    var z u16
+    z = x * y
+    RESULT = reduction_u8(z)
+    return
+}