Skip to content

Commit 2453bdc

Browse files
committed
updated documentation and changed names of disable sub context menu
1 parent 3638e30 commit 2453bdc

12 files changed

Lines changed: 329 additions & 6 deletions

File tree

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# SCM syntax highlighting & preventing 3-way merges
2+
pixi.lock merge=binary linguist-language=YAML linguist-generated=true -diff

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,3 +132,6 @@ docs/source/_ext/**/*.pyc
132132
# Ignore pip installation metadata
133133
docs/phoebus_docs.egg-info/
134134
*.pyc
135+
# pixi environments
136+
.pixi/*
137+
!.pixi/config.toml
81.9 KB
Loading
30.5 KB
Loading
26.8 KB
Loading
9.72 KB
Loading

app/alarm/ui/doc/index.rst

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -459,13 +459,32 @@ Context Menu
459459

460460
In the Alarm Tree and the Alarm Table views user may right click on an alarm item to launch a context menu:
461461

462-
.. image:: images/context_menu.png
462+
.. image:: images/context_menu_new.png
463463
:width: 20%
464464

465465
The top item ("Guidance" in the screenshot) will launch a dialog showing the guidance text for the alarm item.
466466

467-
With the Disable Alarms menu item (Alarm Tree only) user may disable an alarm item, or all alarms in the sub-tree of a
468-
node. The alarm(s) will stay disabled until explicitly enabled by the user. See also notes below for
467+
.. image:: images/context_menu_disable.png
468+
:width: 35%
469+
470+
With the Disable... menu item (Alarm Tree only) user may disable an alarm item, or all alarms in the sub-tree of a
471+
node.
472+
When choosing to disable the alarm(s) *indefinitely* in the sub-context menu, the alarm(s) will stay disabled until
473+
explicitly enabled by the user.
474+
475+
Alarm(s) can also be disabled for a certain time choosing *with enable date*.
476+
477+
.. image:: images/dialog_enable_date.png
478+
:width: 40%
479+
480+
Users can specify an either absolute or relative date or time the alarm(s) should be disabled. After that, the alarm(s)
481+
will be enabled again automatically.
482+
483+
**NOTE**: A structural component, along with all the items in its sub-tree, can **only** be disabled with an enable date
484+
if either all of the items have the same enable date or none at all.
485+
If this is not the case, the *with enable date* option in the sub context menu will be disabled.
486+
487+
See also notes below for
469488
more information on how disabled alarms are handled upon import of the alarm configuration XML file.
470489

471490
Configuration Editor
@@ -479,8 +498,13 @@ editor dialog:
479498

480499
In this view user may update all settings defined in the alarm configuration XML file:
481500

482-
.. image:: images/configuration_editor.png
483-
:width: 50%
501+
**NOTE:** There are different configuration files for a structural component (path), containing several components
502+
or leaves, and a leaf itself (training:COUNTER), as their functionalities vary
503+
504+
505+
.. image:: images/configuration_editor_dialogs.png
506+
:width: 85%
507+
484508

485509
**NOTE:** Any changes performed in the editor will be overwritten when the associated alarm configuration XML file is
486510
imported again.

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public class Messages
3535
public static String headerConfirmDisable;
3636
public static String headerConfirmDisableWithEnableDate;
3737
public static String headerConfirmEnable;
38+
public static String indefinitely;
3839
public static String moveItemFailed;
3940
public static String partlyDisabled;
4041
public static String promptTitle;
@@ -43,6 +44,7 @@ public class Messages
4344
public static String renameItemFailed;
4445
public static String timer;
4546
public static String unacknowledgeFailed;
47+
public static String withEnableDate;
4648

4749
static
4850
{

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/DisableAction.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ public DisableAction(final Node node, final AlarmClient model, final List<AlarmT
3434
setText(Messages.disableMenu);
3535
setGraphic(ImageCache.getImageView(AlarmUI.class, "/icons/disabled.png"));
3636
MenuItem disable = new DisableComponentAction(node, model, items);
37-
MenuItem disableUntil = new MenuItem(Messages.disabledUntil);
37+
disable.setText(Messages.indefinitely);
38+
MenuItem disableUntil = new MenuItem(Messages.withEnableDate);
3839
disableUntil.setDisable(true);
3940
Set<AlarmClientLeaf> totalLeafItems = new HashSet<>();
4041
Set<AlarmClientLeaf> leafItemsWithEnableDate = new HashSet<>();

app/alarm/ui/src/main/resources/org/phoebus/applications/alarm/ui/messages.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ headerAlreadyEnabled=All PVs in the selected section are already enabled
5656
headerConfirmDisable=Disable all PVs in the selected section of the alarm hierarchy?\nThis would disable {0} PVs.
5757
headerConfirmDisableWithEnableDate=Disable all PVs in the selected section of the alarm hierarchy until {0}?\nThis would affect {1} PVs.
5858
headerConfirmEnable=Enable all PVs in the selected section of the alarm hierarchy?\nThis would enable {0} PVs.
59+
indefinitely=Indefinitely
5960
info=Info
6061
invalidDate=You have selected a date that is either invalid or in the past
6162
latch=Latch
@@ -79,3 +80,4 @@ tooltipMoveEditDetail=Edit the detail field of table item
7980
tooltipMoveTableItemDown=Move table item down
8081
tooltipMoveTableItemUp=Move table item up
8182
unacknowledgeFailed=Failed to unacknowledge alarm(s)
83+
withEnableDate=With Enable Date

0 commit comments

Comments
 (0)