Skip to content

Commit 3e4d26a

Browse files
committed
added date of disabled pvs to structural element
1 parent d726947 commit 3e4d26a

3 files changed

Lines changed: 13 additions & 8 deletions

File tree

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/Messages.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public class Messages
4343
public static String removeComponentFailed;
4444
public static String renameItemFailed;
4545
public static String timer;
46+
public static String timers;
4647
public static String unacknowledgeFailed;
4748
public static String withEnableDate;
4849

app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/AlarmTreeViewCell.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@
2626

2727
import java.time.LocalDateTime;
2828
import java.time.format.DateTimeFormatter;
29-
import java.util.LinkedList;
30-
import java.util.List;
31-
import java.util.Optional;
29+
import java.util.*;
3230

3331
/** TreeCell for AlarmTreeItem
3432
* @author Kay Kasemir
@@ -127,22 +125,27 @@ protected void updateItem(final AlarmTreeItem<?> item, final boolean empty)
127125
else
128126
{
129127
final AlarmClientNode node = (AlarmClientNode) item;
130-
131128
Optional<Pair<LeavesDisabledStatus, Boolean>> maybeLeavesDisabledStatusBooleanPair = leavesDisabledStatus(node);
132129
if (maybeLeavesDisabledStatusBooleanPair.isPresent() && !maybeLeavesDisabledStatusBooleanPair.get().getKey().equals(LeavesDisabledStatus.AllEnabled)) {
133130
Pair<LeavesDisabledStatus, Boolean> leavesDisabledStatusBooleanPair = maybeLeavesDisabledStatusBooleanPair.get();
134131

135132
if (leavesDisabledStatusBooleanPair.getKey().equals(LeavesDisabledStatus.AllDisabled)) {
136133
if (leavesDisabledStatusBooleanPair.getValue()) {
137-
disabledTimerIndicator.setText("(" + Messages.disabled + "; " + Messages.timer + ")");
138-
}
139-
else {
134+
Set<AlarmClientLeaf> withEnableDate = new HashSet<>();
135+
boolean test = DisableAction.checkEnableDates(node.getChildren(), new HashSet<>(), withEnableDate);
136+
if (test){
137+
disabledTimerIndicator.setText("(" + Messages.disabled + "; " + Messages.timer + ": " + withEnableDate.iterator().next().getEnabledDate() + ")");
138+
} else {
139+
disabledTimerIndicator.setText("(" + Messages.disabled + "; " + Messages.timers + ")");
140+
}
141+
142+
} else {
140143
disabledTimerIndicator.setText("(" + Messages.disabled + ")");
141144
}
142145
}
143146
else if (leavesDisabledStatusBooleanPair.getKey().equals(LeavesDisabledStatus.SomeEnabledSomeDisabled)) {
144147
if (leavesDisabledStatusBooleanPair.getValue()) {
145-
disabledTimerIndicator.setText("(" + Messages.partlyDisabled + "; " + Messages.timer + ")");
148+
disabledTimerIndicator.setText("(" + Messages.partlyDisabled + "; " + Messages.timers + ")");
146149
}
147150
else {
148151
disabledTimerIndicator.setText("(" + Messages.partlyDisabled + ")");

app/alarm/ui/src/main/resources/org/phoebus/applications/alarm/ui/messages.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ relativeDateTooltip=Select a predefined duration for disabling the alarm
7373
removeComponentFailed=Failed to remove component
7474
renameItemFailed=Failed to rename item
7575
timer=Timer
76+
timers=Timers
7677
title=Title
7778
tooltipAddTableItem=Add a new table item
7879
tooltipDeleteSelectedItems=Delete selected table items

0 commit comments

Comments
 (0)