fix: allow to clean variable (write "" into PV)

Author: flef

app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/AutoCompleteWidget.java

@@ -66,36 +66,31 @@ public Widget createWidget() {
      * 'items' property: list of items (string properties) for auto-completion
      */
     public static final WidgetPropertyDescriptor<String> propItems =
-        newPVNamePropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "testitems",
-            "AutoComplete Item");
+        newPVNamePropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "testitems", "Suggestions");
 
     /**
      * 'max_suggestions' property: maximum number of suggestions to display
      */
     private static final WidgetPropertyDescriptor<Integer> propMaxSuggestions =
-        newIntegerPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "max_suggestions",
-            "Max Suggestions");
+        newIntegerPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "max_suggestions", "Max Suggestions");
 
     /**
      * 'min_chars' property: minimum characters to trigger autocomplete
      */
     private static final WidgetPropertyDescriptor<Integer> propMinCharacters =
-        newIntegerPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "min_characters",
-            "Min Characters");
+        newIntegerPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "min_characters", "Min Characters");
 
     /**
      * 'case_sensitive' property: whether matching is case sensitive
      */
     private static final WidgetPropertyDescriptor<Boolean> propCaseSensitive =
-        newBooleanPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "case_sensitive",
-            "Case Sensitive");
+        newBooleanPropertyDescriptor(WidgetPropertyCategory.BEHAVIOR, "case_sensitive", "Case Sensitive");
 
     /**
      * 'placeholder' property: placeholder text when empty
      */
     private static final WidgetPropertyDescriptor<String> propPlaceholder =
-        newStringPropertyDescriptor(WidgetPropertyCategory.DISPLAY, "placeholder",
-            "Placeholder Text");
+        newStringPropertyDescriptor(WidgetPropertyCategory.DISPLAY, "placeholder", "Placeholder Text");
 
     /**
      * 'filter_mode' property: how to filter suggestions (starts_with, contains, fuzzy)

app/display/representation-javafx/src/main/java/org/csstudio/display/builder/representation/javafx/widgets/AutoCompleteRepresentation.java

@@ -7,10 +7,13 @@
  *******************************************************************************/
 package org.csstudio.display.builder.representation.javafx.widgets;
 
+import static org.csstudio.display.builder.representation.ToolkitRepresentation.logger;
+
 import java.text.MessageFormat;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
+import java.util.logging.Level;
 
 import javafx.scene.input.KeyCode;
 import javafx.scene.input.KeyEvent;
@@ -263,7 +266,7 @@ private void setupTextFieldEventHandlers(TextField textField) {
                 suggestionsPopup.hide();
             }
             String text = textField.getText();
-            if (text != null && !text.trim().isEmpty()) {
+            if (text != null) {
                 confirmValue(text);
             }
         });
@@ -452,8 +455,7 @@ private void confirmValue(final String value) {
             Object mappedValue;
 
             if (currentPvValue instanceof VEnum) {
-                mappedValue = FormatOptionHandler.parse(currentPvValue, value,
-                    FormatOption.DEFAULT);
+                mappedValue = FormatOptionHandler.parse(currentPvValue, value, FormatOption.DEFAULT);
             } else {
                 try {
                     if (value.contains(".")) {
@@ -462,15 +464,15 @@ private void confirmValue(final String value) {
                         mappedValue = Integer.parseInt(value);
                     }
                 } catch (NumberFormatException e) {
+                    // This will handle String PVs, which are expected to be most likely
                     VType convertedValue = VType.toVType(value);
                     mappedValue = (convertedValue != null) ? convertedValue : value;
                 }
             }
 
             toolkit.fireWrite(model_widget, mappedValue);
         } catch (Exception e) {
-            System.err.println("Error writing to PV: " + e.getMessage());
-            e.printStackTrace();
+            logger.log(Level.WARNING, "Error writing to PV", e);
         }
     }