Add file upload

Author: Laurynas Butkus

.rspec

@@ -1,3 +1,2 @@
---format documentation
 --color
 --require spec_helper

lib/convert_api/client.rb

@@ -9,6 +9,17 @@ def post(path, params)
       end
     end
 
+    def upload(io, filename)
+      handle_exceptions do
+        result = connection.post('upload', io.read) do |request|
+          request.headers['Content-Type'] = 'application/octet-stream'
+          request.headers['Content-Disposition'] = "attachment; filename='#{filename}'"
+        end
+
+        result.body
+      end
+    end
+
     private
 
     def handle_exceptions
@@ -28,7 +39,6 @@ def connection
         builder.params['TimeOut'] = config.conversion_timeout
         builder.params['StoreFile'] = true
 
-        builder.request :multipart
         builder.request :url_encoded
 
         builder.response :json, content_type: /\bjson$/

spec/convert_api/client_spec.rb

@@ -1,28 +1,28 @@
 RSpec.describe ConvertApi::Client do
   before { ConvertApi.config.api_secret = ENV['CONVERT_API_SECRET'] }
 
+  let(:client) { described_class.new }
+
   describe '#post' do
-    subject { described_class.new.post(path, params) }
+    subject { client.post(path, params) }
 
     let(:path) { 'txt/to/pdf' }
     let(:params) { { File: file } }
+    let(:file) { 'https://www.w3.org/TR/PNG/iso_8859-1.txt' }
 
-    shared_examples 'converting file' do
-      it 'sends request and returns result' do
-        expect(subject['ConversionCost']).to be_instance_of(Integer)
-        expect(subject['Files']).to be_instance_of(Array)
-      end
+    it 'sends request and returns result' do
+      expect(subject['ConversionCost']).to be_instance_of(Integer)
+      expect(subject['Files']).to be_instance_of(Array)
     end
+  end
 
-    context 'with local file' do
-      let(:file) { Faraday::UploadIO.new('LICENSE.txt', 'application/octet-stream') }
+  describe '#upload' do
+    subject { client.upload(io, File.basename(io.path)) }
 
-      it_behaves_like 'converting file'
-    end
+    let(:io) { File.open('LICENSE.txt') }
 
-    context 'with url as file' do
-      let(:file) { 'https://www.w3.org/TR/PNG/iso_8859-1.txt' }
-      it_behaves_like 'converting file'
+    it 'uploads file and results result' do
+      expect(subject['FileId']).to be_instance_of(String)
     end
   end
 end

spec/convert_api_spec.rb

@@ -4,7 +4,6 @@
   end
 
   it 'has configuration defaults' do
-    expect(described_class.config.api_secret).to be_nil
     expect(described_class.config.api_base_uri).not_to be_nil
     expect(described_class.config.connect_timeout).not_to be_nil
     expect(described_class.config.conversion_timeout).not_to be_nil