Replies: 2 comments
-
All of the colors look quite nice to me. I'd be happy to use any of these color palettes, and especially so if they're configurable. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Thanks! That's a great point. Would it be helpful to add a Settings/Preferences button with a color picker (and space for other settings in the future), possibly in another PR? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I created #1 to help with color accessibility and I'd like to gather feedback since this is a subjective decision.
I won't duplicate too much info from the PR, but I'll add that while I intentionally kept the colors in my PR close to the originals, I can see arguments for pushing the 'false' color to be darker and more blue or for using even more contrastful colors like these:
For comparison, here are our current colors and those from my PR using the same tool:
Personally, I like the ones from Bang Wong since they contrast well in greyscale without looking like one is much darker than the other in full-color. If having light colors is a design goal (for instance so that text rendered on top of them can be legible), we could increase the lightness of the colors without losing much contrast between them.
I've tested all these colors on a couple devices but I'd love to hear more from others on how they look.
Beta Was this translation helpful? Give feedback.
All reactions