fix: remaining lint errors in src and tests

Author: echobt

src/swe_forge/discovery/agentic.py

@@ -13,11 +13,10 @@
 import json
 import re
 from dataclasses import dataclass, field
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from swe_forge.detection.language import Language
-    from swe_forge.detection.package_manager import PackageManager
     from swe_forge.swe.agentic_config import SandboxProtocol
     from swe_forge.llm.client import LLMClient
 

src/swe_forge/docker_test/harness.py

@@ -14,7 +14,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
-from swe_forge.execution.docker_client import DockerClient, DockerError, ExecResult
+from swe_forge.execution.docker_client import DockerClient, DockerError
 from swe_forge.execution.sandbox import DockerSandbox, SandboxConfig
 
 if TYPE_CHECKING:
@@ -112,7 +112,6 @@ async def _build_from_dockerfile(
         context_dir: str | Path | None = None,
     ) -> str:
         """Build image from Dockerfile string."""
-        import tempfile
 
         image_tag = f"swe-test-{uuid.uuid4().hex[:8]}"
 
@@ -137,7 +136,7 @@ async def _build_from_dockerfile(
 
     async def _build_from_workspace(self, workspace: dict[str, Any]) -> str:
         """Build image from workspace configuration."""
-        image_tag = f"swe-test-{uuid.uuid4().hex[:8]}"
+        _image_tag = f"swe-test-{uuid.uuid4().hex[:8]}"
 
         base_image = workspace.get("environment", {}).get("image", self.default_image)
         language = workspace.get("language", "python")

src/swe_forge/docker_test/verification.py

@@ -11,6 +11,8 @@
 from dataclasses import dataclass
 from typing import TYPE_CHECKING, Sequence
 
+from swe_forge.docker_test.harness import TestRunResult
+
 if TYPE_CHECKING:
     from swe_forge.docker_test.harness import DockerTestHarness
 
@@ -230,10 +232,8 @@ async def _run_fail_to_pass_tests(
     sandbox,
     tests: Sequence[str],
     timeout: float,
-) -> "TestRunResult":
+) -> TestRunResult:
     """Run fail_to_pass tests."""
-    from swe_forge.docker_test.harness import TestRunResult
-
     if not tests:
         return TestRunResult(
             passed=True,
@@ -265,7 +265,7 @@ async def _run_pass_to_pass_tests(
     sandbox,
     tests: Sequence[str],
     timeout: float,
-) -> "TestRunResult":
+) -> TestRunResult:
     """Run pass_to_pass tests."""
     return await _run_fail_to_pass_tests(sandbox, tests, timeout)
 

src/swe_forge/execution/commands.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import json
-import asyncio
 import time
 from dataclasses import dataclass
 from typing import TYPE_CHECKING

src/swe_forge/execution/resources.py

@@ -6,7 +6,7 @@
 
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from enum import Enum
 from typing import Any, TYPE_CHECKING
 

src/swe_forge/execution/sandbox.py

@@ -20,7 +20,6 @@
     ContainerManager,
     ContainerSpec,
     ManagedContainerStatus,
-    VolumeMount,
 )
 from swe_forge.execution.docker_client import DockerClient, DockerError
 from swe_forge.execution.commands import exec_in_container, ExecResult
@@ -413,9 +412,9 @@ async def install_dependencies(
         if not packages and not requirements_file:
             raise ValueError("Must provide either packages or requirements_file")
 
-        container_id = self._require_running()
+        _container_id = self._require_running()
         install_timeout = timeout or self._config.install_timeout
-        workspace_dir = self._config.workspace_dir
+        _workspace_dir = self._config.workspace_dir
 
         if requirements_file:
             cmd = f"pip install -r {requirements_file}"
@@ -611,7 +610,7 @@ def image_for_language(language: str) -> str:
         Returns:
             Docker image name (generic fallback).
         """
-        language_lower = language.lower()
+        _language_lower = language.lower()
 
         # FALLBACK: Let Docker Hub resolve based on language
         # The agent should detect and use the correct image

src/swe_forge/export/parquet.py

@@ -3,7 +3,6 @@
 from __future__ import annotations
 
 import json
-from datetime import datetime
 from pathlib import Path
 from typing import TYPE_CHECKING
 

src/swe_forge/llm/anthropic_client.py

@@ -1,7 +1,7 @@
 """Anthropic LLM client implementation."""
 
 import json
-from typing import Any, Literal
+from typing import Any
 
 from anthropic import AsyncAnthropic
 

src/swe_forge/llm/openrouter.py

@@ -17,14 +17,12 @@
 
 from swe_forge.llm.client import (
     Choice,
-    Choice as ClientChoice,
     FunctionCall,
     GenerationRequest,
     GenerationResponse,
     LLMClient,
     Message,
     ToolCall,
-    ToolDefinition,
     Usage,
 )
 

src/swe_forge/llm/tools.py

@@ -13,10 +13,8 @@
 from dataclasses import dataclass, field
 from typing import Any
 
-from pydantic import ValidationError
 
 from swe_forge.llm.client import (
-    FunctionCall,
     Message,
     ToolCall,
     ToolDefinition,