Skip to content

Blaze Burner's block animate tick does not override vanilla method #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RaymondBlaze opened this issue Mar 21, 2025 · 1 comment · Fixed by #8140
Closed

Blaze Burner's block animate tick does not override vanilla method #8068

RaymondBlaze opened this issue Mar 21, 2025 · 1 comment · Fixed by #8140
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@RaymondBlaze
Copy link
Contributor

Create/src/main/java/com/simibubi/create/content/processing/burner/BlazeBurnerBlock.java

Line 242 in 8d3eda5

public void animateTick(BlockState state, Level world, BlockPos pos, Random random) {

Vanilla has moved from Random to RandomSource since at least no later than 1.19.2, however the above animateTick didn't kept up with the vanilla update due to missing @Override, and has been defunct due to not overriding super since 1.19.2.
@PepperCode1 PepperCode1 added type: bug Issue where something isn't working status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix labels Mar 21, 2025
@JensenJ
Copy link
Contributor

JensenJ commented Mar 27, 2025

This also seems to be the case for LitBlazeBurnerBlock, just incase that gets missed when fixing this.

@JensenJ JensenJ mentioned this issue Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix blaze burners not overriding animate tick JensenJ-Modding/Create
3 participants
@JensenJ @PepperCode1 @RaymondBlaze