Skip to content

Commit ffa5c90

Browse files
committed
Update analytics location. Fix #1145
1 parent 7fd54a1 commit ffa5c90

File tree

6 files changed

+37
-22
lines changed

6 files changed

+37
-22
lines changed

electron_app/electron-starter.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ const mailboxWindow = require('./src/windows/mailbox');
99
const loadingWindow = require('./src/windows/loading');
1010
const composerWindowManager = require('./src/windows/composer');
1111
const { createAppMenu } = require('./src/windows/menu');
12-
const { APP_VERSION, NUCLEUS_ID } = require('./src/utils/const');
1312
const {
1413
showWindows,
1514
isDev,
@@ -47,7 +46,7 @@ async function initApp() {
4746
mySettings.initialize(settings);
4847
wsClient.start(myAccount);
4948
createAppMenu();
50-
mailboxWindow.show();
49+
mailboxWindow.show({ firstOpenApp: true });
5150
} else {
5251
await getUserLanguage();
5352
createAppMenu();
@@ -80,8 +79,6 @@ async function initApp() {
8079
loadingWindow.send('socket-message', data);
8180
}
8281
});
83-
84-
upNucleus();
8582
}
8683

8784
// App
@@ -102,17 +99,6 @@ const getUserLanguage = async () => {
10299
await dbManager.updateSettings({ language: osLanguage });
103100
};
104101

105-
const upNucleus = () => {
106-
const data = {
107-
onlyMainProcess: true,
108-
userId: myAccount.recipientId,
109-
version: APP_VERSION,
110-
language: mySettings.language
111-
}
112-
const Nucleus = require('electron-nucleus')(NUCLEUS_ID, data);
113-
Nucleus.track("MAILBOX_TRACK");
114-
}
115-
116102
app.on('ready', () => {
117103
initApp();
118104
});

electron_app/src/ipc/mailbox.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ ipc.answerRenderer('open-file-explorer', filename => {
4444
mailboxWindow.showFileExplorer(filename);
4545
});
4646

47-
ipc.answerRenderer('open-mailbox', () => {
47+
ipc.answerRenderer('open-mailbox', ({ firstOpenApp }) => {
4848
wsClient.start(myAccount);
49-
mailboxWindow.show();
49+
mailboxWindow.show({ firstOpenApp });
5050
});
5151

5252
ipc.answerRenderer('print-to-pdf', async ({ emailId, threadId }) => {

electron_app/src/windows/mailbox.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ const { appUpdater } = require('./../updater');
88
const globalManager = require('./../globalManager');
99
const { mailtoProtocolRegex } = require('./../utils/RegexUtils');
1010
const { removeProtocolFromUrl } = require('./../utils/stringUtils');
11-
const { isFromStore, isDev } = require('./windowUtils');
11+
const {
12+
isFromStore,
13+
isDev,
14+
nucleusTrack,
15+
NUCLEUS_EVENTS
16+
} = require('./windowUtils');
1217
const { createTrayIcon, destroyTrayIcon } = require('./tray');
1318
const { isWindows } = require('./../utils/osUtils');
1419

@@ -89,18 +94,20 @@ const showFileExplorer = filename => {
8994
mailboxWindow.send('display-message-success-download');
9095
};
9196

92-
const show = async () => {
97+
const show = async ({ firstOpenApp = false }) => {
9398
const existVisibleWindow = BrowserWindow.getAllWindows().filter(w =>
9499
w.isVisible()
95100
);
96101
if (mailboxWindow) {
97102
mailboxWindow.show();
98103
createTrayIcon();
104+
if (firstOpenApp) nucleusTrack(NUCLEUS_EVENTS.MAILBOX_TRACK);
99105
} else if (!existVisibleWindow.length || !mailboxWindow) {
100106
await create();
101107
mailboxWindow.on('ready-to-show', () => {
102108
mailboxWindow.show();
103109
createTrayIcon();
110+
if (firstOpenApp) nucleusTrack(NUCLEUS_EVENTS.MAILBOX_TRACK);
104111
});
105112
mailboxWindow.on('focus', () => {
106113
if (!globalManager.windowsEvents.checkDisabled()) {

electron_app/src/windows/tray.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const createTrayIcon = () => {
5353
tray.setContextMenu(contextMenu);
5454
tray.on('click', () => {
5555
const mailboxWindow = require('./mailbox');
56-
mailboxWindow.show();
56+
mailboxWindow.show({});
5757
});
5858
}
5959
};

electron_app/src/windows/windowUtils.js

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const { app, BrowserWindow } = require('electron');
22
const osLocale = require('os-locale');
33
const globalManager = require('./../globalManager');
4+
const myAccount = require('./../Account');
5+
const mySettings = require('./../Settings');
6+
const { APP_VERSION, NUCLEUS_ID } = require('./../utils/const');
47

58
const showWindows = () => {
69
const visibleWindows = BrowserWindow.getAllWindows();
@@ -39,6 +42,23 @@ const sendEventToAllWindows = (eventName, params) => {
3942
});
4043
};
4144

45+
const getNucleusPayload = () => ({
46+
onlyMainProcess: true,
47+
userId: myAccount.recipientId,
48+
version: APP_VERSION,
49+
language: mySettings.language
50+
});
51+
52+
const nucleusTrack = eventName => {
53+
const data = getNucleusPayload();
54+
const Nucleus = require('electron-nucleus')(NUCLEUS_ID, data);
55+
Nucleus.track(eventName);
56+
};
57+
58+
const NUCLEUS_EVENTS = {
59+
MAILBOX_TRACK: 'MAILBOX_TRACK'
60+
};
61+
4262
module.exports = {
4363
quit,
4464
isDev,
@@ -48,5 +68,7 @@ module.exports = {
4868
isFromStore,
4969
showWindows,
5070
getSystemLanguage,
51-
sendEventToAllWindows
71+
sendEventToAllWindows,
72+
NUCLEUS_EVENTS,
73+
nucleusTrack
5274
};

email_loading/src/utils/ipc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const closeCreatingKeysLoadingWindow = () => {
77
export const getComputerName = () => callMain('get-computer-name');
88

99
export const openMailboxWindow = () => {
10-
callMain('open-mailbox');
10+
callMain('open-mailbox', { firstOpenApp: true });
1111
};
1212

1313
export const throwError = error => {

0 commit comments

Comments
 (0)