Skip to content

Middleware doesn't work when added through the constructor #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Guiorgy opened this issue Aug 3, 2024 · 4 comments · May be fixed by #864
Closed

Middleware doesn't work when added through the constructor #861

Guiorgy opened this issue Aug 3, 2024 · 4 comments · May be fixed by #864

Comments

@Guiorgy
Copy link
Contributor

Guiorgy commented Aug 3, 2024 •
edited
Loading

I noticed a strange behaviour when playing around with middlewares, when I add my middleware to the app as a template argument it works as expected, however, when I add the same middleware as a constructor argument, neither before_handle and after_handle are executed.

I added a log to the after_handle function:

void after_handle(crow::request& req, crow::response& res, context& ctx) {
    CROW_LOG_ERROR << "wtf?!";
    // ...
}

Compiling and running the following:

crow::App<MyMiddleware> app;

MyMiddleware& middleware = app.get_middleware<MyMiddleware>();
// configure middleware

// define routes

app.bindaddr("127.0.0.1").port(8080).run();

Sending a single request prints "wtf?!" as expected:

template middleware

However, if I compile and run the following:

MyMiddleware middleware;
// configure middleware

crow::App<> app(middleware);

// define routes

app.bindaddr("127.0.0.1").port(8080).run();

And send a single request, I don't get the "wtf?!" message:

constructor middleware

The reference docs Say about the constructor "Construct Crow with a subset of middleware.", what does that mean exactly? Can this be mentioned in the Middleware guide?
@Guiorgy Guiorgy changed the title Middleware after_handle not executed when adding middleware through the constructor Middleware doesn't work when added through the constructor Aug 5, 2024
@Guiorgy
Copy link
Contributor Author

Guiorgy commented Aug 5, 2024

Also an FYI, in middleware.h, in the is_after_handle_arity_3_impl struct value is defined as a constexpr, while in is_before_handle_arity_3_impl as a const.

@Guiorgy
Copy link
Contributor Author

Guiorgy commented Aug 5, 2024 •
edited
Loading

From looking at the source, I think the middlewares passed to the constructor replace those defined in the template arguments as an alternative initialization to the app.get_middleware() approach:

MyMiddleware middleware;
// configure middleware

crow::App<MyMiddleware> app(middleware);

// define routes

app.bindaddr("127.0.0.1").port(8080).run();

If this is correct, it would sure be useful to have a static_assert that prevents passing middleware types missing in the App template arguments.

I'll try to submit a PR when I get time.

@Guiorgy Guiorgy mentioned this issue Aug 6, 2024
Draft
6 tasks
@gittiver
Copy link
Member

unluckily PR is stuck in draft state.

@Guiorgy
Copy link
Contributor Author

Guiorgy commented Apr 15, 2025

unluckily PR is stuck in draft state.

Yeah, life stuff. Feel free to close them. I'll reopen them one day if I manage to get it over the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Middleware documentation and compile time static assertions Guiorgy/Crow
2 participants
@gittiver @Guiorgy