-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipairs() called on enum attr tables never ends #1860
Comments
I guess there shouldn't really be a notion of ipairs on it, then. Unless the format does have a sensible end? Either way, it feels more like a function actually-- decodeTileInfo or whatever. Ykwim? |
There definitely is a logical "end" - the However, the Lua layer (maybe also C++) has a "default" attributes object for any enum items that aren't defined, which also includes values past the end of the enum. Here's another example.
So while we do want invalid indexes to continue to work, we should make |
ipairs() currently fails due to DFHack#1860
ipairs() currently fails due to DFHack#1860
ipairs() currently fails due to DFHack#1860
To reproduce:
This can be stopped with
kill-lua
if run withdfhack-run
(since printall_ipairs() is pure Lua).Reported by @wolfboyft on Discord
The text was updated successfully, but these errors were encountered: