Skip to content

Commit fb0bc82

Browse files
Remove test 9 since it is a duplicate of test 8
Signed-off-by: Steven Bellock <[email protected]>
1 parent 7047499 commit fb0bc82

File tree

1 file changed

+2
-59
lines changed

1 file changed

+2
-59
lines changed

unit_test/test_spdm_requester/get_version.c

+2-59
Original file line numberDiff line numberDiff line change
@@ -214,50 +214,7 @@ libspdm_return_t libspdm_requester_get_version_test_receive_message(
214214
}
215215
return LIBSPDM_STATUS_SUCCESS;
216216

217-
case 0x9: {
218-
static uintn sub_index2 = 0;
219-
if (sub_index2 == 0) {
220-
spdm_error_response_data_response_not_ready_t
221-
spdm_response;
222-
223-
libspdm_zero_mem(&spdm_response, sizeof(spdm_response));
224-
spdm_response.header.spdm_version =
225-
SPDM_MESSAGE_VERSION_10;
226-
spdm_response.header.request_response_code = SPDM_ERROR;
227-
spdm_response.header.param1 =
228-
SPDM_ERROR_CODE_RESPONSE_NOT_READY;
229-
spdm_response.header.param2 = 0;
230-
spdm_response.extend_error_data.rd_exponent = 1;
231-
spdm_response.extend_error_data.rd_tm = 1;
232-
spdm_response.extend_error_data.request_code =
233-
SPDM_GET_VERSION;
234-
spdm_response.extend_error_data.token = 1;
235-
236-
libspdm_transport_test_encode_message(
237-
spdm_context, NULL, false, false,
238-
sizeof(spdm_response), &spdm_response,
239-
response_size, response);
240-
} else if (sub_index2 == 1) {
241-
libspdm_version_response_mine_t spdm_response;
242-
243-
libspdm_zero_mem(&spdm_response, sizeof(spdm_response));
244-
spdm_response.header.spdm_version =
245-
SPDM_MESSAGE_VERSION_10;
246-
spdm_response.header.request_response_code =
247-
SPDM_VERSION;
248-
spdm_response.header.param1 = 0;
249-
spdm_response.header.param2 = 0;
250-
spdm_response.version_number_entry_count = 2;
251-
spdm_response.version_number_entry[0] = 0x10 << SPDM_VERSION_NUMBER_SHIFT_BIT;
252-
spdm_response.version_number_entry[1] = 0x11 << SPDM_VERSION_NUMBER_SHIFT_BIT;
253-
254-
libspdm_transport_test_encode_message(
255-
spdm_context, NULL, false, false,
256-
sizeof(spdm_response), &spdm_response,
257-
response_size, response);
258-
}
259-
sub_index2++;
260-
}
217+
case 0x9:
261218
return LIBSPDM_STATUS_SUCCESS;
262219

263220
case 0xA: {
@@ -542,24 +499,10 @@ void libspdm_test_requester_get_version_case8(void **state)
542499
}
543500

544501
/**
545-
* Test 9: on the first try, receiving a ResponseNotReady ERROR message, and on retry,
546-
* receiving a correct VERSION message with available version 1.0 and 1.1.
547-
* Expected behavior: client returns a status of LIBSPDM_STATUS_ERROR_PEER.
548-
* Note: The responder should not
549-
* respond a GET_VERSION message with a ResponseNotReady.
502+
* Test 9: Can be populated with new test.
550503
**/
551504
void libspdm_test_requester_get_version_case9(void **state)
552505
{
553-
libspdm_return_t status;
554-
libspdm_test_context_t *spdm_test_context;
555-
libspdm_context_t *spdm_context;
556-
557-
spdm_test_context = *state;
558-
spdm_context = spdm_test_context->spdm_context;
559-
spdm_test_context->case_id = 0x9;
560-
561-
status = libspdm_get_version(spdm_context, NULL, NULL);
562-
assert_int_equal(status, LIBSPDM_STATUS_ERROR_PEER);
563506
}
564507

565508
/**

0 commit comments

Comments
 (0)