Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: ISIS IO Remove QT Dep #5610

Closed
wants to merge 95 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
75a7a26
Added history comment.
AustinSanders Nov 6, 2019
7408dc7
Initial move to core
Oct 16, 2020
5f3cfd0
Removed Pvl cmakelists
Oct 16, 2020
0751b38
Removed more cmakelists.txt
Oct 16, 2020
acdc7ee
Add subdirectory
Oct 16, 2020
1ca6ec0
Fully modularized core
AustinSanders Oct 22, 2020
4dc859f
Fully modularized core
AustinSanders Oct 22, 2020
d73eac9
replaced PvlEditDialog that was accidentally removed in prev commit
AustinSanders Oct 22, 2020
04842ba
Initial constants unit gtest
AustinSanders Oct 23, 2020
674dd72
Fixed pvl core test config (#4349)
jessemapel Mar 10, 2021
766a0ae
Fixed pvl core test config
jessemapel Mar 9, 2021
bc76f7a
Changed cmake_source to project_source for submodule
jessemapel Mar 9, 2021
013b771
First working swig wrappers
AustinSanders Mar 10, 2021
6f53672
Rebased off of pvl_core
AustinSanders Mar 10, 2021
0e03712
Moved old ISIS unitTests into core (#4351)
jessemapel Mar 11, 2021
7e71f5a
Finished swig wrapper with some syntax sugar for ease of use in pytho…
acpaquette Mar 12, 2021
48a92e6
Initial core deployment (#4355)
AustinSanders Mar 12, 2021
5e504eb
Updated preference files (#4354)
jessemapel Mar 12, 2021
c63d653
Reset main build and created core recipe
acpaquette Jun 9, 2021
a4a963d
Changed pvl recipe url to point to usgsastro
acpaquette Jun 9, 2021
486a28a
Fixed typo
acpaquette Jun 9, 2021
dffc56e
Removed a chunk of files that made it through the rebase (#4523)
acpaquette Jun 10, 2021
1958af6
Add Blob to core from base (#4525)
scsides Jun 14, 2021
f5002a0
Pvl core Docs (#4536)
acpaquette Jun 17, 2021
fefc9f9
Blob Swig Wrapper (#4613)
acpaquette Sep 6, 2021
da239b3
Post rebase fixes
acpaquette Jul 7, 2023
ef3612c
Fixed app logging for all call able apps
acpaquette Jul 17, 2023
31f0845
Moved table reading/writing into core
acpaquette Jul 17, 2023
774abeb
Fixed missing license identifiers, and leftover merge conflict from r…
acpaquette Jul 20, 2023
7a5959f
Removed unnecessary includes to classes outside of core
acpaquette Jul 20, 2023
76a5745
Removed tempFixtures include in core tests
acpaquette Jul 20, 2023
ae92738
Updates sources and includes for building
acpaquette Jul 20, 2023
e74c69c
Moves necessary fixtures into core
acpaquette Jul 20, 2023
612ebec
Enforce that core unit tests use the test preferences
acpaquette Jul 20, 2023
c124f24
Removed commented Application::Name all
acpaquette Jul 20, 2023
f8eac13
Initial round of test fixes
acpaquette Jul 21, 2023
03cdf0e
Updated IException test truth data
acpaquette Jul 24, 2023
3e353ce
Moved Endian into core
acpaquette Jul 26, 2023
cf8a1de
Remove additional 'm' extension for python 3.10
acpaquette Jul 26, 2023
2c89869
Set version to 0.0.1 and clamped qt bellow 5.15
acpaquette Jul 26, 2023
825e725
Initial changes for isis pvl python interface
acpaquette Aug 14, 2023
443d460
Removed prints causing test failures
acpaquette Oct 4, 2023
0324026
QPair -> std::pair
amystamile-usgs Oct 11, 2023
32c487c
removed QT from ArraySubscriptNotInRange
amystamile-usgs Oct 11, 2023
d02d74c
removed QT from Message::Keyword*
amystamile-usgs Oct 11, 2023
2889ee9
Updated MissingDelimiter.cpp and deps
amystamile-usgs Oct 12, 2023
b19b4c5
Updated MemoryAllocFailed
amystamile-usgs Oct 12, 2023
97088ed
compiling updates
amystamile-usgs Oct 16, 2023
1de2c68
PvlSequence updated
amystamile-usgs Oct 16, 2023
51c42f8
Updated table, tablefield, and tablerecord
amystamile-usgs Oct 18, 2023
3337b38
large chunk of PVL updates
amystamile-usgs Oct 26, 2023
f949307
more pvl updates
amystamile-usgs Oct 27, 2023
06c471b
more PVL updates
amystamile-usgs Oct 30, 2023
32ee89e
Remove qt deps (#5313)
amystamile-usgs Oct 19, 2023
8c4d685
pvl remove qt changes
Aug 16, 2024
2e38188
more removal of qt from pvl
amystamile-usgs Aug 20, 2024
4a38f6f
Removed qt from FileName.cpp
amystamile-usgs Aug 28, 2024
f19a207
Removed QStrings from IString in ISIS core
acpaquette Aug 23, 2024
e28401c
Remove final QString elements from IString
acpaquette Sep 3, 2024
6abf3d4
Initial propogation of IString changes
acpaquette Sep 4, 2024
5efcaa4
Change in progress
amystamile-usgs Sep 6, 2024
ac54764
Updated base objects
amystamile-usgs Sep 9, 2024
866825b
Updated base apps
amystamile-usgs Sep 9, 2024
ed277dc
Updated core tests
amystamile-usgs Sep 9, 2024
e530fb1
updated control and database files
amystamile-usgs Sep 10, 2024
d5cbace
Updated qisis files
amystamile-usgs Sep 11, 2024
b6744b3
updated remaining obj and app files
amystamile-usgs Sep 12, 2024
2a47fb0
updated base unit tests
amystamile-usgs Sep 13, 2024
bd2b832
more updates
amystamile-usgs Sep 16, 2024
bcffcb8
More updates
amystamile-usgs Sep 17, 2024
e1fc03b
Updated std::to* calls to Isis::to* calls
AustinSanders Sep 17, 2024
70b1818
Updated type of m_keywords from std::vector to std::list
AustinSanders Sep 17, 2024
16e5807
Changed std::to* calls to Isis::to* calls
AustinSanders Sep 17, 2024
6a611fd
Removed bracket from regex
AustinSanders Sep 17, 2024
4206cb5
Removed line that adds unnecessary whitespace to comments
AustinSanders Sep 17, 2024
1d756f1
fixed pvl iterators
amystamile-usgs Sep 18, 2024
ab0d5e9
final updates
amystamile-usgs Sep 18, 2024
6cfc115
Updated recent merged changes
amystamile-usgs Sep 18, 2024
2c5c712
Fix linux errors
amystamile-usgs Sep 19, 2024
eba222c
JP2 changes
amystamile-usgs Sep 19, 2024
680a8ca
Fixes ThreeImageNetwork segfaults
amystamile-usgs Sep 20, 2024
90056e1
seg fault fix
amystamile-usgs Sep 20, 2024
48b15b9
rebase fixes
amystamile-usgs Sep 21, 2024
10639e1
Convert std:: to IString - fixes formating test errors
amystamile-usgs Sep 23, 2024
0ad7f33
fixes segfaults
amystamile-usgs Sep 24, 2024
c1a3c61
fixed gtests part 1
amystamile-usgs Sep 25, 2024
4db0a28
fixed gtest part 2
amystamile-usgs Sep 26, 2024
0775a1f
Update std::tostring, stoi, stod to IString functions
AustinSanders Sep 23, 2024
db26f69
Updated formatting for tests
AustinSanders Sep 26, 2024
483fb4b
Fix unit tests
AustinSanders Sep 27, 2024
dd11f80
Fixed unit test
AustinSanders Sep 27, 2024
edfe874
fixed gtests part 3
amystamile-usgs Sep 30, 2024
9346e66
Rebase updates
amystamile-usgs Jan 27, 2025
b8037ec
Fixed tests from rebase
amystamile-usgs Jan 27, 2025
d432331
kerneldb test fixes
amystamile-usgs Jan 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
seg fault fix
amystamile-usgs committed Jan 27, 2025
commit 90056e14617c2b61713d4b13168e11e6d0f42cf9
4 changes: 2 additions & 2 deletions isis/src/base/objs/CubeAttribute/CubeAttribute.h
Original file line number Diff line number Diff line change
@@ -218,7 +218,7 @@ namespace Isis {
* FileName("out.cub+Bsq")
*/
void addAttributes(const FileName &fileNameWithAtts) {
addAttributes(fileNameWithAtts.attributes());
addAttributes(QString::fromStdString(fileNameWithAtts.attributes()));
}


@@ -231,7 +231,7 @@ namespace Isis {
* "+Bsq+Real" or "Bsq+Real"
*/
void addAttributes(const char *attributesString) {
addAttributes(std::string(attributesString));
addAttributes(QString(attributesString));
}