Skip to content

Commit aaa21da

Browse files
author
zhaoge
committed
feat: update endContextList of collect attribute
1 parent 0e2691b commit aaa21da

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

src/parser/hive/hiveEntityCollector.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { HiveSqlParserListener } from '../../lib';
22
import {
3+
ColumnNameCommentContext,
34
ColumnNameCreateContext,
45
ColumnNameTypeConstraintContext,
56
CreateDatabaseStatementContext,
67
CreateFunctionStatementContext,
78
CreateMaterializedViewStatementContext,
89
CreateTableStatementContext,
910
CreateViewStatementContext,
10-
DatabaseCommentContext,
1111
DbSchemaNameContext,
1212
DbSchemaNameCreateContext,
1313
FromInsertStmtContext,
@@ -16,7 +16,6 @@ import {
1616
InsertStmtContext,
1717
SelectStatementContext,
1818
StatementContext,
19-
TableCommentContext,
2019
TableNameContext,
2120
TableNameCreateContext,
2221
TableSourceContext,
@@ -32,7 +31,7 @@ export class HiveEntityCollector extends EntityCollector implements HiveSqlParse
3231
exitTableNameCreate(ctx: TableNameCreateContext) {
3332
this.pushEntity(ctx, EntityContextType.TABLE_CREATE, {
3433
attrNameList: [AttrName.comment],
35-
endContextList: [TableCommentContext.name],
34+
endContextList: [CreateTableStatementContext.name],
3635
});
3736
}
3837

@@ -53,14 +52,14 @@ export class HiveEntityCollector extends EntityCollector implements HiveSqlParse
5352
exitColumnNameCreate(ctx: ColumnNameCreateContext) {
5453
this.pushEntity(ctx, EntityContextType.COLUMN_CREATE, {
5554
attrNameList: [AttrName.comment, AttrName.colType],
56-
endContextList: [ColumnNameTypeConstraintContext.name],
55+
endContextList: [ColumnNameTypeConstraintContext.name, ColumnNameCommentContext.name],
5756
});
5857
}
5958

6059
exitViewNameCreate(ctx: ViewNameCreateContext) {
6160
this.pushEntity(ctx, EntityContextType.VIEW_CREATE, {
6261
attrNameList: [AttrName.comment],
63-
endContextList: [TableCommentContext.name],
62+
endContextList: [CreateViewStatementContext.name],
6463
});
6564
}
6665

@@ -71,7 +70,7 @@ export class HiveEntityCollector extends EntityCollector implements HiveSqlParse
7170
exitDbSchemaNameCreate(ctx: DbSchemaNameCreateContext) {
7271
this.pushEntity(ctx, EntityContextType.DATABASE_CREATE, {
7372
attrNameList: [AttrName.comment],
74-
endContextList: [DatabaseCommentContext.name],
73+
endContextList: [CreateDatabaseStatementContext.name],
7574
});
7675
}
7776

src/parser/impala/impalaEntityCollector.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { ImpalaSqlParserListener } from '../../lib';
22
import {
33
ColumnDefinitionContext,
44
ColumnNamePathCreateContext,
5-
CommentClauseContext,
65
CreateAggregateFunctionContext,
76
CreateFunctionContext,
87
CreateKuduTableAsSelectContext,
@@ -32,7 +31,7 @@ export class ImpalaEntityCollector extends EntityCollector implements ImpalaSqlP
3231
exitTableNameCreate(ctx: TableNameCreateContext) {
3332
this.pushEntity(ctx, EntityContextType.TABLE_CREATE, {
3433
attrNameList: [AttrName.comment],
35-
endContextList: [CommentClauseContext.name],
34+
endContextList: [CreateTableSelectContext.name, CreateKuduTableAsSelectContext.name],
3635
});
3736
}
3837

src/parser/spark/sparkEntityCollector.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import {
22
ColumnNameCreateContext,
3-
CommentSpecContext,
43
CreateFunctionContext,
54
CreateNamespaceContext,
65
CreateOrReplaceTableColTypeContext,
7-
CreateTableClausesContext,
86
CreateTableContext,
97
CreateTableLikeContext,
108
CreateTempViewUsingContext,
@@ -58,7 +56,7 @@ export class SparkEntityCollector extends EntityCollector implements SparkSqlPar
5856
exitTableNameCreate(ctx: TableNameCreateContext) {
5957
this.pushEntity(ctx, EntityContextType.TABLE_CREATE, {
6058
attrNameList: [AttrName.comment],
61-
endContextList: [CreateTableClausesContext.name],
59+
endContextList: [CreateTableContext.name],
6260
});
6361
}
6462

@@ -81,7 +79,6 @@ export class SparkEntityCollector extends EntityCollector implements SparkSqlPar
8179
this.pushEntity(ctx, EntityContextType.COLUMN_CREATE, {
8280
attrNameList: [AttrName.comment, AttrName.colType],
8381
endContextList: [
84-
CommentSpecContext.name,
8582
CreateOrReplaceTableColTypeContext.name,
8683
IdentifierCommentContext.name,
8784
],

src/parser/trino/trinoEntityCollector.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
QueryStatementContext,
1515
SchemaNameCreateContext,
1616
SchemaRefContext,
17-
SelectItemContext,
1817
SingleStatementContext,
1918
TableNameCreateContext,
2019
TableRefContext,
@@ -50,7 +49,7 @@ export class TrinoEntityCollector extends EntityCollector implements TrinoSqlLis
5049
needCollectAttr
5150
? {
5251
attrNameList: [AttrName.alias],
53-
endContextList: [SelectItemContext.name, AliasedRelationContext.name],
52+
endContextList: [AliasedRelationContext.name],
5453
}
5554
: undefined
5655
);

0 commit comments

Comments
 (0)