Add script to perform release #9174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
type: enhancement
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036365
Total [baseline] (10.69 s) : 0, 10689702
Agent [candidate] (1.038 s) : 0, 1038416
Total [candidate] (10.624 s) : 0, 10623833
section appsec
Agent [baseline] (1.225 s) : 0, 1224977
Total [baseline] (10.791 s) : 0, 10790927
Agent [candidate] (1.215 s) : 0, 1215035
Total [candidate] (10.762 s) : 0, 10762018
section iast
Agent [baseline] (1.178 s) : 0, 1177875
Total [baseline] (10.898 s) : 0, 10898057
Agent [candidate] (1.181 s) : 0, 1180754
Total [candidate] (10.926 s) : 0, 10926167
section profiling
Agent [baseline] (1.183 s) : 0, 1182673
Total [baseline] (10.832 s) : 0, 10832478
Agent [candidate] (1.198 s) : 0, 1197861
Total [candidate] (10.982 s) : 0, 10981614
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (727.889 ms) : 0, 727889
BytebuddyAgent [candidate] (729.71 ms) : 0, 729710
GlobalTracer [baseline] (240.9 ms) : 0, 240900
GlobalTracer [candidate] (241.183 ms) : 0, 241183
AppSec [baseline] (30.397 ms) : 0, 30397
AppSec [candidate] (30.338 ms) : 0, 30338
Debugger [baseline] (6.003 ms) : 0, 6003
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (654.116 µs) : 0, 654
Remote Config [candidate] (658.134 µs) : 0, 658
Telemetry [baseline] (8.176 ms) : 0, 8176
Telemetry [candidate] (8.169 ms) : 0, 8169
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (757.115 ms) : 0, 757115
BytebuddyAgent [candidate] (750.46 ms) : 0, 750460
GlobalTracer [baseline] (235.772 ms) : 0, 235772
GlobalTracer [candidate] (233.623 ms) : 0, 233623
AppSec [baseline] (168.998 ms) : 0, 168998
AppSec [candidate] (168.366 ms) : 0, 168366
Debugger [baseline] (7.908 ms) : 0, 7908
Debugger [candidate] (6.301 ms) : 0, 6301
Remote Config [baseline] (605.029 µs) : 0, 605
Remote Config [candidate] (595.734 µs) : 0, 596
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (9.567 ms) : 0, 9567
IAST [baseline] (23.609 ms) : 0, 23609
IAST [candidate] (23.511 ms) : 0, 23511
section iast
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (852.663 ms) : 0, 852663
BytebuddyAgent [candidate] (853.483 ms) : 0, 853483
GlobalTracer [baseline] (230.766 ms) : 0, 230766
GlobalTracer [candidate] (232.332 ms) : 0, 232332
AppSec [baseline] (24.787 ms) : 0, 24787
AppSec [candidate] (27.308 ms) : 0, 27308
Debugger [baseline] (6.668 ms) : 0, 6668
Debugger [candidate] (7.473 ms) : 0, 7473
Remote Config [baseline] (587.599 µs) : 0, 588
Remote Config [candidate] (587.615 µs) : 0, 588
Telemetry [baseline] (7.845 ms) : 0, 7845
Telemetry [candidate] (7.923 ms) : 0, 7923
IAST [baseline] (32.232 ms) : 0, 32232
IAST [candidate] (29.176 ms) : 0, 29176
section profiling
crashtracking [baseline] (1.395 ms) : 0, 1395
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (758.784 ms) : 0, 758784
BytebuddyAgent [candidate] (768.33 ms) : 0, 768330
GlobalTracer [baseline] (220.157 ms) : 0, 220157
GlobalTracer [candidate] (222.243 ms) : 0, 222243
AppSec [baseline] (30.292 ms) : 0, 30292
AppSec [candidate] (30.868 ms) : 0, 30868
Debugger [baseline] (6.241 ms) : 0, 6241
Debugger [candidate] (6.376 ms) : 0, 6376
Remote Config [baseline] (663.088 µs) : 0, 663
Remote Config [candidate] (690.641 µs) : 0, 691
Telemetry [baseline] (13.263 ms) : 0, 13263
Telemetry [candidate] (9.703 ms) : 0, 9703
ProfilingAgent [baseline] (103.669 ms) : 0, 103669
ProfilingAgent [candidate] (109.386 ms) : 0, 109386
Profiling [baseline] (103.693 ms) : 0, 103693
Profiling [candidate] (109.41 ms) : 0, 109410
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1035798
Total [baseline] (8.608 s) : 0, 8607947
Agent [candidate] (1.038 s) : 0, 1038249
Total [candidate] (8.606 s) : 0, 8606335
section iast
Agent [baseline] (1.173 s) : 0, 1172816
Total [baseline] (9.258 s) : 0, 9257686
Agent [candidate] (1.18 s) : 0, 1180052
Total [candidate] (9.304 s) : 0, 9303803
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (727.912 ms) : 0, 727912
BytebuddyAgent [candidate] (729.852 ms) : 0, 729852
GlobalTracer [baseline] (240.44 ms) : 0, 240440
GlobalTracer [candidate] (241.012 ms) : 0, 241012
AppSec [baseline] (30.358 ms) : 0, 30358
AppSec [candidate] (30.309 ms) : 0, 30309
Debugger [baseline] (6.005 ms) : 0, 6005
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (656.103 µs) : 0, 656
Remote Config [candidate] (649.1 µs) : 0, 649
Telemetry [baseline] (8.194 ms) : 0, 8194
Telemetry [candidate] (8.18 ms) : 0, 8180
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (846.576 ms) : 0, 846576
BytebuddyAgent [candidate] (853.196 ms) : 0, 853196
GlobalTracer [baseline] (231.088 ms) : 0, 231088
GlobalTracer [candidate] (231.737 ms) : 0, 231737
AppSec [baseline] (27.466 ms) : 0, 27466
AppSec [candidate] (28.328 ms) : 0, 28328
Debugger [baseline] (8.553 ms) : 0, 8553
Debugger [candidate] (5.77 ms) : 0, 5770
Remote Config [baseline] (593.583 µs) : 0, 594
Remote Config [candidate] (589.634 µs) : 0, 590
Telemetry [baseline] (7.959 ms) : 0, 7959
Telemetry [candidate] (7.935 ms) : 0, 7935
IAST [baseline] (28.234 ms) : 0, 28234
IAST [candidate] (30.177 ms) : 0, 30177
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (37.699 ms) : 37398, 38000
. : milestone, 37699,
appsec (47.435 ms) : 46996, 47875
. : milestone, 47435,
code_origins (45.863 ms) : 45467, 46259
. : milestone, 45863,
iast (43.393 ms) : 43024, 43762
. : milestone, 43393,
profiling (49.864 ms) : 49395, 50332
. : milestone, 49864,
tracing (45.203 ms) : 44824, 45582
. : milestone, 45203,
section candidate
no_agent (36.14 ms) : 35844, 36435
. : milestone, 36140,
appsec (47.846 ms) : 47408, 48284
. : milestone, 47846,
code_origins (43.432 ms) : 43059, 43806
. : milestone, 43432,
iast (43.454 ms) : 43079, 43830
. : milestone, 43454,
profiling (47.541 ms) : 47105, 47978
. : milestone, 47541,
tracing (42.634 ms) : 42270, 42998
. : milestone, 42634,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (4.275 ms) : 4227, 4323
. : milestone, 4275,
iast (9.353 ms) : 9200, 9506
. : milestone, 9353,
iast_FULL (14.329 ms) : 14042, 14615
. : milestone, 14329,
iast_GLOBAL (9.837 ms) : 9659, 10016
. : milestone, 9837,
profiling (8.461 ms) : 8328, 8594
. : milestone, 8461,
tracing (7.731 ms) : 7619, 7843
. : milestone, 7731,
section candidate
no_agent (4.391 ms) : 4340, 4443
. : milestone, 4391,
iast (9.162 ms) : 9012, 9313
. : milestone, 9162,
iast_FULL (13.8 ms) : 13528, 14072
. : milestone, 13800,
iast_GLOBAL (9.922 ms) : 9750, 10093
. : milestone, 9922,
profiling (8.616 ms) : 8476, 8755
. : milestone, 8616,
tracing (7.662 ms) : 7542, 7782
. : milestone, 7662,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (15.122 s) : 15122000, 15122000
. : milestone, 15122000,
appsec (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
iast (18.553 s) : 18553000, 18553000
. : milestone, 18553000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (15.467 s) : 15467000, 15467000
. : milestone, 15467000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
section candidate
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
iast (17.903 s) : 17903000, 17903000
. : milestone, 17903000,
iast_GLOBAL (18.12 s) : 18120000, 18120000
. : milestone, 18120000,
profiling (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~d5ed76280b, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.645 ms) : 3431, 3859
. : milestone, 3645,
iast (2.19 ms) : 2127, 2253
. : milestone, 2190,
iast_GLOBAL (2.227 ms) : 2165, 2290
. : milestone, 2227,
profiling (2.029 ms) : 1979, 2079
. : milestone, 2029,
tracing (2.01 ms) : 1962, 2059
. : milestone, 2010,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.612 ms) : 3395, 3830
. : milestone, 3612,
iast (2.19 ms) : 2128, 2253
. : milestone, 2190,
iast_GLOBAL (2.226 ms) : 2164, 2289
. : milestone, 2226,
profiling (2.05 ms) : 1999, 2102
. : milestone, 2050,
tracing (2.002 ms) : 1953, 2050
. : milestone, 2002,
|
PerfectSlayer
force-pushed
the
bbujon/ci
branch
2 times, most recently
from
b7a17c5 to
7450b1c
Compare
amarziali
approved these changes
Jul 16, 2025
bric3
reviewed
Jul 16, 2025
| fi | ||
|
|
||
| # Check if working copy is clean | ||
| if ! git diff-index --quiet HEAD; then |
There was a problem hiding this comment.
note: This could be detected by the --dirty option in git describe
There was a problem hiding this comment.
git describe --dirty will report untracked file.
Do we want to check them as well? 🤷 (I usually have some scripts related to repo management on the side that I never commit 😅 )
There was a problem hiding this comment.
I don't believe so, for example
❯ git status --short --branch
## master...origin/master
❯ touch a
❯ git describe --abbrev=8 --tags --first-parent --match="v[0-9].[0-9]*.[0-9]" --dirty
v1.51.0-42-g847275bc
❯ git status --short --branch
## master...origin/master
?? a
while
❯ echo "// ..." >> build.gradle
❯ git status --short --branch
## master...origin/master
M build.gradle
❯ git describe --abbrev=8 --tags --first-parent --match="v[0-9].[0-9]*.[0-9]" --dirty
v1.51.0-42-g847275bc-dirty
The --dirty identifies local modifications, so untracked files are not accounted.
There was a problem hiding this comment.
You're right. --dirty is not impacted by untracked changed.
But I still struggle to find out why git describe: Give an object a human readable name based on an available ref is more suited that git diff-index: _ Compare a tree to the working tree or index_
Especially since there is no easy way to interact with the human readable name 🤔
There was a problem hiding this comment.
Sorry for not being clear, my purpose in writing this note is see if it was useful to to perform a single command from to get the dirtiness ad the latest tag (i.e combine L45 and L62). The current code is not problematic, and the ROI there is ... vague. Feel free to dismiss this comment.
bric3
approved these changes
Jul 17, 2025
| # Check the git log history | ||
| LAST_RELEASE_TAG=$(git describe --tags --abbrev=0 --match='v[0-9]*.[0-9]*.[0-9]*') | ||
| echo "ℹ️ Last release version: $LAST_RELEASE_TAG" | ||
| SUSPICIOUS_COMMITS=$(git log --oneline --first-parent "$LAST_RELEASE_TAG"..HEAD | grep -E -v "Merge pull request #" | grep -E -v "\(#") |
There was a problem hiding this comment.
note: I just noticed that PR merged with the merge queue (e.g. via the /merge comment in a PR) are not suffixed with the PR number ((#XXXX)). So this command grep -E -v "\(#") will output merge commits like:
Making members static final to avoid repeated work & allocation
There was a problem hiding this comment.
/merge is related to merge-queue right?
If so, it should not be an issue as we don't use it on this repo as it messes with our CI build (our build is a already based merge build)
And yes, it happens sometimes, that's why it is not blocking but requires manual confirmation to continue.
There was a problem hiding this comment.
But after looking it up, it might be possible to disable it, by adding this repository.datadog.yml file at the repo root.
---
schema-version: v1
kind: mergequeue
enable: falseThere was a problem hiding this comment.
Oh interesting! I will disable it then 👍
bric3
reviewed
Jul 17, 2025
| --- | ||
| schema-version: v1 | ||
| kind: mergequeue | ||
| enable: false |
There was a problem hiding this comment.
suggestion: Might be worth adding the reason why it's disabled. As it might be obvious why.
Suggested change
| enable: false | |
| # Disabled because it messes with our existing CI ...to be completed | |
| enable: false |
There was a problem hiding this comment.
Damned, this was merged with auto-merge. We will add it in the next commit that fixes the unknown (yet) script issue 😬
mhlidd
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This script will replace the first step of the release process.
Motivation
It will help with the replacement of legacy gradle plugin by moving checks and computation in shell script instead to simplify our build. Check #9149
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]