Commit 9ba3709
authored
ci: update benchmark slo + reporting dependencies (#15339)
## Description
Only run SLO check if the benchmark jobs all succeeded.
Only run the reporting if the SLO check job ran.
Right now if a benchmarks fails (programming error, or infra issues,
etc), we still run the SLO check, which we know will fail because we
don't report all benchmark results, then we also run the benchmark
reporter which will succeed. If you then go back and re-run the failed
benchmark job (assuming flaky infra, for example), then you have to know
to manually re-run the SLO check and the reporting job as well).
This should simplify and clarify some of it a little bit.
## Testing
<!-- Describe your testing strategy or note what tests are included -->
## Risks
<!-- Note any risks associated with this change, or "None" if no risks
-->
## Additional Notes
<!-- Any other information that would be helpful for reviewers -->1 parent 441fc1c commit 9ba3709
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
| |||
211 | 212 | | |
212 | 213 | | |
213 | 214 | | |
214 | | - | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| |||
0 commit comments