Skip to content

Commit 9ba3709

Browse files
authored
ci: update benchmark slo + reporting dependencies (#15339)
## Description Only run SLO check if the benchmark jobs all succeeded. Only run the reporting if the SLO check job ran. Right now if a benchmarks fails (programming error, or infra issues, etc), we still run the SLO check, which we know will fail because we don't report all benchmark results, then we also run the benchmark reporter which will succeed. If you then go back and re-run the failed benchmark job (assuming flaky infra, for example), then you have to know to manually re-run the SLO check and the reporting job as well). This should simplify and clarify some of it a little bit. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
1 parent 441fc1c commit 9ba3709

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.gitlab/benchmarks/microbenchmarks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ benchmarks-pr-comment:
187187
image: $MICROBENCHMARKS_CI_IMAGE
188188
tags: ["arch:amd64"]
189189
stage: report
190+
needs: [ "check-slo-breaches" ]
190191
when: always
191192
allow_failure: true
192193
script: |
@@ -211,7 +212,6 @@ benchmarks-pr-comment:
211212

212213
check-slo-breaches:
213214
stage: gate
214-
when: always
215215
tags: ["arch:amd64"]
216216
image: registry.ddbuild.io/images/benchmarking-platform-tools-ubuntu:latest
217217
artifacts:

0 commit comments

Comments
 (0)